The toon's bank has two leatherworking bags and a reagent bag.

I've noticed that even though I sorted my bank with Baganator (by type), I don't have room to put equipment in the normal bank bags because there are cooking reagents in them.

The cooking reagents are there because the reagent bag is filled with leather reagents that could go into the leatherworking bags (which have space). But Baganator does not seem to give priority to the profession bags.

Interestingly, with other sort methods than type, the results are better:

The following are the free slots after different sorting methods:

Perhaps part of the problem comes from multiple stacks of the same leather reagent that Baganator tries to keep together in the reagent bank (?). But even the largest group of these (7 stacks of Burnished Leather) would easily fit into the leatherworking bags.

IMHO, priority #⁠1 should be to get the most possible free space in the normal bags, no matter the sorting method.

Edit: Added note to 'Best'.

Fixed in the latest alpha release
Baganator-0.145-3-g201d9cb.zip

Please confirm that the issue is fixed for you too.

Please confirm

Can test it later today (2–3h)

OK, tested it on the same toon as yesterday. The bank content has changed a bit, but not substantially.

It's almost perfect now:

So, expansion sort is still best :)

The profession bags are completely filled with all methods now, the 1 slot difference is between reagent and regular bags.

The one thing that makes the difference is a Draconic Treatise on Leatherworking (194700). The Expansion sort puts it correctly in the leatherworking bags (and one other leather item in the reagent bag for it), and the other methods keep the Treatise in the normal bags.

PS:

I just found 2 more items that could go in the leather bags, but all the sorting methods keep them in the normal bags (while there is still room in the reagent bag to move other leather items to it):

• Spirit of the Bested (168138)
• Long Regal Sinew (168139)

So, the optimum would be 23 free slots in the normal bags.

Cannot 100% exclude that there are more misplaced items, but it doesn't seem so so far.

Does the Blizzard sort do this correctly, I'm curious?

Does the Blizzard sort do this correctly […]?

If there is enough room in the LW bags, Blizz sort puts the 3 items there. If there are more LW items in the bank than can fit in the LW bags, Blizz gives priority to other LW items (seemingly Tradeskill items). I made sure that all bag flags (eg priorities and DisableAutoSort) were cleared.

It's not entirely trivial to compare Baganator's sorting to Blizz's, since Baganator doesn't sort the reagent bag separately from other bags (good!). So I mailed away tons of LW items to get them down to a number that cannot fill the LW bags: All Baganator searches then put the 3 items in the LW bags too.

So, the result is very similar to Blizz's sort, I would say. But: Blizz's sort cannot do better becaue it cannot shift items to the Reagent bag, while Baganator could do better because it can shift items to the Reagent bag.

[…] I'm curious

I'm glad to see that curiosity is the reason for this question. Because if we followed Blizzard's programming practices, we wouldn't have many great addons ;)

One interesting thing:

When I started the tests today (before mailing away LW items) I noticed that Expansion search puts the 3 items from my last post in the LW bags today.

My bank content has changed a little since yesterday, and I could verify that this is simply caused by less LW items in the bank (but still way more than can fit in the LW bags).

If I put more LW items in the bank, then the result is more like yesterday again (in both cases with enough room in the Reagent bags to give the possibility to shift LW reagents there).

The Type search though never puts the 3 items in the LW bags (unless – see above – the LW bags cannot be filled otherwise).

So with less LW reagents in the bank than yesterday (but still more than fit in the LW bags), the free space diff is more pronounced again:

I know that sorting can be a very complex thing (I can't wrap my head around any sorting algorithms, my brain goes crazy in no time ;). So please don't spend too much time on this huge effort/small improvement stuff if you have more serious problems to solve. — It's already fantastic that prof bags now have priority.

As an aside:

For accessing the bag flags I had to disable Baganator, reload, unset the Blizz bag flags, enable Baganator and reload again. I wished there was a way to access the bag flags from within Baganator's UI (e.g. context menu via right click on bag icon), but I couldn't find one.

I saw then that there is an existing suggestion for that (point 1 of issue #6), and you replied with "Done" for point 1, but the OP couldn't find the functionality. I can't either, but maybe we are missing something?

But, this is also not of overwhelming importance.

I've spent some more time on this issue, got a solution:

Baganator-146-1-g5e64919.zip

Can you try it out and see if it works for you?

This version prioritises items by how many different kind of bags they can fit into. The ideal being that the LW items that don't go in the reagent bag will fit in fewer bags, causing them to be prioritised for the LW bags.

Oh wow, I just did a quick test, but the 3 nasty items are now sorted into the LW bags by all methods, and I couldn't find a single item in the normal bags that could go into the reagent or LW bags. LW bags filled and 10 free slots in the reagent bag by all 5 sorting methods! Also a second test with ~20 less items in the bank gave the same distribution of free slots by all methods.

So yes, it works for me :)

Great job! Thank you very much!