Baggins

Baggins

1M Downloads

LibGratuity is ancient and causing problems

WanderingFox opened this issue ยท 8 comments

commented

I opened this issue a few months ago re: LibGratuity causing all sorts of havoc... Bagnon has refused to address the issue because LibGratuity is really old (last update 2014) and it's tainting CallbackHandler (see: Jaliborc/Bagnon#1118)

Would it be possible to consider swapping to a different method of tooltip scanning? This has cropped up in other addons as well (see: https://www.curseforge.com/wow/addons/elkbuffbars?comment=2097 etc)

commented

looking into it.

commented

If I had to guess though from that error I also see use of AceLibrary from another adon which is also really old and outdated. LibGratuity does extra things if AceLibrary is loaded im guessing the issue really is AceLibrary use. I know I pointed fingers before but having looked into it more and the fact that I don't get any error im pretty confident its that.

commented

It's possible. I'm not at my personal machine at the moment, but I'll confirm that nothing else is loading AceLibrary... It's entirely possible I've got something else from the olden days still in there that I forgot to disable when testing and have just happened to stumble on the stack overflow landmine.

In either case it's probably worth knowing that something goes sideways in this specific edge case.

I'll get back to you with my findings when I'm next at my machine. Thank you again for taking a look though!

commented

Your hunch was correct. I had missed a lib-databroker plugin that wasn't showing up in my list of addons in the twitch client, but was importing AceLibrary. Removing the old AceLibrary (via removing the offending addon completely) seems to have resolved the issue.

Sorry again for the run around!

commented

NP, the LibGratuity code though old still works fine as long as you don't have acelibrary loaded which in any somewhat up-to-date addon should never have. So while we cant change LibGratuity because of licensing issues as long as no other addon loads acelibrary which again should never happen, then everything works ok no errors. As it is not a dependency. Which is probably true of other addons as well.(not just applicable to baggins)

commented

In the mean time are you getting any error specifically when using baggins?

commented

Only the same C-stack overflow from LibGratuity as previously reported in #8

I've since just (mostly) ripped out lib-gratuity (and the associated tooltip scanning functionality) in a forked version and have been running on that since I don't usually use the tooltip scanning and it lets bagnon etc function.

commented

Well that references another addons functions. If you could provide the error from baggins use I can maybe narrow it down to its use and maybe find a solution, Id rather not reinvent the wheel in places I don't need to. And unfortunately I have not come across this issue. Thanks!