Q: Baggins:GetRuleDesc() dead code?
toneomgomg opened this issue · 2 comments
function Baggins:GetRuleDesc(rule) seems to be dead code. It is never used anywhere from within Baggins.
Is it ever used from other addons? If not, that it should be factored out from Baggins-filtering.luaand all associated filter rules.
Have not confirmed its use within baggins but of the four baggins plugings still showing up in curse/wowinterface it is never used. I think its safe to remove.
We could start with asserting a popup message in the function urging the
user to report back to you. That way we take out the guesswork, and don't
have to chance. By tagging the code in the cleanup, it will be a breeze to
bulk remove everything at a later date.
Den tis 5 maj 2020 21:33doadin <[email protected]> skrev:
… Have not confirmed its use within baggins but of the four baggins plugings
still showing up in curse/wowinterface it is never used. I think its safe
to remove.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUHFSHZC3ESHP5FIN3VGHDRQBSZVANCNFSM4MZRQFQA>
.