Baggins

Baggins

1M Downloads

BUG: Problem with PTSet submenus

toneomgomg opened this issue · 11 comments

commented

Compound submenus (ie. A-P, X-Y etc...) in the PeriodicTableSet filter does not work.

Steps to reproduce:

  1. Create category
  2. Add rule type "PeriodicTable Set"
  3. Click Edit
  4. Open InstanceLoot (for example)
  5. Try to open any of the submenus

bild

commented

I believe this to be an upstream issue. The curseforge page says Updated Feb 26, 2020. Latest file has a date of Sep 19, 2018. Not sure what to do about this.

commented

Just took a quick look. Pretty sure the bug has something to do with this snippet from Baggins-Filtering.lua. It seems like the submenus A-Z etc. are created by Baggins (possibly to avoid VERY long menus för big categories?)

I will take a look at this when i refactor out the filter to src/filters/PTSet.lua.

bild

commented

...on second thought - if the library is very old, maybe the filter should be disabled instead? The data must be ancient. Will check it out.

commented

SVN (https://repos.curseforge.com/wow/libperiodictable-3-1/trunk/libperiodictable-3-1) contains data up to and including Lich King.

I guess the only reasonable solution is to disable the filter until someone publishes a newer data-set to use...

commented

yea thats kind of what i was thinking it needs an update so its not really that useful at least not the instance ones?

commented

I'm tagging the code for removal. The PT3 code is a mess. I will make a PR with 2 commits. The first commit with everything tagged, and the second commit with everything removed.

commented

Sounds good, thanks!

commented

Should we want to use PT3 for classic, I would much rather rewrite the code into a separate filter. The code was littered across the addon, so it would have been a nightmare to maintain in any case.

I will look into creating a new filter (using the same outdated library, but for classic I guess it wouldnt matter that much). I could probably write the filter so existing rules will work as expected.

commented

naw just remove at least for now. I wouldn't bother.

commented

This sems to be only an issue with GearSet, InstanceLoot, and InstanceLootHeroic. Other menus go even further into sub levels.

commented