Sorting Keys
chkmyid opened this issue · 28 comments
Running Software (issues missing this information will be deleted):
- Addon version: 8.2.18-1.13.2
Have you read the changelog? (please don't waste our time)
Read
Describe the bug
When I click the Sort button, there is a phenomenon where items are arranged continuously and continuously without moving.
I had to type '/reload' to stop sorting.
Screenshots
Blizzard error frame loop: ERR_WRONG_BAG_TYPE
This also happens with 8.2.19 in Classic.
Other than reloadui you can also drag an item manually to another slot to stop it.
No Lua errors but it gets into an infinite loop of "That item doesn't go in that container" in errorframe.
8.2.19-1.13.3
When I pressed the Sort button, the key for the keyring did not appear in the inventory frame, but the sorting function was still not working properly.
The item does not move, but it looks like it is holding and leaving the quest item. This symptom repeats indefinitely and does not cause an error message.
I had to enter "/reload" in the chat window because there was no way I could stop this bug symptom.
Came here to say that too, sorting is now broken thanks to the key bag^^ Blending it out sadly doesn't help.
I don't get why keyrings and soulbags arent excluded from sorting. I have always issues with those...
(classic) Having the same issue. However it also tries to put the scepter for mara in the keyring as well.
The sorting option also pulls the keys from the bag. I did not have to /reload when it would continuously try to put items that wouldn't go into keyring, I just clicked a different item in my bag as if I were to pull it out and it stopped.
I have just posted a similar issue. It attempts to sort the relic coffer key into the keyring where it can't go. Causing this same issue.
I'm seeing the same issue. If I then move the keys to my bags, then do a sort, it will sort fine. But then subsequently moving my keys back to my keyring will then cause the sort to move those keys from my keyring into my bags.
Why not make sort on visible bags only. Will take care of any special bags or the ones we sorted ourselves. Like my healing gear on feral druid.
8.2.25-1.13.3
When the item was blinking without moving in a certain slot, the mouse pointer showed me the two keys that I had crossed. The key in the keyring slot hasn't moved, but I think this is the bug associated with the keyring.
@semlieguy Wow..Thank you for giving me a hint to stop this without reloading.
Same issue. I updated yesterday and got the continuous sort loop when I have keys in my bag. It continues to pop up the message "That item doesn't go in that container." If I take the keys out of my bag (put them in the bank) the sort works fine. Even if I manually move all the keys to the keyring, it breaks the sort.
I updated again this morning hoping the new update would fix it but the issue remains.
Yep, issue is still here in the newest version. This bug makes this addon useless currently, i'll have to switch to another :/
Same issue, endless loop while trying to sort items when keys are stored directly in the new keyring bag. Sort works correctly when no keys are in the keyring bag. Appears the sort logic is having problems with quest-related keys, e.g. Scarlet Key, Key to Searing Gorge.
my dirty fix is you gotta edit Sort:GetSpaces() in Bagnon\common\Wildpants\api\sorting.lua
and wrap the body of the for loop in
if not (bag == KEYRING_CONTAINER) then
giving you
function Sort:GetSpaces()
local spaces = {}
for _, bag in pairs(self.bags) do
if not (bag == KEYRING_CONTAINER) then
local container = Addon:GetBagInfo(self.owner, bag)
for slot = 1, (container.count or 0) do
local item = Addon:GetItemInfo(self.owner, bag, slot)
tinsert(spaces, {index = #spaces, bag = bag, slot = slot, family = container.family, item = item})
item.class = item.link and Search:ForQuest(item.link) and LE_ITEM_CLASS_QUESTITEM or item.class
item.space = spaces[#spaces]
end
end
end
return spaces
end
Latest update still has not corrected the key sort issue. Testing methodology:
- Disabled all installed addons except BagBrother, Bagnon, Bagnon Config, Bagnon Guild Bank & Bagnon Void Storage
- Displayed bags with various keys present in the key ring\bag, both soulbound (e.g. Crescent Key, Key to Searing Gorge) and quest items (e.g. Skeleton Key, Shadowforge Key)
- Launched cleanup - endless loop ... broke via /console reloadui
- Put all keys into the bank
- Cleaned bank ... no problem
- Cleaned bags ... no problem
@Jaliborc It's working well with the latest version. Thank you for your efforts.
Unless an issue is reported with 8.2.27, I'll be closing this tomorrow.
...
27th try is the charm?