Bagnon

Bagnon

122M Downloads

[Classic] Error in beta version when disenchanting items in the bag

fleetcommand opened this issue ยท 1 comments

commented

Running Software (issues missing this information will be deleted):

  • Addon version: 8.2.18 (current beta version)
  • WoW Classic

Have you read the changelog? (please don't waste our time)
Yes

Describe the bug
When disenchanting an item, an error message appears with the current beta version. After removing the beta version and reinstalling the release version of the addon I can confirm that the current release version does not have the issue, disenchanting works fine.

To Reproduce
Steps to reproduce the behaviour:

  1. Open your inventory (not sure if matters, but bagslots display is enabled, databroker disabled)
  2. Select "Disenchant" from your sidebar
  3. Click on an item in your inventory you want to disenchant
  4. An error message appears (see below)

Expected behaviour
No error message should happen, item should be disenchanged.

Screenshots
N/A

Error Logs
Date: 2019-12-14 12:20:06
ID: 1
Error occured in: AddOn: Bagnon
Count: 1
Message: Error: AddOn Bagnon attempted to call a forbidden function (UseContainerItem()) from a tainted execution path.
Debug:
[C]: UseContainerItem()
..\FrameXML\ContainerFrame.lua:1221: ContainerFrameItemButton_OnClick()
[string ":OnClick"]:12:
[string "
:OnClick"]:1
[C]: ?
Locals:
None
AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
ACP, v3.5.6
BagBrother, v
Bagnon, v8.2.18
Prat30Libraries, v
SlideBar, v8.2.6375 (SwimmingSeadragon)
Stubby, v8.2.6376 (SwimmingSeadragon)
BlizRuntimeLib_enUS v1.13.3.11303
(ck=ec)

Additional context
This is the Classic version.

commented

Running Software (issues missing this information will be deleted):

  • Addon version: 8.2.18
  • Server patch: 1.13.3 32790 Dec 9 2019 11303

Have you read the changelog? (please don't waste our time)
Yes.

Describe the bug
Using items from the bags that would be a protected action is not possible. (eg. disenchant, use a potion, hearthstone)

To Reproduce
Steps to reproduce the behaviour:

  1. Open Bags using keybind or click Dominos bag bar (makes no difference)
  2. R-Click on Hearthstone
  3. See Action Blocked Static Popup blaming Bagnon, action does not complete.

Expected behaviour
Expect to be able to use items as is possible in 8.2.16 and earlier.

Screenshots
WoWScrnShot_121419_162349

Error Logs
scriptError

6x [ADDON_ACTION_FORBIDDEN] AddOn 'Bagnon' tried to call the protected function 'UseContainerItem()'.
!BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519>
[C]:: in function 'UseContainerItem'
FrameXML\ContainerFrame.lua:1254: in function 'ContainerFrameItemButton_OnClick'
[string "*:OnClick"]:12: in function <[string "*:OnClick"]:1>
[C]:: ?
[C]:: ?

taintLog at Level1

12/14 02:16:22.693  Interface\FrameXML\ContainerFrame.lua:1254 ContainerFrameItemButton_OnClick()
12/14 02:16:22.693  An action was blocked because of taint from Bagnon - UseContainerItem()
12/14 02:16:22.693      Interface\FrameXML\ContainerFrame.lua:1254 ContainerFrameItemButton_OnClick()
12/14 02:16:22.693      ContainerFrame1Item3:OnClick()

taintLog at Level 2

12/14 02:21:48.958  Execution tainted by Bagnon while reading ToggleBackpack - TOGGLEBACKPACK:1
12/14 02:21:48.986  Execution tainted by Ace3 while reading BagnonMoneyFrame1 - Interface\FrameXML\MoneyFrame.lua:312 MoneyFrame_Update()
12/14 02:21:48.986      Interface\FrameXML\MoneyFrame.lua:288 MoneyFrame_UpdateMoney()
12/14 02:21:48.986      BagnonMoneyFrame1:OnShow()
12/14 02:21:48.986      CreateFrame()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\libs\Poncho-2.0\Poncho-2.0.lua:75
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\moneyFrame.lua:21 Construct()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\libs\Poncho-2.0\Poncho-2.0.lua:61
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\parented.lua:10
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\moneyFrame.lua:15
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:300 <unnamed>:CreateMoneyFrame()
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:287 <unnamed>:PlaceMoneyFrame()
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:95 <unnamed>:Layout()
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:65 <unnamed>:Update()
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:55 <unnamed>:RegisterSignals()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\frame.lua:20
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\inventory.lua:21
12/14 02:21:48.986      <unnamed>:Show()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\api\frames.lua:86 Show()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\api\frames.lua:78
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\features\autoDisplay.lua:146 ToggleBackpack()
12/14 02:21:48.986      TOGGLEBACKPACK:1
12/14 02:21:48.986  Execution tainted by Ace3 while reading BagnonMoneyFrame1 - Interface\FrameXML\MoneyFrame.lua:312 MoneyFrame_Update()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\moneyFrame.lua:49 BagnonMoneyFrame1:Update()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\moneyFrame.lua:44 BagnonMoneyFrame1:RegisterEvents()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\moneyFrame.lua:16
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:300 <unnamed>:CreateMoneyFrame()
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:287 <unnamed>:PlaceMoneyFrame()
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:95 <unnamed>:Layout()
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:65 <unnamed>:Update()
12/14 02:21:48.986      Interface\AddOns\Bagnon\addons\main\frame.lua:55 <unnamed>:RegisterSignals()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\frame.lua:20
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\classes\inventory.lua:21
12/14 02:21:48.986      <unnamed>:Show()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\api\frames.lua:86 Show()
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\api\frames.lua:78
12/14 02:21:48.986      Interface\AddOns\Bagnon\common\Wildpants\features\autoDisplay.lua:146 ToggleBackpack()
12/14 02:21:48.986      TOGGLEBACKPACK:1
12/14 02:21:52.175      GameTooltip:SetBagItem()
12/14 02:21:52.175      Interface\FrameXML\ContainerFrame.lua:1331 ContainerFrameItemButton_OnEnter()
12/14 02:21:52.175      Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua:370 ContainerFrame1Item3:ShowTooltip()
12/14 02:21:52.175      Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua:203 ContainerFrame1Item3:OnEnter()
12/14 02:21:52.175      Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua:375 ContainerFrame1Item3:UpdateTooltip()
12/14 02:21:52.175      Interface\FrameXML\GameTooltip.lua:496
12/14 02:21:52.175      Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua:370 ContainerFrame1Item3:ShowTooltip()
12/14 02:21:52.175      Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua:203 ContainerFrame1Item3:OnEnter()
12/14 02:21:52.175      Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua:375 ContainerFrame1Item3:UpdateTooltip()
12/14 02:21:52.175      Interface\FrameXML\GameTooltip.lua:496
12/14 02:21:52.315      UseContainerItem()
12/14 02:21:52.315      Interface\FrameXML\ContainerFrame.lua:1254 ContainerFrameItemButton_OnClick()
12/14 02:21:52.315      ContainerFrame1Item3:OnClick()
12/14 02:21:52.315  Interface\FrameXML\ContainerFrame.lua:1254 ContainerFrameItemButton_OnClick()
12/14 02:21:52.315  An action was blocked because of taint from Bagnon - UseContainerItem()
12/14 02:21:52.315      Interface\FrameXML\ContainerFrame.lua:1254 ContainerFrameItemButton_OnClick()
12/14 02:21:52.315      ContainerFrame1Item3:OnClick()

Additional context
Add any other context about the problem here.