Bagnon

Bagnon

122M Downloads

Quality border highlighting issue

hiddyz opened this issue · 10 comments

commented

I currently have an issue where the item quality glow borders are very very feint, with skinner enabled and the "Button Borders" option enabled under the Modules tab (in skinner settings).

The quality borders are displaying correctly for the void storage and gbank buttons, but not for the inventory and bank. See this screenshot: http://download.local.se/pic/bagnon_glow_issue.png

If I disable the "Button Borders" option in Skinner this issue goes away.

I'm not 100% sure if this is an issue with skinner or bagnon. (Obviously skinner is doing something that messes up bagnon, but not sure if skinner is doing it right and bagnon isn't handling it correctly or the other way around)

In the screenshot I had a lot of addons enabled but I did try disabling everything but Skinner and Bagnon and the issue is still there.

commented

Thank you for the feedback!

Yet, you should contact Skinner developers. Bagnon does not provide Skinner support.

commented

As I said, one of the addons are doing something wrong and since the only thing
skinner does is change the actual item border texture, my bet is on bagnon doing
something wrong (especially since it works for void storage and gbank storage
but nut for inventory/bank). I am also submitting a bug report with the skinner
devs.

On 10/29/12 22:14, João Cardoso wrote:

Thank you for the feedback!

Yet, you should contact Skinner developers. Bagnon does not provide Skinner support.


Reply to this email directly or view it on GitHub
#117 (comment).

commented

It works with Skinner disabled.

commented

That does not mean that bagnon is not doing something wrong.

commented

Yes it does, as Bagnon does not provide support for Skinner in any way. If it works without Skinner, it does what it should: to work properly alone. It delivers what it promises.

commented

My typical recommendation is that people not use skinner due to the issues it tended to cause with things

commented

I'm sorry, but that's just a terrible argument. There are plenty of arguments
you could have for not wanting to have to put in the work to keep compatibility
with other random addons, but claiming that an addon is only designed to work
standalone is just stupid.

People use many addons at the same time, that's a fact. If there's a problem
with compatibility between 2 popular addons those 2 different developer(teams)
usually try to fix the issue, and in this case I suspect it's fairly simple,
possibly just an issue with SetVertexColor or something similar making the alpha
setting lower than it should be.

Seems to me that Skinner is just doing something that is technically correct,
that is a case that your addon simply isn't handling properly. I mean it
obviously CAN handle it properly since the void storage and guild bank tabs are
not affected by this issue at all.

It's fine if you don't want to fix this, I can't force you, but do not bullshit
me by telling me what an addon is supposed to do.

Thank you for your time.

On 10/30/12 00:15, João Cardoso wrote:

Yes it does, as Bagnon does not provide support for Skinner in any way. If it
works without Skinner, it does what it should: to work properly alone. It
delivers what it promises.


Reply to this email directly or view it on GitHub
#117 (comment).

commented

I don't think Jaliborc is saying that the addon is designed to work in a bubble (it's not), but that since the problem you're having is only present with Skinner, then its a Skinner issue and therefore not supported by us.

I do understand what you mean by Bagnon could be doing something wrong, and if we had a published API for skinning Bagnon that wasn't functioning properly, then I'd call that a Bagnon issue. This is not the case with Skinner, however, as it's just doing its own thing and modifying the internals Bagnon itself.

commented

I'm not actually using the Bagnon skin from Skinner, I'm simply enabling the
"skin buttons" option in Skinner, which just replaces the button texture with
another texture (AFAIK). I believe you would get the same problem with Bagnon by
simply adding a different Interface/Buttons/UI-ActionButton-Border.blp file. I
might be wrong on this one though.

I do respect that it's completely up to you guys if you want to spend time
looking into a problem like this, as it is like you say, not technically a
problem with your addon. On the other hand I do suspect a lot of other people
are using Skinner and Bagnon together, so it would be nice.

On 10/30/12 04:08, Jason Greer wrote:

I don't think Jaliborc is saying that the addon is designed to work in a bubble
(it's not), but that since the problem you're having is only present with
Skinner, then its a Skinner issue and therefore not supported by us.

I do understand what you mean by Bagnon could be doing something wrong, and if
we had a published API for skinning Bagnon that wasn't functioning properly,
then I'd call that a Bagnon issue. This is not the case with Skinner, however,
as it's just doing its own thing and modifying the internals Bagnon itself.


Reply to this email directly or view it on GitHub
#117 (comment).

commented

Still, Skinner tries to skin Bagnon when you enable "skin buttons" and, apparently, is pretty much failing at it.
Tuller is right regarding the "bubble" part, that is not what I meant.

Please understand that we do not intent to support Skinner, as it is not even designed to be supported (it's the other way around, it tries to support other addons). If we did provided support, then that issue would be our responsibility. But we cannot take responsibility for every single addon that attempts to hack bagnon.

Once more, this should be handled by Skinner developers.
But thank you for the feedback!