Bagnon

Bagnon

122M Downloads

in TBC beta - sorting infinite loop

laytya opened this issue ยท 6 comments

commented

if i press Sorting button - sorting never stop and wow rise reaction "This item not fit this bag"

here is fix:

In sorting.lua - 170 line

condition need to append "or (family == 9 and GetItemFamily(id) == 256)"

commented

Hi All,

Same error here since today on all my characters. Never got it before.
It seems that it loops when he want to reorganize items on my main default bags with usual items not keys.

Bagnon_issue
s.

commented

Confirm bug. After 2 patches it fail to reorganize.
I have to do it, then /reload and move like 3 items it didnt organize. (The items are allways random)

commented

This fix appears to sort keys back into your main bags, but does stop the sorting loop.

commented

Happened to me when i had an item starting a quest, and it tried to sort it into key bag, stuck in the loop "The item does not go into that bag", it tried to swap key and quest start item, while key was in the key bag. When i deleted that item, the sorting moved the only key i had from the key bag into my normal bag.

commented

I have the same issue in tbc beta: infinite sorting loop (is trying to put things in keyring, can't, keeps trying). Only a /reload solves it. Bank sorting works fine.

I tried adding the code as above and then the whole addon errors out. I'm not a coder and perhaps I'm appending incorrectly. What should the actual code be for line 170, or that section?

commented

Function should looks like this (lines 168 - 174):

function Sort:FitsIn(id, family)
  return
    family == 0 or
    (Addon.IsRetail and bit.band(GetItemFamily(id), family) > 0 or GetItemFamily(id) == family) and
    select(9, GetItemInfo(id)) ~= 'INVTYPE_BAG' or
	(family == 9 and GetItemFamily(id) == 256)
end