Bagnon

Bagnon

127M Downloads

Searching in the bank window throws an error

SanjoSolutions opened this issue ยท 4 comments

commented

Running Software:

  • Addon version: Bagnon-10.0.14 for WoW-10.0.2
  • Client version: 10.0.2 (47067)

Describe the bug
Searching in the bank window throws an error.

To Reproduce
Steps to reproduce the behaviour:

  1. Open the bank window from the bag window.
  2. Search for something (i.e. "h")

Expected behaviour
The items which match the search term are highlighted. Zero errors.

Screenshots

WoWScrnShot_121522_060204

commented

Getting the same error on any search attempt in the bank.

commented

unfortunately bank searching seems to have been broken for some time, getting the same thing

commented

Is this being looked at or fixed? Still broken on WOTLK classic. Bagnon unusable for searching with cached bank open. Other addons like Inventorian do cached bank searching just fine, but it uses a different version of BagBrother that is not compatible with Bagnon.

Edit: The error is being caused from C_Item.GetItemLink being fed a bag/slot combo refering to a bank location, but the function will complain with this error if you are not actually at the bank. But BagBrother is storing item links somewhere because I can open cached bank and see the contents. Why are we trying to pull live bank data when not at a bank when you can just used the cached bank contents and reconstruct the search manually without C_Item.GetItemLink ?

commented

Still happening in wotlk 3.4.2, bagnon 10.0.16 for 3.4.1
From my understanding, 3.4.2 brought some API changes, and some addons that use ACE have problems until that is updated to ACE3. There are many versions of ACE3, some work, some don't. Maybe it's a good time to fix this bug?