Error while using bagnon
jebrown01 opened this issue · 11 comments
Date: 2023-01-18 16:43:58
ID: 5
Error occured in: Global
Count: 1
Message: ...rface/AddOns/BagBrother/addons/core/classes/item.lua line 458:
attempt to call field 'IsBattlePayItem' (a boolean value)
Debug:
[string "@Interface/AddOns/BagBrother/addons/core/classes/item.lua"]:458: IsPaid()
[string "@Interface/AddOns/BagBrother/addons/core/classes/item.lua"]:322: UpdateNewItemAnimation()
[string "@Interface/AddOns/BagBrother/addons/core/classes/item.lua"]:216: func()
[string "@Interface/AddOns/BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua"]:36:
...ns/BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua:30
Locals:
self = ContainerFrame2Item20 {
0 =
OnLeave = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:190
__super =
}
UnregisterAll = defined @Interface/AddOns/BagBrother/addons/core/classes/base.lua:27
IconOverlay = Texture {
}
UpdateCooldown = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:274
Bind = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:106
IconBorder = Texture {
}
flashAnim = AnimationGroup {
}
icon = ContainerFrame2Item20IconTexture {
}
Backgrounds =
}
UpdateTooltip = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:181
ExtendedOverlay = Texture {
}
readable = false
count = 20
__type = "Button"
__count = 55
GetFrameID = defined @Interface/AddOns/BagBrother/addons/core/classes/parented.lua:19
NewItemTexture = Texture {
}
Delay = defined @Interface/AddOns/BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua:27
SplitStack = defined @Interface/FrameXML/ContainerFrame_Shared.lua:1059
SendFrameSignal = defined @Interface/AddOns/BagBrother/addons/core/classes/base.lua:23
info =
}
BagStaticBottom = Texture {
}
GetTemplate = defined @Interface/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:108
UpdateLocked = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:224
UnregisterMessage = defined @Interface/AddOns/BagBrother/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:153
Update = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:198
flash = Texture {
}
frame = BagnonInventoryFrame1 {
}
RegisterFrameSignal = defined @Interface/AddOns/BagBrother/addons/core/classes/base.lua:15
RegisterMessage = defined @Interface/AddOns/BagBrother/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:90
GetBlizzard = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:93
UpdateSearch = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:294
hasItem = true
IconGlow = Texture {
}
NumInactive = defined @Interface/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:124
UnregisterSignal = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:78
GetInfo = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:432
GetBagFamily = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:415
SendMessage = defined @Interface/AddOns/BagBrother/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:59
GetProfile = defined @Interface/AddOns/BagBrother/addons/core/classes/parented.lua:23
GetClassName = defined @Interface/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:100
GetQuery = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:428
GetClass = defined @Interface/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:135
IsAbstract = defined @Interface/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:116
GetSuper = defined @Interface/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:104
Count = ContainerFrame2Item20Count {
}
OnEnter = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:181
OnPreClick = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:145
searchOverlay = ContainerFrame2Item20SearchOverlay {
}
Construct = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:52
BagFamilies =
}
IsSlot = defined @Interface/AddOns/BagBrother/addons/core/classes/item.lua:449
bag = 3
BattlepayItemTexture = Texture {
}
GetOwner = defined @Interface/AddOns/BagBrother/addons/core/classes/parented.lua:31
Super = defined @Interface/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:157
GetTipAnchor = defined @Interface/AddOns/BagBrother/addons/core/classes/tippe
AddOns:
Swatter, v3.4.6837 (SwimmingSeadragon)
BagBrother, v
Bagnon, v10.0.15
BeanCounter, v3.4.6811 (SwimmingSeadragon)
Enchantrix, v3.4.6849 (SwimmingSeadragon)
EnchantrixBarker, v3.4.6813 (SwimmingSeadragon)
Informant, v3.4.6850 (SwimmingSeadragon)
MapCoords, v0.39
NovaWorldBuffs, v2.43
Questie, v7.4.7
SlideBar, v3.4.6851 (SwimmingSeadragon)
Stubby, v3.4.6816 (SwimmingSeadragon)
BlizRuntimeLib_enUS v3.4.1.30401
(ck=1bb)
BagBrother/addons/core/classes/item.lua line 458:
need to change to;
return C_Contaibner.IsBattlePayItem(self:GetBag(), self:GetID())
Container not Contaibner, however it's still not a fix since the error still shoots sometimes when opening bags in game.
Since this function is responsible for highlighting items purchased from the in-game store, I just commented out line 458 and added return false
Seems to have fixed the issue well enough for me.
I think everything got changed to C_Container
sigh. Anyway, as of 3.41 bagnon no longer updates the frame with items that get moved, added, etc. You see an empty slot although you may have put an item in it
You can fix this issue temporarily by changing Events:BAG_UPDATE() in AddOns/BagBrother/addons/core/api/events.lua
The function starts at line 38:
function Events:BAG_UPDATE(event, bag)
self.queue[bag] = true
C_Timer.After(0.001, function() self:UpdateBags() end) -- Temporary fix due to missing BAG_UPDATE_DELAYED event
end
OOH thank you... is this just the one update or are there more in the lua?
Just the change to BAG_UPDATE and the previously mentioned change to IsPaid in item.lua (to skip IsBattlePayItem() and just return false)
Thanks for the line 38 patch. bagnon is working for me again.
If you guys want a patched version, here you go
https://cdn.discordapp.com/attachments/852761173559738421/1065458964868894790/Bagnon.zip
YOu should upload your file to a pull request so the author can build it into the addon release