Bagnon

Bagnon

122M Downloads

LUA error when right-clicking empty slot - minor

raysmith59 opened this issue ยท 4 comments

commented

Addon version: 10.0.16
Server patch: 10.0.5.47871
Have read changelog: Yes

This has been happening all expansion, I think; when I right-click an empty slot in my bags or bank - for science, obviously, not due to a mis-click or anything so mundane - I get this LUA error. Not impactful but finally getting around to reporting it:

4x ...rfaceBagBrother/addons/core/classes/item.lua:149: Usage: GetItemInfo(itemID|"name"|"itemlink")
[string "=[C]"]: in function `GetItemInfo'
[string "@BagBrother/addons/core/classes/item.lua"]:149: in function <...rfaceBagBrother/addons/core/classes/item.lua:146>

Locals:
(*temporary) = nil

commented

Bump to report same, tested with all other addons disabled. Minor, but still annoying when in a hurry to spam transfer items from a bank, etc.

commented

Same issue, still persists. Love the addon but this is annoying.

commented

Finally got around to figuring out a workaround; in BagBrother\addons\core\classes\item.lua, change line 149 to:

if not self.info.id == nil and Addon:IsReagents(self:GetBag()) and select(17, GetItemInfo(self.info.id)) then

Works fine for me in limited testing.

commented

The fix for this is in a new location now, BagBrother\frames\containers\item.lua line 24, same fix as in the previous post still seems to work. Would love to get this put into code so I don't have to change this manually after every update.