Bagnon

Bagnon

122M Downloads

Clean Items not combining stacks

RedDrumJay opened this issue ยท 9 comments

commented

Running Software (issues missing this information will be deleted):

  • Addon version: 10.1.4
  • Server patch: Build 3.4.2 50664

Have you read the changelog? (please don't waste our time)
Has not been updated since 10.1.2, but yes.

Describe the bug
Stacks are not consolidating on clean up. Flashing new items in bags continue to flash after mouseover and do not stop until closing and reopening bags.

To Reproduce
Steps to reproduce the behaviour:

  1. Open bags
  2. Click on clean items icon
  3. Cry

Expected behaviour
I expected the stacks to consolidate after cleanup, and for new items to stop flashing after mouseover.

Screenshots
If applicable, add screenshots to help explain your problem.

Error Logs
None

Additional context
N/A

image

commented

Stack option not working anymore. I cant eve see where is the option for it. I follow some of the tips here and its a no go.

commented

can confirm WOTLK, stacks not combinding items

commented

Quick fix
in BagBrother\core\api\sorting.lua
Change Line 119 to:
local name, _,_, level, _,_,_,stack,equip, _, _, class, subclass = GetItemInfo(id)
Change Line 123 to:
item.subclass, item.equip, item.level, item.stack = subclass, equip, level, stack

commented

Quick fix in BagBrother\core\api\sorting.lua Change Line 119 to: local name, _,_, level, _,_,_,stack,equip, _, _, class, subclass = GetItemInfo(id) Change Line 123 to: item.subclass, item.equip, item.level, item.stack = subclass, equip, level, stack

just created an account to say thank you, this had really been bothering me

commented

local name, ,, level, ,,_,stack,equip, _, _, class, subclass = GetItemInfo(id)

You mean

Line 118

From
local name, _,_, level, _,_,_,_, equip, _, _, class, subclass = GetItemInfo(id)

To
local name, _,_, level, _,_,_,stack,equip, _, _, class, subclass = GetItemInfo(id)

Line 122

From
item.subclass, item.equip, item.level = subclass, equip, level
To
item.subclass, item.equip, item.level, item.stack = subclass, equip, level, stack

commented

Thanks Skyler! That did it!

commented

I didn't get this error but a sort error and surprisingly this fix worked!

@wazerstar yes those were my line numbers too!

commented

This bug still persists in WoTLK.

commented

local name, ,, level, ,,_,stack,equip, _, _, class, subclass = GetItemInfo(id)

You mean

Line 118

From local name, _,_, level, _,_,_,_, equip, _, _, class, subclass = GetItemInfo(id)

To local name, _,_, level, _,_,_,stack,equip, _, _, class, subclass = GetItemInfo(id)

Line 122

From item.subclass, item.equip, item.level = subclass, equip, level To item.subclass, item.equip, item.level, item.stack = subclass, equip, level, stack

FYI - I have to keep making this 2-line edit every time I update this Addon - I bookmarked this page for quick access, but it's
very frustrating...