Cleanup not working
qlesz opened this issue ยท 8 comments
Is there an existing issue for this?
- I have searched the existing open and closed issues.
Description
Cleanup not working with newest classic release.
Bagnon Version
Bagnon 11.1.5
World of Warcraft Flavor
Classic Era
World of Warcraft Region
EU
Tested with only Bagnon
I got this issue with only Bagnon enabled
Lua Error
7x BagBrother/core/api/settings.lua:110: attempt to index local 'frame' (a string value)
[string "@BagBrother/core/api/settings.lua"]:110: in function `?'
[string "@BagBrother/libs/WildAddon-1.0-2/WildAddon-1.0.lua"]:20: in function <...dOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:18>
[string "@BagBrother/libs/WildAddon-1.0-2/WildAddon-1.0.lua"]:56: in function <...dOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:53>
[string "=[C]"]: ?
[string "@Atlas/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...las/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Atlas/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@BagBrother/libs/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua:119>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@Blizzard_UIParent/Vanilla/UIParent.lua"]:220: in function `UIParentLoadAddOn'
[string "@Blizzard_UIParent/Vanilla/UIParent.lua"]:291: in function `TimeManager_LoadUI'
[string "@Blizzard_UIParent/Vanilla/UIParent.lua"]:525: in function <Blizzard_UIParent/Vanilla/UIParent.lua:494>
Locals:
self = <table> {
Tag = "BAGNON_"
}
(for state) = <table> {
Nek'Rosh = <table> {
}
}
(for control) = "Nek'Rosh"
realm = "Nek'Rosh"
owners = <table> {
Donmighty = <table> {
}
}
(for state) = <table> {
Donmighty = <table> {
}
}
(for control) = "Donmighty"
id = "Donmighty"
profile = <table> {
inventory = <table> {
}
vault = <table> {
}
guild = <table> {
}
bank = <table> {
}
}
(for state) = <table> {
inventory = <table> {
}
vault = <table> {
}
guild = <table> {
}
bank = <table> {
}
}
(for control) = "inventory"
frame = "inventory"
sets = <table> {
rules = <table> {
}
point = "BOTTOMRIGHT"
hiddenBags = <table> {
}
color = <table> {
}
borderColor = <table> {
}
filters = <table> {
}
enabled = true
reverseBags = true
columns = 6
money = true
alpha = 1
bagBreak = false
x = -186.626053
lockedSlots = <table> {
}
brokerObject = "BagnonLauncher"
reverseSlots = false
scale = 0.960000
hiddenRules = <table> {
}
y = 104.938271
}
(*temporary) = "nil"
(*temporary) = nil
(*temporary) = "attempt to index local 'frame' (a string value)"
Addon = <table> {
IsRetail = false
SearchFrame = <table> {
}
Frames = <table> {
}
Currency = <table> {
}
Skins = <table> {
}
ItemGroup = <table> {
}
ContainerItemGroup = <table> {
}
CurrencyTracker = <table> {
}
Filter = <table> {
}
LastAccountBag = 10
Frame = <table> {
}
OptionsToggle = <table> {
}
Bag = <table> {
}
LastBankBag = 10
CurrencyTooltipCounts = <table> {
}
Base = <table> {
}
sets = <table> {
}
Name = "Bagnon"
None = <table> {
}
Parented = <table> {
}
Cacher = <table> {
}
NumBags = 4
Item = <table> {
}
IsClassic = true
BankBags = <table> {
}
OwnerSelector = <table> {
}
Sorting = <table> {
}
Commands = <table> {
}
SortButton = <table> {
}
ContainerItem = <table> {
}
BagGroup = <table> {
}
Events = <table> {
}
TooltipCounts = <table> {
}
Tag = "BAGNON_"
Inventory = <table> {
}
Rules = <table> {
}
ItemSlot = <table> {
}
SearchToggle = <table> {
}
Owners = <table> {
}
InventoryBags = <table> {
}
Title = <table> {
}
Slash = "bgn"
Settings = <table> {
}
BrokerCarrousel = <table> {
}
PlayerMoney = <table> {
}
Tipped = <table> {
}
AutoDisplay = <table> {
}
BagToggle = <table> {
}
LDB = <table> {
}
DropButton = <table> {
}
CurrencyLimit = 30
FilterGroup = <table> {
}
}
VAR = "Bagnon_Sets"
ProfileDefaults = <table> {
vault = <table> {
}
guild = <table> {
}
inventory = <table> {
}
__index = <table> {
}
bank = <table> {
}
}
Reproduction Steps
Click on "cleanup" button
Last Working Version
11.5.6
Screenshots
No response
ETA: The code I am referencing is actually in "BagBrother"
I am not an lua dev at all, let alone wow addons, but I discovered the following:
In core.lua KEYRING_CONTAINER=-2 and tinsert(Addon.InventoryBags, KEYRING_CONTAINER)
So that in sorting.lua local locked = self.target:GetBagInfo(bag).locked is failing on line 109
Adding an if check like if bag >= 0 then for everything inside the for loop that starts on line 108 seems to fix things
I have no idea about whether that is a correct or good approach, but wanted to share my research at the very least
