Bags not opening in SoD

Question

Bags not opening in SoD

thezephyrsong opened this issue 5 months ago · 23 comments

thezephyrsong commented 5 months ago

Is there an existing issue for this?

I have searched the existing open and closed issues.

Description

New 1.15.7 patch has broken bagnon

Bagnon Version

11.1.9

World of Warcraft Flavor

Classic Era

World of Warcraft Region

US/NA

Tested with only Bagnon

I got this issue with only Bagnon enabled

Lua Error

12x ...rfaceBagBrother/core/classes/playerMoney.lua:48: attempt to index global 'MoneyTypeInfo' (a nil value)
[BagBrother/core/classes/playerMoney.lua]:48: in function 'Construct'
[BagBrother/libs/Poncho-2.0-5/Poncho-2.0.lua]:81: in function <...aceBagBrother/libs/Poncho-2.0/Poncho-2.0.lua:75>
[tail call]: ?
[BagBrother/core/classes/parented.lua]:10: in function <BagBrother/core/classes/parented.lua:9>
[tail call]: ?
[BagBrother/core/classes/playerMoney.lua]:26: in function <...rfaceBagBrother/core/classes/playerMoney.lua:25>
[tail call]: ?
[BagBrother/core/classes/frameBase.lua]:125: in function 'GetWidget'
[Bagnon/src/frame.lua]:251: in function <Bagnon/src/frame.lua:248>
[tail call]: ?
[Bagnon/src/frame.lua]:54: in function 'Layout'
[BagBrother/core/classes/frameBase.lua]:58: in function 'Update'
...[BagBrother/frames/inventory/inventory.lua]:27: in function <...aceBagBrother/frames/inventory/inventory.lua:26>
[C]: in function 'Show'
[BagBrother/core/api/frames.lua]:32: in function 'Show'
[BagBrother/core/api/frames.lua]:24: in function <BagBrother/core/api/frames.lua:23>
[tail call]: ?
[tail call]: ?
[BagBrother/core/features/autoDisplay.lua]:83: in function <...faceBagBrother/core/features/autoDisplay.lua:82>
[C]: in function 'ToggleBackpack'
[Blizzard_MainMenuBarBagButtons/Classic/MainMenuBarBagButtons.lua]:54: in function 'BackpackButton_OnClick'
[*MainMenuBarBagButtons.xml:118_OnClick]:4: in function <[string "*MainMenuBarBagButtons.xml:118_OnClick"]:1>

Locals:
self = <table> {
 __super = <table> {
 }
 __base = <table> {
 }
 __index = <table> {
 }
 __name = "BagnonPlayerMoney"
 Type = "PLAYER"
 __frames = <table> {
 }
 __type = "Button"
 __count = 1
 __template = "SmallMoneyFrameTemplate"
 Gray = "|cff999999%s|r"
}
f = BagnonPlayerMoney1 {
 GoldButton = BagnonPlayerMoney1GoldButton {
 }
 vadjust = 0
 trialErrorButton = BagnonPlayerMoney1TrialErrorButton {
 }
 CopperButton = BagnonPlayerMoney1CopperButton {
 }
 moneyType = "PLAYER"
 moneyWidth = 126.370377
 info = <table> {
 }
 staticMoney = 10238892
 SilverButton = BagnonPlayerMoney1SilverButton {
 }
 small = 1
}
overlay = Button {
}
(*temporary) = nil
(*temporary) = "PLAYER"
(*temporary) = "anyUp"
(*temporary) = "attempt to index global 'MoneyTypeInfo' (a nil value)"
Money = <table> {
 __super = <table> {
 }
 __base = <table> {
 }
 __index = <table> {
 }
 __name = "BagnonPlayerMoney"
 Type = "PLAYER"
 __frames = <table> {
 }
 __type = "Button"
 __count = 1
 __template = "SmallMoneyFrameTemplate"
 Gray = "|cff999999%s|r"
}

Reproduction Steps

Try to open bag

Last Working Version

11.1.9

Screenshots

No response

ablib2 · Answer 1 · 2025-04-08T23:55:38.000Z

Same exact issue here. Worked fine at launch of patch, no longer works now.

There was a mini patch about an hour ago. Bagnon worked fine earlier today, but after this patch it broke.

PapaDunny · Answer 2 · 2025-04-08T23:42:44.000Z

Same exact issue here. Worked fine at launch of patch, no longer works now.

Schecten · Answer 3 · 2025-04-08T23:47:06.000Z

Also dropping in to say I'm seeing the same issue. Disabling the add-on I can open the base bags.

SleekSnake · Answer 4 · 2025-04-08T23:57:23.000Z

Asked the chat in a major city about this, everyone is having this problem with Bagnon at the moment. I guess as someone said above, that small patch must've broke it.

carrera987 · Answer 5 · 2025-04-09T02:58:00.000Z

came here to say it worked earlier today on classic, now doesn't but disabling money in option allows it to work - just doesn't show gold

Logandros · Answer 6 · 2025-04-09T02:18:30.000Z

Disabling "Money" here fixed this for me

Confirmed, thank you.

snowfan84 · Answer 7 · 2025-04-09T00:01:05.000Z

I have a simple fix that will allow you to use the addon. Not sure what else it will break, though. Use at your own risk.

Edit file \Bagbrother\core\classes\playerMoney.lua

change line 48
f.info = 0--MoneyTypeInfo[f.Type]

comment out line 61
--MoneyFrame_Update(self:GetName(), money, money == 0)

Good luck!

-Snow

ablib2 · Answer 8 · 2025-04-09T00:21:59.000Z

Thank you kind soul, this worked! Long shot, but could you work your magic on Auctioneer?

voidzone · Answer 9 · 2025-04-09T00:31:09.000Z

Same issue in Retail.

dartrunner1 · Answer 10 · 2025-04-09T00:37:40.000Z

@snowfan84 Thanks!

kahayes14 · Answer 11 · 2025-04-09T00:47:23.000Z

This issue also appears in Cata Classic

1Holy-Z · Answer 12 · 2025-04-09T00:54:42.000Z

It was working earlier today just fine on Retial. I just had a small game update this evening and now it doesn't work. Blizzard must have changed something

jwensley2 · Answer 13 · 2025-04-09T02:14:46.000Z

Disabling "Money" here fixed this for me

SleekSnake · Answer 14 · 2025-04-09T03:07:04.000Z

Disabling money does seem to work, for bags, but I can't seem to get bank to show still.

Logandros · Answer 15 · 2025-04-09T03:08:33.000Z

Disabling money does seem to work, for bags, but I can't seem to get bank to show still.

Need to disable money on all frames for the others to work 'bank' etc

SleekSnake · Answer 16 · 2025-04-09T03:51:25.000Z

Ah, duh. Thank you, Logandros.

Feronas · Answer 17 · 2025-04-09T08:45:28.000Z

Having the same issue on WoW SoD and Anni

Heregellas · Answer 18 · 2025-04-09T10:10:53.000Z

[Edit]: Seems fine while clearing SavedVariables too, then editing the line as in the fix

Feronas · Answer 19 · 2025-04-09T13:10:41.000Z

Switched to Baganator addon, problem solved.

moondaze · Answer 20 · 2025-04-09T15:54:24.000Z

Same issued. Also switched to Baganator temporarily till I hope Bagnon gets fixed. I much prefer Bagnon over Baganator!

esuvii · Answer 21 · 2025-04-09T17:38:09.000Z

I just realized that because we call MoneyTypeInfo further down a better fix to just fully rebuild the table at the top of the file. Realistically I am sure you don't need all of the types but I included them all just to be safe (probably we only needed PLAYER:

--- Remake MoneyTypeInfo data table
local function buildMoneyTypeInfo()
	local types = {
		"PLAYER",
		"ACCOUNT",
		"STATIC",
		"QUEST_REWARDS",
		"AUCTION",
		"AUCTION_TOOLTIP",
		"PLAYER_TRADE",
		"TARGET_TRADE",
		"SEND_MAIL",
		"SEND_MAIL_COD",
		"GUILDBANK",
		"GUILDBANKWITHDRAW",
		"GUILD_REPAIR",
		"TOOLTIP",
		"BLACKMARKET",
		"GUILDBANKCASHFLOW",
		"REFORGE"
	}
	local fields = {
		"OnloadFunc",
		"UpdateFunc",
		"PickupFunc",
		"DropFunc",
		"collapse",
		"canPickup",
		"showSmallerCoins",
		"checkGoldThreshold",
		"fixedWidth",
		"truncateSmallCoins",
		"align"
	}
	local moneyTypeTable = {}
	for _, type in ipairs(types) do
		if GetMoneyTypeInfoField(type, "collapse") then
			moneyTypeTable[type] = {}
			for _,field in ipairs(fields) do
				moneyTypeTable[type][field] = GetMoneyTypeInfoField(type, field) or nil
			end
		end
	end
	return moneyTypeTable
end
local MoneyTypeInfo = buildMoneyTypeInfo()

I reverted my previous change and just stuck this on line 11, just under MoneyFrame.Type = 'PLAYER'. This way the rest of the code should function as if MoneyTypeInfo was still directly accessible from the LUA template.

esuvii · Answer 22 · 2025-04-09T16:52:42.000Z

@Jaliborc I am sure you are aware but this seems to be due to large changes in the XML/LUA templates. Namely in the MoneyFrame.lua template file MoneyTypeInfo has been changed to a local variable, and instead a GetMoneyTypeInfoField(moneyType, field) method is provided to get each field individually, see: Interface/AddOns/Blizzard_MoneyFrame/Shared/MoneyFrame.lua

I wrote a quick fix for the Classic addon that preserves the full MoneyTypeInfo functionality, I expect it works the same for Retail. In function MoneyFrame:Construct() in Bagbrother/addons/core/classes/money.lua I changed:

f.info = MoneyTypeInfo[f.Type]

And instead replaced it with:

local moneyTypeInfoTable = {}
local moneyTypeInfoFields = {
	"OnloadFunc",
	"UpdateFunc",
	"PickupFunc",
	"DropFunc",
	"collapse",
	"canPickup",
	"showSmallerCoins",
	"checkGoldThreshold",
	"fixedWidth",
	"truncateSmallCoins",
	"align"
}
for _,field in ipairs(moneyTypeInfoFields) do
	local info = GetMoneyTypeInfoField(f.Type, moneyTypeInfoFields) or nil
	if info then
		moneyTypeInfoTable[field] = info
	end
end
f.info = moneyTypeInfoTable

Essentially I just build the table again field by field. There is probably a cleaner way to do this but it works for now!

Logandros · Answer 23 · 2025-04-09T21:05:18.000Z

I just realized that because we call MoneyTypeInfo further down a better fix to just fully rebuild the table at the top of the file. Realistically I am sure you don't need all of the types but I included them all just to be safe (probably we only needed PLAYER:
--- Remake MoneyTypeInfo data table
local function buildMoneyTypeInfo()
	local types = {
		"PLAYER",
		"ACCOUNT",
		"STATIC",
		"QUEST_REWARDS",
		"AUCTION",
		"AUCTION_TOOLTIP",
		"PLAYER_TRADE",
		"TARGET_TRADE",
		"SEND_MAIL",
		"SEND_MAIL_COD",
		"GUILDBANK",
		"GUILDBANKWITHDRAW",
		"GUILD_REPAIR",
		"TOOLTIP",
		"BLACKMARKET",
		"GUILDBANKCASHFLOW",
		"REFORGE"
	}
	local fields = {
		"OnloadFunc",
		"UpdateFunc",
		"PickupFunc",
		"DropFunc",
		"collapse",
		"canPickup",
		"showSmallerCoins",
		"checkGoldThreshold",
		"fixedWidth",
		"truncateSmallCoins",
		"align"
	}
	local moneyTypeTable = {}
	for _, type in ipairs(types) do
		if GetMoneyTypeInfoField(type, "collapse") then
			moneyTypeTable[type] = {}
			for _,field in ipairs(fields) do
				moneyTypeTable[type][field] = GetMoneyTypeInfoField(type, field) or nil
			end
		end
	end
	return moneyTypeTable
end
local MoneyTypeInfo = buildMoneyTypeInfo()
I reverted my previous change and just stuck this on line 11, just under MoneyFrame.Type = 'PLAYER'. This way the rest of the code should function as if MoneyTypeInfo was still directly accessible from the LUA template.

This would work for Classic but incomplete for Retail, it would just duplicate player money in the Warband bank (fyi)

Share to