
Short freezes when looting
Closed this issue ยท 16 comments
Is there an existing issue for this?
- I have searched the existing open and closed issues.
Description
Since the newest update (that fixed the close button issue) I'm sometimes experiencing short game freezes when looting or, wierdly enough, when the toast window pops up. It doesn't happen when Bagnon isn't loaded, so it seems to be the culprit (or some interaction with something else). Another guildie using the addon is reporting the same problem. As it's not happening every single time, at least for me, it might be a bit hard to troubleshoot though.
Edit: It might be connected to currencies as it seems to trigger every time when there's something like that, as opposed to items
Bagnon Version
Bagnon 11.2.8
World of Warcraft Flavor
Retail
World of Warcraft Region
EU
Tested with only Bagnon
I got this issue with only Bagnon enabled
Lua Error
Reproduction Steps
- Loot items from killed mobs and it will occationally happen
- ...or complete an objective to get the toast window to pop
Last Working Version
Bagnon 11.2.7
Screenshots
No response
This is also happening to me, only when bagnon is enabled. Happens randomly when looting but every time when opening a chest.
I too am seeing this. I also see it in bagnonium as well. This just started happening right after the update. I installed the previous version but it still seems to happen.
The same problems for me... Also happens while looting the chests in delves. I'm playing on retail.
Commenting out lines 33 to 35 in BagBrother/core/features/uiOverrides.lua fixes this (the ones with BackpackTokenFrame:SetWidth)
Commenting out lines 33 to 35 in BagBrother/core/features/uiOverrides.lua fixes this (the ones with BackpackTokenFrame:SetWidth)
Thanks, commenting out lines 33โ35 works perfectly!
Before this update I would get microfreezes when collecting currencies. The time rifts in Valdrakken (where you get Soridormi rep and currency after each kill) were pretty painful. Also, after every dragon flying race I would get a much longer freeze (a couple seconds usually).
After the update I no longer get those race freezes, however I just got some free weathered crests from the renown quartermaster in Dornogal and I got the same several second freeze that I used to get after races.
Loot doesn't seem to affect me like you guys...this only seems to happen when I get currencies. I know it's bagnon doing it as well because disabling it completely removes this problem.
Same freezes for 2 sec after every dragon flying race - all time from 11.0
Last update added 2 sec freeze when I open bags inventory first time after login on every character.
Commenting out lines 33 to 35 helps but ugly default bags start showing on the background.
Have no issues if Bagnon off but I can't look at standard bags without tears :)
Update: install previous version - no freeze with open bags - Yay!
Now need to find a solution with freezing after every dragon flying race.
Commenting out lines 33 to 35 in BagBrother/core/features/uiOverrides.lua fixes this (the ones with BackpackTokenFrame:SetWidth)
I'm unable to replicate the freezing.
Could more people please confirm or deny whether commenting out those specific lines solves the issue? It would help me diagnose the problem.
Like the original comment if it fixes it for you, dislike if it doesn't.
https://www.twitch.tv/mementh/clip/ShyPrettyCroquetteKappaRoss-s_VLEvKxdubiTGAM is it in action
https://www.twitch.tv/mementh/clip/DarlingPerfectBeeWholeWheat-Y6FD-tTC0hUIUnez with commented out.
so somethings misbehaving :)
Commenting out lines 33 to 35 in BagBrother/core/features/uiOverrides.lua fixes this (the ones with BackpackTokenFrame:SetWidth)
I'm unable to replicate the freezing.
Could more people please confirm or deny whether commenting out those specific lines solves the issue? It would help me diagnose the problem. Like the original comment if it fixes it for you, dislike if it doesn't.
Those specific lines affect BackpackTokenFrameMixin:GetMaxTokensWatched()
from Blizzard_TokenUI
which in turn makes BackpackTokenFrameMixin:Update()
slow on CURRENCY_DISPLAY_UPDATE
event (the "slow" code is in default ui, not in bagnon own code)
If I understand Bagnon code correctly, Addon.CurrencyLimit
exists to limit the amount of tracked checked every time (and its value is 30) while changing width of that frame makes GetMaxTokensWatched() return 1999 for me
Commenting out lines 33 to 35 in BagBrother/core/features/uiOverrides.lua fixes this (the ones with BackpackTokenFrame:SetWidth)
I'm unable to replicate the freezing.
Could more people please confirm or deny whether commenting out those specific lines solves the issue? It would help me diagnose the problem. Like the original comment if it fixes it for you, dislike if it doesn't.Those specific lines affect
BackpackTokenFrameMixin:GetMaxTokensWatched()
fromBlizzard_TokenUI
which in turn makesBackpackTokenFrameMixin:Update()
slow onCURRENCY_DISPLAY_UPDATE
event (the "slow" code is in default ui, not in bagnon own code)If I understand Bagnon code correctly,
Addon.CurrencyLimit
exists to limit the amount of tracked checked every time (and its value is 30) while changing width of that frame makes GetMaxTokensWatched() return 1999 for me
yes, that is my belief as well. just wanted to make sure it worked for everyone before releasing an "official fix" that might or not work