Bagnon

Bagnon

122M Downloads

Automatic Display poorly named

AdeLP opened this issue ยท 6 comments

commented

Whether you check the Automatic display -> "Display inventory when visiting a vendor" option or not, your inventory automatically opens when viewing a vendor.

If you check the "Display inventory when visiting a vendor" option, then when you close the vendor your bags also auto close, if you don't check this option then bagnon acts like the WOW default (ie: your bags don't auto close when you close the vendor window).

Perhaps the option should be named "Automatically close inventory when closing a vendor window"?

Also, this as far as I can tell is the default behavior (which is in opposition to WOW's default), can bagnon's default be inverted to be more like WOW?

commented

The option is also valid for the bank/keyring, isn't it?

commented

There are multiple options. The "Display inventory when visiting a vendor" ONLY controls whether the bagnon inventory automatically closes when you close a vendor window (checked or not bagnon opens when you visit a vendor). Hence the option is misleading, it does not represent what it actually does.

As for the auction house, bank, trading items, guild bank, crafting and when opening the player frame windows I've not checked to see if the textual option makes sense given their actual purpose or not.

commented

I was asking, "are the auto show/hide options available to the other bagnon frames (keyring, bank, etc)". I had forgotten that I did not make them available in Bagnon 2 as I did in Bagnon 1.

Anyway, how does, "Automatically close inventory when leaving a vendor" sound?

commented

"Automatically close inventory when leaving a vendor" sounds great, and describes accurately what the feature actually does :)

and yes those other options are present.

commented

Change committed: will be implemented the next time I push out an update.
https://github.com/Tuller/Bagnon_Config/commit/6e8b3dc739415cbdfdea3c32c297b1a1d7136359

commented

Thank you :)