Bagnon

Bagnon

122M Downloads

Some bugs

mundi4 opened this issue · 5 comments

commented

bagnon search frame(Korean client)

In Korean client, User may enter one or more keys input to complete single letter.

'ㄱ' + 'ㅏ' => '가' (2 inputs)
'가' + 'ㅏ' + 'ㅇ' => '강' (3 inputs)

But each time I type in search frame, it calls text:SetText(...) so I can't complete the letter I was typing. When I enter text '가나다'(3 letters), it becomes 'ㄱㅏㄴㅏㄷㅏ'(6 letters).

I think this should fix:

if ( text:GetText() ~= searchText ) then
    text:SetText(searchText)
end

BagBrother doesn't work when realm name contains spaces.

  1. GetRealmName() returns '불타는 군단'(one space)
  2. GetAutoCompleteRealms() returns '불타는군단'(no space)

Combuctor - trade bag

Trade bag should be closed and open again to update items.

Sorry for my poor English

commented

Regarding the second issue, for realm name matching purposes, GetRealmName() should not be used; the second return value from UnitFullName("player") should be used instead, since it already has spaces removed and any other changes made to match the values seen in other places in the game (chat message event args, GetAutoCompleteRealms(), etc.).

commented

Ah, dam. So much work I had going around the spaces, and that was a much better solution.
Dam it

commented

Damn*

... unless you're actually trying to block a river, that is. 😛

commented

Block a river of bug reports, maybe!

commented

Ofc I want to block a river!