Bagnon

Bagnon

122M Downloads

missing argument from functions in sets.lua

Seerah opened this issue ยท 3 comments

commented

In Combuctor_Sets\sets.lua, several functions (isUsable and isTradeGood) rely on the item's subType for sorting. However, this arg is not being passed through to the function.

ex.
local function isUsable(player, bagType, name, link, quality, level, ilvl, type)
needs to be
local function isUsable(player, bagType, name, link, quality, level, ilvl, type, subType)

commented

And you have two setRule functions named isTradeGood - the second overwrites the first, and you end up with Devices and Explosives on the Trade Goods tab.

commented

Good catch. Wrong repo though.

commented

I did notice that it this was the Bagnon repo and was slightly confused. You should probably change the link on the download page if this is not where you want tickets to go. ;) Thought maybe because they shared the same code-base (at least at one time?) that the tickets were kept together. /shrug