Errors when closing bags with Esc key
Phanx opened this issue ยท 2 comments
Steps to reproduce the bug with 100% reliability:
- Open the bag frame
- Select another character with more total bag slots than the current character
- Close the bag frame by pressing Escape
- Open the bag frame again
- Error overload
30x Bagnon\common\core\classes.lua:44: attempt to index a nil value
Bagnon\common\core\classes.lua:44: in function 'GetPlayer'
...nterface\Bagnon\common\components\item.lua:446: in function 'GetInfo'
...nterface\Bagnon\common\components\item.lua:266: in function 'IsLocked'
...nterface\Bagnon\common\components\item.lua:258: in function 'UpdateLocked'
...nterface\Bagnon\common\components\item.lua:374: in function 'UpdateSearch'
...nterface\Bagnon\common\components\item.lua:227: in function 'DelayedUpdates'
...nterface\Bagnon\common\components\item.lua:223: in function <...nterface\Bagnon\common\components\item.lua:223>
I implemented the following workaround in one of my feature branches, but in case you decide not to accept the eventual pull request, you can see the workaround here:
https://github.com/Phanx/Wildpants/commit/6d259c987d7e546840f2d99160af796d21b1bedf
There's almost certainly a more "correct" solution to the problem, but I didn't look any further than this.
I'm also not sure whether the root of the problem is in Bagnon or Wildpants, but since it's currently triggered by code in Bagnon I'm posting it here.
I'm getting this error every time I close the bag, regardless of the method (pressing 'B', Escape, or clicking the 'X'). I do not have Wildpants installed.
146x Bagnon_AccountSearch\Bagnon_AccountSearch-v1.7.0.lua:187: attempt to index field 'FrameSettings' (a nil value)
Bagnon_AccountSearch\Bagnon_AccountSearch-v1.7.0.lua:187: in function `GetBagnonVariableLinks'
Bagnon_AccountSearch\Bagnon_AccountSearch-v1.7.0.lua:207: in function `UpdateVisibility'
Bagnon_AccountSearch\Bagnon_AccountSearch-v1.7.0.lua:60: in function `OnHide'
Bagnon\components\inventory.lua:17: in function <Bagnon\components\inventory.lua:16>
[C]: in function `Hide'
FrameXML\UIParent.lua:2786: in function <FrameXML\UIParent.lua:2781>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-60.lua:1795: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1794>
[C]: in function `securecall'
FrameXML\UIParent.lua:2824: in function `CloseWindows'
FrameXML\UIParent.lua:2852: in function <FrameXML\UIParent.lua:2842>
[C]: in function `securecall'
FrameXML\UIParent.lua:3532: in function `ToggleGameMenu'
[string "TOGGLEGAMEMENU"]:1: in function <[string "TOGGLEGAMEMENU"]:1>
Locals:
self = BagnonAccountSearchFrame {
UpdateVisibility = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:206
SetFrameLayer = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:164
GuildBankToggle = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:100
BagSearch_OnUpdate = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:146
minFrameSearchStringLength = 2
ShowSearch = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:684
GetBagnonVariableLinks = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:184
New = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:498
AccountSearch_Toggle = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:120
CreateItemSlot = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:616
IsBankSlot = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:156
items = <table> {
}
0 = <userdata>
AttachToggle = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:112
Print = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:699
UpdateItems = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:302
AddItemName = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:257
Resize = <function> defined @Bagnon_AccountSearch\Bagnon_AccountSearch.lua:243
}Edit: https://github.com/Phanx/Wildpants/commit/6d259c987d7e546840f2d99160af796d21b1bedf did not solve the issue for me. My issue may not be related, as it is triggered in the Bagnon_AccountSearch module.