Bagnon

Bagnon

122M Downloads

Total sum of items for all chars on server

JoeInch opened this issue · 4 comments

commented

I was looking if I could add a line for the total number of items on all chars in the tooltip. This seemed to be easy for the actual char, but I was not able to extract the desired information for the remaining chars.
Question: Can a total line be added for all chars?

On my research I found that you obviously intended to display also equipped items. I didn't remember that I had seen any equipped item ever. I believe I found the problem. I think, you are searching for 'e' in the index, but the equipment items are stored as 'ex' or 'exx', where x/xx is the slot number.

commented

Fixed on development version

commented

Hola João,
many thanks for looking into this.

Had you seen my second post about the display of equipped items?
As I wrote, I have solved that by duplicating the function and putting GetBagSize in Version 2.
Version 2 works perfect for equipped items, and the original for bags. But not vice versa.
I'll buy me a book for LUA programming .... but these side effects seem very strange to me.
Many thanks
Hasta luego
Reinhard

-----Ursprüngliche Nachricht-----
Von: João Libório Cardoso [mailto:[email protected]]
Gesendet: Dienstag, 1. November 2011 17:27
An: Griedelbach, Reinhard
Betreff: Re: [Bagnon] Total sum of items for all chars on server (#45)

Fixed on development version

Reply to this email directly or view it on GitHub:
#45 (comment)
Dell GmbH, Geschäftsanschrift/business address: Unterschweinstiege 10, 60549 Frankfurt am Main, Germany
Geschäftsführer: Mark Möbius, Barbara Wittmann, Jürgen Wilhelm Renz
Sitz: Frankfurt am Main, eingetragen beim Amtsgericht Frankfurt am Main unter HRB 75453
USt.-ID: DE113541138, WEEE-Reg.Nr.: DE 49515708

commented

It doesn't really matters, as the Bagnon_Forever and Bagnon_Tooltips have been completely replaced.

commented

I have investigated a little further and found a possible solution in db.lua line 316. It should read instead: local size = GetBagSize(bag) or 0 that change causes a) equipped items appear in the list b) a side effect which does not show the items for some chars anymore.
I believe the function GetItemCount is called from different places and the two different versions are needed for the different calls. My hope is, that you can point out the error right away since I am not that good in programming LUA.
My first assumption with the 'e' bag type could not be confirmed.
Many thanks
Joe