Bagnon

Bagnon

124M Downloads

702 BB & compare frame bugs

Voxxel opened this issue · 11 comments

commented

Using the latest 7.0.2. from curseforge I experience a bug when the addon doesn't sort the comparing frames in the reverse direction when it clamps to the right edge of the screen - see the attached sceenshot.

There's another bug on the screenshot with BagBrother but I think that's reported already.

wowscrnshot_072016_130130

commented

Looking at this

commented

having the same problem with it doing that

commented

was looking for this 🎯

commented

Hey Jailborc, thanks for your work,. so I solved,... in Item.lua --[[ Tooltip ]]-- you put " >= " and thats why overlaps when the bag is on right site,... changed to " <= " Now works just perfect hehe Thanks again for this amazing addon man.

commented

Hangkiw, this doesn't change anything for me. Are you saying to change the line 419 in
Bagnon/common/components/item.lua in version 7.0.3

from
if self:GetRight() >= (GetScreenWidth() / 2) then
to
if self:GetRight() <= (GetScreenWidth() / 2) then

Doesn't work for me. Same overlapping as before, even if I enable only the main "Bagnon" component and deleted the .lua from WTF.

commented

Yes Voxxel, MY BAD sorry,.. I was excited about making it work, so i forgot that before i deleted the "else case" not need to have an else case because he call that sentence before with <=,... anyhow just set it:

function ItemSlot:AnchorTooltip()
    if self:GetRight() <= (GetScreenWidth() / 2) then
        GameTooltip:SetOwner(self, 'ANCHOR_LEFT')
        end
end
commented

This way it works! Thank you. Works different than in past Bagnon / default UI, it anchors item tooltips to the left side while the base tooltip reaches the middle of the screen and anchors to the right when in the left side of the screen.

But it's working, nonetheless, no overlapping, so great job, thanks for the fix!

commented

I'm aware of this bug and will fix it ASAP. Unfortunately this week I'm in a conference in Anaheim, so it is almost impossible to come online.

Sorry for the delay. Please be patient.

commented

@Hangkiw I read your fix but it did nothing for me, compare frames are still overlapping sadly. Lets wait for the promised fix, this is the only bag addon I use.

commented

I'am sorry Jailborc i just tried to help a little with this issue while you give us a new update, but ppl just keep posting the same bugs without read the list. Thanks for this great addon tho'.

commented

@Othra hi, did you put the text exactly like i posted? because sometime if you change uppercaps or give extra tabs not work. HERE IS the item.lua that i use if you like to try it meanwhile.