Bagnon

Bagnon

124M Downloads

Bagnon\external\Wildpants\localization\ru.lua

Drui7 opened this issue · 3 comments

commented

Variables for localization are not valid, localization does not work.

How does it look in English:
--item tooltips
L.TipCountEquip = 'Equipped: %d'
L.TipCountBags = 'Bags: %d'
L.TipCountBank = 'Bank: %d'
L.TipCountVault = 'Vault: %d'
L.TipCountGuild = 'Guild: %d'
L.TipDelimiter = '|'

It looked wrong in Russian, so English words were included by default. That's right (I made myself and everything works):

L.TipCountEquip = 'Надето: %d'
L.TipCountBags = 'Сумки: %d'
L.TipCountBank = 'Банк: %d'
L.TipCountVault = 'Бездна: %d'
L.TipCountGuild = 'Гильдия: %d'
L.TipDelimiter = '|'

So it was, it does NOT work:
--itemcount tooltips
L.TipCount1 = 'Надето: %d'
L.TipCount2 = 'Сумки: %d'
L.TipCount3 = 'Банк: %d'
L.TipCount4 = 'Бездна: %d'
L.TipDelimiter = '|'

commented

And I also advise you to use variables that warcraft itself gives for localization.
BACKPACK_TOOLTIP -- localized word "backpack"
CURRENTLY_EQUIPPED
BANK
VOID_STORAGE
GUILD_BANK

Almost always you do not need to reinvent the wheel. The developers of warcraft created a lot of variables for localization.

How it would look in one file instead of many:
--item tooltips
L.TipCountEquip = CURRENTLY_EQUIPPED..': %d'
L.TipCountBags = BACKPACK_TOOLTIP..': %d'
L.TipCountBank = BANK..': %d'
L.TipCountVault = VOID_STORAGE..': %d'
L.TipCountGuild = GUILD_BANK..': %d'
L.TipDelimiter = '|'

commented

I get this when I check other chars their bags, sometimes it takes one time to check another char sometimes two but it always happens.

Message: ...AddOns\Bagnon\external\Wildpants\components\item.lua:267: attempt to compare number with string
Time: Tue Dec 18 09:35:59 2018
Count: 1
Stack: ...AddOns\Bagnon\external\Wildpants\components\item.lua:267: attempt to compare number with string
...ce\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:613: in function <...ce\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:575>
[C]: ?
...AddOns\Bagnon\external\Wildpants\components\item.lua:267: in function UpdateBorder' ...AddOns\Bagnon\external\Wildpants\components\item.lua:228: in function <...AddOns\Bagnon\external\Wildpants\components\item.lua:222> [C]: in function Update'
...AddOns\Bagnon\external\Wildpants\components\item.lua:124: in function <...AddOns\Bagnon\external\Wildpants\components\item.lua:119>
[C]: in function Show' ...AddOns\Bagnon\external\Wildpants\components\item.lua:30: in function New'
...s\Bagnon\external\Wildpants\components\itemFrame.lua:119: in function <...s\Bagnon\external\Wildpants\components\itemFrame.lua:108>

Locals: errMsg = "...AddOns\Bagnon\external\Wildpants\components\item.lua:267: attempt to compare number with string"
errorTime = 2251436.474500
tsmErrMsg = nil
oldModule = nil
private =

{
AddonBlockedEvent = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:378
num = 0
ErrorHandler = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:106
origErrorHandler = defined @interface\SharedXML\SharedBasicControls.lua:295
errorReports =
{
}
IsTSMAddon = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:355
SantizeErrorReportString = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:386
errorFrame = {
}
}
MAX_STACK_DEPTH = 50
TSM =
{
}

commented

Using warcraft variables in composite phrases isn't guaranteed to work on all locales.
Thank you for the locale updates