Bagnon

Bagnon

122M Downloads

8.1.5 Error

HDMOVIESOURCE opened this issue ยท 20 comments

commented

New bug due to the 8.1.5 patch.

45x ...s\Bagnon\external\Wildpants\features\autoDisplay.lua:187: hooksecurefunc(): BagSlotButton_UpdateChecked is not a function
[C]: in function hooksecurefunc' ...s\Bagnon\external\Wildpants\features\autoDisplay.lua:187: in function HookInterfaceEvents'
...s\Bagnon\external\Wildpants\features\autoDisplay.lua:14: in function <...s\Bagnon\external\Wildpants\features\autoDisplay.lua:12>
[C]: ?
...ns\AzeriteTooltip\libs\AceAddon-3.0\AceAddon-3.0-12.lua:70: in function <...ns\AzeriteTooltip\libs\AceAddon-3.0\AceAddon-3.0.lua:65>
...ns\AzeriteTooltip\libs\AceAddon-3.0\AceAddon-3.0-12.lua:527: in function EnableAddon' ...ns\AzeriteTooltip\libs\AceAddon-3.0\AceAddon-3.0-12.lua:540: in function EnableAddon'
...ns\AzeriteTooltip\libs\AceAddon-3.0\AceAddon-3.0-12.lua:620: in function <...ns\AzeriteTooltip\libs\AceAddon-3.0\AceAddon-3.0.lua:605>
[C]: in function LoadAddOn' FrameXML\UIParent.lua:446: in function UIParentLoadAddOn'
FrameXML\UIParent.lua:565: in function `TimeManager_LoadUI'
FrameXML\UIParent.lua:1192: in function <FrameXML\UIParent.lua:1090>
[C]: ?

commented

What editor are you using to get line counts?

commented

@seascape195 IntelluaTE 0.5

commented

I went ahead and created a PR for this:
Jaliborc/Wildpants#23

commented

### It works...

\.._retail_\Interface\AddOns\Bagnon\external\Wildpants\components*Inventory.lau*
Inventory lua (fix)
--and--

\.._retail_\Interface\AddOns\Bagnon\external\Wildpants\features*autoDisplay.lau*
autoDisplay (fix)

commented

wow, thanks a lot for that @seascape195 !

commented

wow, thanks a lot for that @seascape195 !

Other's above helped too.. I just visualized it for everyone :)

commented

@seascape195 Blizzard changed the Bag Items to another new widget type so SetChecked does not exist.

BUT the Blizzard code changed the way the highlight texture is handled, so you could change the "CheckBagButtons" function to:

function Frame:CheckBagButtons(checked)
	MainMenuBarBackpackButton.SlotHighlightTexture:SetShown(checked)
	CharacterBag0Slot.SlotHighlightTexture:SetShown(checked)
	CharacterBag1Slot.SlotHighlightTexture:SetShown(checked)
	CharacterBag2Slot.SlotHighlightTexture:SetShown(checked)
	CharacterBag3Slot.SlotHighlightTexture:SetShown(checked)
end

But I did this and honestly I can't tell the difference...

commented

Error started today after Blizzard's patch

ID: 1
Error occured in: Global
Count: 1
Message: ...s\Bagnon\external\Wildpants\features\autoDisplay.lua line 187:
hooksecurefunc(): BagSlotButton_UpdateChecked is not a function
Debug:
[C]: hooksecurefunc()
...s\Bagnon\external\Wildpants\features\autoDisplay.lua:187: HookInterfaceEvents()
...s\Bagnon\external\Wildpants\features\autoDisplay.lua:14:
...s\Bagnon\external\Wildpants\features\autoDisplay.lua:12
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9:
[string "safecall Dispatcher[1]"]:5
(tail call): ?
...xternal\Wildpants\libs\AceAddon-3.0\AceAddon-3.0.lua:558: EnableAddon()
...xternal\Wildpants\libs\AceAddon-3.0\AceAddon-3.0.lua:571: EnableAddon()
...xternal\Wildpants\libs\AceAddon-3.0\AceAddon-3.0.lua:651:
...xternal\Wildpants\libs\AceAddon-3.0\AceAddon-3.0.lua:636
[C]: LoadAddOn()
..\FrameXML\UIParent.lua:446: UIParentLoadAddOn()
..\FrameXML\UIParent.lua:489: CombatLog_LoadUI()
..\FrameXML\UIParent.lua:1194:
..\FrameXML\UIParent.lua:1090
Locals:
None
(ck=2fd)

commented

I can still open and see contents but am getting the following error (looks similar to the OP):
2x ...s\Bagnon\external\Wildpants\features\autoDisplay.lua:187: hooksecurefunc(): BagSlotButton_UpdateChecked is not a function
[C]: in function hooksecurefunc' ...s\Bagnon\external\Wildpants\features\autoDisplay.lua:187: in function HookInterfaceEvents'
...s\Bagnon\external\Wildpants\features\autoDisplay.lua:14: in function <...s\Bagnon\external\Wildpants\features\autoDisplay.lua:12>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?

commented

Well While they fix it,...
I mean I can't live without this addon so....

In: \Interface\AddOns\Bagnon\external\Wildpants\components\inventory.lua
I deleted all the funtions in down line from 10

In: \Interface\AddOns\Bagnon\external\Wildpants\features\autoDisplay.lua
I deleted all the down lines from 180 (-- checked state) and add an "end" in 179

Done... I been playing like always and not more Lua Errors,...

commented

@seascape195 re: AutoDisplay.lua - you also need to delete anything else past what you highlighted save the final 'End' statement.

I had both HookSecureFunc and HookInterfaceEvents lines left after pass 1, and they continued to cause an error until removed.

1x ...s\Bagnon\external\Wildpants\features\autoDisplay.lua:180: Usage: hooksecurefunc([table,] "function", hookfunc)
[C]: in function hooksecurefunc' ...s\Bagnon\external\Wildpants\features\autoDisplay.lua:180: in function HookInterfaceEvents'
...s\Bagnon\external\Wildpants\features\autoDisplay.lua:14: in function <...s\Bagnon\external\Wildpants\features\autoDisplay.lua:12>

commented

I went ahead and created a PR for this:
tullamods/Wildpants#23

Thanks I patched my Bagon 8.1.6 with your Pull Request and it fixed my Guild Bank Tab being messed up.

commented

I went ahead and created a PR for this:
tullamods/Wildpants#23

Works great for me!

commented

@seascape195 re: AutoDisplay.lua - you also need to delete anything else past what you highlighted save the final 'End' statement.

I had both HookSecureFunc and HookInterfaceEvents lines left after pass 1, and they continued to cause an error until removed.

1x ...s\Bagnon\external\Wildpants\features\autoDisplay.lua:180: Usage: hooksecurefunc([table,] "function", hookfunc)
[C]: in function hooksecurefunc' ...s\Bagnon\external\Wildpants\features\autoDisplay.lua:180: in function HookInterfaceEvents'
...s\Bagnon\external\Wildpants\features\autoDisplay.lua:14: in function <...s\Bagnon\external\Wildpants\features\autoDisplay.lua:12>

Interesting, my copy didn't have any more code after that..

commented
commented

Can someone give steps how to d/l and merge these files into my addon? I'm by no means a IT novice, but unfamiliar w/ GitHub and only basic knowledge of editing addons

You need to identify your "interface" - it usually resides in your "World of Warcraft" Program directory, as a subdirectory of "retail" - there are all AddOns.
May your path to Bagnon is
C:\Programs (x86)\World of Warcraft_retail_\Interface\AddOns\Bagnon

The relevant changes need to be manually done in the subseding subdirectories, you need to edit the related files. For example, the tullamods/Wildpants#23 changes reside in external/Wildpants directory, the files to be changed are mentioned in "Files changed" - you need to identify the lines (e.g. using an editor like Notepad++ as I use, that shows the line numbers) - red liens are to be removed, green lines are to be added, white lines are to identify unchanged lines nearby.

So there is no "files to download and place" at this stage, morely there are "lines to be changed in existing textfiles" (.lua files are plain text files)

Hope this little description can aid you to success - conside making a copy befor change helps restoring if anything goes wrong.

commented

Can someone give steps how to d/l and merge these files into my addon? I'm by no means a IT novice, but unfamiliar w/ GitHub and only basic knowledge of editing addons

You need to identify your "interface" - it usually resides in your "World of Warcraft" Program directory, as a subdirectory of "retail" - there are all AddOns.
May your path to Bagnon is
C:\Programs (x86)\World of Warcraft_retail_\Interface\AddOns\Bagnon

The relevant changes need to be manually done in the subseding subdirectories, you need to edit the related files. For example, the tullamods/Wildpants#23 changes reside in external/Wildpants directory, the files to be changed are mentioned in "Files changed" - you need to identify the lines (e.g. using an editor like Notepad++ as I use, that shows the line numbers) - red liens are to be removed, green lines are to be added, white lines are to identify unchanged lines nearby.

So there is no "files to download and place" at this stage, morely there are "lines to be changed in existing textfiles" (.lua files are plain text files)

Hope this little description can aid you to success - conside making a copy befor change helps restoring if anything goes wrong.

@wienfuchs or @konomikitten Is there a trick to making WoW pickup these manual changes?

Even though I commented out line 187 in the ...s\Bagnon\external\Wildpants\features\autoDisplay.lua file I am still getting an error when logging into WoW. I even closed out the battle.net app and reopened it.

commented

Nevermind I figured it out...didn't realize there was a cached version in the retail folder. Learned something about WoW today! ๐Ÿ˜„

commented

inventory.zip
autoDisplay.zip

Assuming this attachment works.. here's replacement copies of:

  • Inventory.lua
  • autoDisplay.lua

Which are located in different sub-folders of your WoW installed game.

E.g. Folder Locations to put these files (AFTER you've backed up the existing current ones you have there already):
DriveLetter:\ [World of Warcraft] \ retail\Interface\AddOns\Bagnon\external\Wildpants\ components\ Inventory.lua

DriveLetter:\ [World of Warcraft] \ retail\Interface\AddOns\Bagnon\external\Wildpants\ features\ autoDisplay.lua

This DID fix mine and several other's issue (bandaid style) for now, but no guaranty it fixes everyones.. as you may have additional add-ons interacting within these too and mine did not -- which is also why I recommend backup existing copy of these two files first. THEN overwrite with these (assuming they did upload and attach to this post -- sorry if they did not)

commented

I don't know if this will help get to the root of the problem, but I did find this. They have removed the function BagSlotButton_UpdateChecked entirely. I am not an expert on coding, but I cannot seem to see an easy substitute/replacement.

https://www.townlong-yak.com/framexml/ptr/MainMenuBarBagButtons.lua/diff