Error at showing total currencys in a shop
rubenjurado opened this issue · 24 comments
When i put my mouse over a currency in a shop, it shows me how many i have, thats fine, but when showing me total currencys from all my characters, instead of using the currency i have my mouse on, its showing me the total currencys from the first item in the shop.
As showing in the capture (Sorry, image is in Spanish) you can see it says:
Total: 96
And a bit down it says i have 18,459 in my char, which its not true, i have 18,450 from the first currency in the shop, but not from the one i am looking at.
Had to compress BagSync.lua since i couldn't attach .lua files here.
I Disabled all addons except BagSync and put the game in english.
In the new 2 captures i attached its a bit more clearly to see, it says i have 1000 Soul Cinders (Which is accurate), but down in the tooltip shows me Soul Ash instead of Soul Cinders, and in the second capture Shows me Soul Cinders instead of Stygian Ember.
Sorry my english is a bit bad
Hope this helps :D
It looks like it's grabbing the previous currency instead of the current one. I'm going to attach a special BagSync here. I need you to use this one and enable a new Debug option in the settings.
Please enable "Display ItemID in tooltip" and "Display Source, ID and Debug Info in tooltip."
Then hover over an item. It should display in the tooltip the CurrencyID and the Debug Source. I'm going to review your BagSync data right now but I need you to show me snapshots of this updated BagSync with debug info when hovering over items.
Here it is :)
BagSync.zip
That's very odd. It should be showing the totals for the exact same currency. Is that 96 accurate for your current character? If it is then I'd need to see why the other ones aren't showing up properly.
Go to the following directory on your computer where your World of Warcraft installation is:
World of Warcraft_retail_\WTF\Account<>\SavedVariables
inside that folder is a file called BagSync.lua. Please attach it to this ticket. By either Dragging or Dropping the file when you type out your reply. You can also click the "Attach files by dragging & dropping, selecting or pasting them." link below.
Thanks for the response. I'll take a look and do a comparison. I think the index for the currency has changed in an update. Let me review your data and see if I can fix it :) I kind of figured it was SetMerchantCostItem.
Okay I'm going to need your help again since I don't have WOW installed ;)
Download this debug version of BagSync.
BagSync.zip
It will print to your chatframe some debug info that I need to see. What I need you to do is to take screenshots from each currency starting from the first one on the list and then while going right and back down to the left again. Do it for each one. Especially for the ones that have more than one currency in it. Like the Ominous Shard of Zed which requires two currencies. I need to see if the currency being pulled is in the correct order. Which I think is the problem here. In order to do this, I need to see it in the exact proper order from top to bottom to make sure it's grabbing the currency correctly.
Again this will print stuff in your chatbox :) It should be separated each time by "----"
Whoops I made a mistake. I meant this BagSync. XD
BagSync.zip
Here is the image of all items from "Vision of Bonesmith Heirmir" from Korthia
Items who have 2 currency prices like "Ominous Shard of Zed" only print in chat when hover Stygian Ember, doesn't print nothing while hovering the shards, guess cuz they are just items
Hope it helps, all items in the captures are in order from the shop
Thanks let me review and see if I can spot the pattern. :) I may have to have you debug one more time though. I'll let you know! This is great though and really helps out.
I think I figured it out. Please try the version below. It should work with all the currencies, including the shards that didn't print out debug info. Please let me know if it works and provide screenshots if it does :) Don't forget to keep the ItemID and Debug options turned on so the info shows up on the toolips!
Hey, looks like the tooltip isnt showing nothing, and its not printing nothing in chat, ast least for currecys from shop.
I have enabled ItemID and Debug, but the addon its not working for currencys, just works for items in bag
Okay I think the spotted the error. B: should not be returning "nil" and it should not be going in C unless it's a last resort. GetCurrencyID is returning 1906:0 when it should be returning 1906. Which means in a patch they added another number to the currencyID string. I just need to strip it. It should fix it. Could explain why all this wasn't working in the first place.
Now looks like its showing the correct currency, but just for some characters in the total count, and ignoring other characters haha (For example the first image shows only 3 characters, even when i refreshed data from the rest chars, and for Soul Ash in total doesn't show any character, but in my demon hunter i have a bit from that currency )
Currencys from the currency tab doesn't show nothing in tooltip btw
really? Huh, that's odd it should be working. I'm going to have to add Debug stuff to print to see what's going on. I could have sworn I fixed the issue. Now I'm baffled lol. XD Thanks for your help btw. Let me put together a Debug version.
That version should print out information in chat. It may even work properly. I need you to also check your characters personal Currency Window and see if it works there as well. Let me know how things go :)
Okay hopefully this debug version works properly. Please check the Currencies including the Shard. I need to make sure the item shard works even if it isn't an actual currency. It should print out as "D:" if it works. Also I think I fixed the Currency/Token window, so try that again :)
I think the other characters weren't showing because it wasn't properly linking the currencies.
Looks like currencys are working fine now, even from the currency tab!
Shards are not printing nothing in chat yet, so couldn't test it
Well that's great 😄 ! Solved the currency issue now got to figure out why that shard isn't working. It's using another method entirely according to the debug. OnTooltipSetItem.
I don't think you even have any of these shards. It's displaying the ItemID correctly as 187076.
https://www.wowhead.com/item=187076/shard-of-oth
After reviewing your BagSync.lua data. None of your characters have itemID 187076 anywhere. Which is why that tooltip is empty. Unless I'm missing something it should be working properly then? Just let me know :)
Yeah sadly i dont have any shard since i didnt play the last patch. Maybe its working fine haha.
I Will see if i can get one to test it
Okay, i looted fragments from korthia chest and i think it`s working fine !
That's great news! 😃 What I will do is remove the chat print debug stuff and keep all the changes including the new debug option for the tooltips :) Then I'll push a new version right now on CurseForge and WOWInterface. So keep an eye out for the new update!
Thank you so much for your help! You've been absolutely wonderful and I couldn't have figured this out without your help. 👍