BagSync

BagSync

3M Downloads

"Display Battle.Net Account Characters" makes server appear in tooltip for logged in character on certain realms

HausmeistaHausmeista opened this issue ยท 16 comments

commented

Activating Display Battle.Net Account Characters leads to the display of the realm for the logged in character if the character is on very few selected realms.

Display Battle.Net Account Characters off
WoWScrnShot_121222_194911

Display Battle.Net Account Characters on
WoWScrnShot_121222_195016

Maybe it has something to do with Der Rat von Dalaran being an RP realm and that the RP is omitted in certain situations due to overall length of servername.
Or it's because of the realm name consisting of more than three words as the same happens for characters on the Culte de la Rive noire server. Which is also a RP server.
Or it is something completely different. :)

Can you take a look at this issue? Thank you very much

commented

It's me who has to hand out the thanks. :) For making this addon in the first place and then being so supportive to fix the issues I was having with it. :)
So thanks you very much and Happy Holidays for you and your loved ones. ๐ŸŽ„ ๐ŸŽ… ๐ŸŽ

commented

You as well Happy Holidays! ๐ŸŽ๐ŸŽ„

commented

I don't understand the issue? Turning on BNET option will automatically put the server names if enabled. There is an option to trim down the server names if they are too long. The BNET option literally displays all characters on your BNET account. There is a warning for this option for a reason "(Not recommended)". ๐Ÿ˜„ Please note that it does take connected realms into consideration as well. So if you move on to a realm that is a connected realm, it will display the BNET tags.

https://wowpedia.fandom.com/wiki/Connected_Realms

commented

Okay so I just tested this again. ๐Ÿ˜„ It's working properly.

  • If you are logged in to Server A and it's a connected realm to server B then it will show the XR tag ONLY to other characters that is part of your connected realm and only if you have it enabled. (Meaning characters from Server B for example)
  • If you are currently logged in to a server A and character "Obi-wan" is from Server B. If Server B is not a connected realm to Server A, then "Obi-Wan" will have the BNET tag shown. (only if you have the BNET option enabled)
  • If you are currently logged in to server A and character "Luke" is from Server C. If Server C is a connected realm to Server A, then "Luke" will have the XR tag. (only if you have the XR option enabled)

Long story short if you have either the XR tags or BNET options enabled, it will always take the connected realms into consideration. BNET option overrides the XR option. So it will always take priority if it's NOT a connected realm.

This is working as intended as I tested it with several characters. Please note the connected realm list is the one I use from Blizzard that is literally hard-coded in to their client.

https://wowpedia.fandom.com/wiki/API_GetAutoCompleteRealms

Thanks for filing the ticket though!!! ๐Ÿ˜ƒ

commented

I think you missunderstood me. As the behavior of BagSync is different on two servers compared to all the other servers. So I try again to explain.

Display Options are set like in this screenshot:
WoWScrnShot_121322_133949

I have two chars. Xoxoxoxoxo and LeiaLeiaLeia.
Xoxoxoxoxo is on Server Blackhand, so we call him Xoxoxoxoxo-Blackhand.
Leia is on Server Der Rat von Dalaran, so we call her LeiaLeiaLeia-DerRatvonDalaran.
Both have one Rabbit's Foot in their inventory.

I am logged into Server Blackhand and this is the tooltip of Rabbit's Foot:
WoWScrnShot_121322_134433

Which I assume is correct.
Xoxoxoxoxo-Blackhand has the โœ”๏ธ and no server is displayed in front of his name.
LeiaLeiaLeia-DerRatvonDalaran is on a different server and therefore has her servername displayed in front.

Now let's log into server Der Rat von Dalaran and again look at the tooltip of Rabbit's Foot:
WoWScrnShot_121322_134908

LeiaLeiaLeia-DerRatvonDalaran has the now โœ”๏ธ, which is correct as we are logged into her, BUT her server is displayed in front of her name. This only happens if the character is on realm "Der Rat von Dalaran" or "Culte de la Rive noire".
Xoxoxoxoxo-Blackhand is now from a different server and therefore has his servername displayed in front.

The - for me - expected behavior in this case would be:

โœ”๏ธLeiaLeiaLeia                     Bags:1
[BN Blackhand] Xoxoxoxoxo          Bags:1
commented

It is not about the BN or XR Tag in front of the server, that is not what my ticket is about, This is all working very well.

It is about the display of the currently logged in server in front of the currently logged in character.

In the last days I created characters on more than 50 different realms and so far I could only find two realms where the currently logged in server is displayed in front of the currently logged in character.

So either the behavior is unexpected for these two servers, or for all other ones. :)

commented

I suppose we can do some debug checks to see if I can figure out what you are referring to. I still think it's because in the blizzard code it's being returned as connected and thus the BNET tag is given regardless if they are on the same server. If anything it's a fluke on their end.

But lets check for it anyways :)

BagSync.zip

Use that BagSync. Turn on DEBUG, INFO and WARN. Hover over the items on both characters. Please put out the printout for just the tooltip stuff here for each character. I need to see the ColorizedUnit and ColorizedUnit returns as well as a few other things.

commented

LeiaLeiaLeia-DerRatvonDalaran

[Data]: IterateUnits, nil, nil
[Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran]  Leialeialeia, Der Rat von Dalaran, false, false, Der Rat von Dalaran
[Tooltip]: ColorizeUnit [Realm], Der Rat von Dalaran, DerRatvonDalaran
[Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran] Ghghghghghgh, Der Rat von Dalaran, false, false, Der Rat von Dalaran
[Tooltip]: ColorizeUnit [Realm], Der Rat von Dalaran, DerRatvonDalaran
[Tooltip]: ColorizeUnit, [BN Blackhand] Xoxoxoxoxo, Blackhand, false, false, Der Rat von Dalaran
[Tooltip]: ColorizeUnit [Realm], Der Rat von Dalaran, DerRatvonDalaran
[Tooltip]: TallyUnits, table: 00000217281600F0, 3300, 3300, OnTooltipSetItem, nil, 3
commented

Xoxoxoxoxo-Blackhand

[Data]: IterateUnits, nil, nil
[Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran] Ghghghghghgh, Der Rat von Dalaran, false, false, Blackhand
[Tooltip]: ColorizeUnit [Realm], Blackhand, Blackhand
[Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran] Leialeialeia, Der Rat von Dalaran, false, false, Blackhand
[Tooltip]: ColorizeUnit [Realm], Blackhand, Blackhand
[Tooltip]: ColorizeUnit,  Xoxoxoxoxo, Blackhand, true, false, Blackhand
[Tooltip]: ColorizeUnit [Realm], Blackhand, Blackhand
[Tooltip]: TallyUnits, table: 000002170D5B6F40, 3300, 3300, OnTooltipSetItem, nil, 3
commented

Nininininini-DieAldor

[11:21:23]: [Data]: IterateUnits, nil, nil
[11:21:23]: [Tooltip]: ColorizeUnit, [BN Blackhand] Xoxoxoxoxo, Blackhand, false, false, Die Aldor
[11:21:23]: [Tooltip]: ColorizeUnit [Realm], Die Aldor, DieAldor
[11:21:23]: [Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran] Leialeialeia, Der Rat von Dalaran, false, false, Die Aldor
[11:21:23]: [Tooltip]: ColorizeUnit [Realm], Die Aldor, DieAldor
[11:21:23]: [Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran] Ghghghghghgh, Der Rat von Dalaran, false, false, Die Aldor
[11:21:23]: [Tooltip]: ColorizeUnit [Realm], Die Aldor, DieAldor
[11:21:23]: [Tooltip]: ColorizeUnit,  Nininininini, Die Aldor, true, false, Die Aldor
[11:21:23]: [Tooltip]: ColorizeUnit [Realm], Die Aldor, DieAldor
[11:21:23]: [Tooltip]: TallyUnits, table: 0000021851A3C0E0, 3300, 3300, OnTooltipSetItem, nil, 4

And here is char from a server (Die Aldor) with a blank in the name, where it is working correctly.

commented

[Data]: IterateUnits, nil, nil
[Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran] Leialeialeia, Der Rat von Dalaran, false, false, Der Rat von Dalaran
[Tooltip]: ColorizeUnit [Realm], Der Rat von Dalaran, DerRatvonDalaran
[Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran] Ghghghghghgh, Der Rat von Dalaran, false, false, Der Rat von Dalaran
[Tooltip]: ColorizeUnit [Realm], Der Rat von Dalaran, DerRatvonDalaran
[Tooltip]: ColorizeUnit, [BN Blackhand] Xoxoxoxoxo, Blackhand, false, false, Der Rat von Dalaran
[Tooltip]: ColorizeUnit [Realm], Der Rat von Dalaran, DerRatvonDalaran
[Tooltip]: TallyUnits, table: 00000217281600F0, 3300, 3300, OnTooltipSetItem, nil, 3

For some reason, Der Rat von Dalaran is not being returned as a connected realm by the server. Otherwise the first true/false variable after the name would be true.

[Tooltip]: ColorizeUnit, [BN Der Rat von Dalaran] Leialeialeia, Der Rat von Dalaran, false, false, Der Rat von Dalaran

According to https://wowpedia.fandom.com/wiki/API_GetAutoCompleteRealms Der Rat von Dalaran should be a connected realm.

Lets see if that is true from the server. Load this version of BagSync. I added another Debug line.
BagSync.zip

Make sure DEBUG is enabled. Login to the Der Rat von Dalaran server. You are looking for the [Data]: RealmKey line in the debug.

commented

Here's the data..

[Data]: RealmKey, Der Mithrilorden;Der Ratvon Dalaran;Die Nachtwache;Forscherliga;Todeswache;Zirkeldes Cenarius

I assume it has to do something with the blanks?

commented

Here's the data..

[Data]: RealmKey, Der Mithrilorden;Der Ratvon Dalaran;Die Nachtwache;Forscherliga;Todeswache;Zirkeldes Cenarius

I assume it has to do something with the blanks?

I'd have to check why that is being returned that way by the server. It would explain why it's not working as it's not matching the name stored correctly.

commented

Implemented some realm name checks to double check for situations like these. Please try this version.

BagSync.zip

commented

Thank you very much again for all your hard work!
I tested all the servers having issues in the past and it worked for all of them now. :) Also tested a few "normal" servers and could not detect any issues. ๐Ÿ‘ ๐Ÿ‘

commented

Thank you very much again for all your hard work! I tested all the servers having issues in the past and it worked for all of them now. :) Also tested a few "normal" servers and could not detect any issues. ๐Ÿ‘ ๐Ÿ‘

Oh good! ๐Ÿ˜„ I'm glad it worked. Thanks for the patience and time to work with me to resolve these tickets.