BagSync

BagSync

3M Downloads

`[*XR]` label in front of same-faction guild on connected realm (in tooltip count)

tflo opened this issue · 24 comments

commented

Copied from here:

Despite having unchecked the "Display [XR] and [BNet] realm identifiers.", I have a [*XR] label in front of my connected-realm guild, if I'm logged in to the faction of the guild. Both guilds are connected-realm, but for the guild of the currently opposing faction, the label is not displayed.

If I activate the "Display [XR] and [BNet] realm identifiers.", then I have a [*XR][XR] label for the same-faction guild and an [XR] label for the opposing-faction guild.


show me a picture of what you mean for the several occasions you mentioned above

[Explanation of the screenshots in the next section.]

With "Display [XR] and [BNet] realm identifiers." disabled:

WoWScrnShot_032023_205103

With "Display [XR] and [BNet] realm identifiers." enabled:

WoWScrnShot_032023_205358


Break it down for me by faction, realm, and connected realm

My main activity is on a Connected Realm. All my chars are on one "sub-realm" of the connected realm (Azjol-Nerub), both guilds (i.e Horde and Alliance) are on the other sub-realm (Quel'Thalas).

The screenshots were made while on an Alliance char. The Alliance guild is "Dark Souls of Azeroth", the Horde guild is "Tremors".

The same-faction guild (= same faction as the logged-in char), that is "Dark Souls of Azeroth" on the screenshots, shows the [*XR] label, while the opposing-faction guild ("Tremors") does not.

When I'm on a Horde char, it is analogous: The same-faction guild, which is "Tremors" then, shows the [*XR] label, while the opposing-faction guild ("Dark Souls of Azeroth") does not.

commented

Oh and please show me a picture so I know the changes are looking nice :)

commented

Okay I think I know what it is. I'm going to make it so all the TAG options are honored when displaying stuff other then forcing it. I think that's the issue going on here. This includes the option to show tags at all. When that is disabled then I will force a small indicator for just XR guilds.

In addition. I don't like the cross realm guild being too similar to the other XR realms. I'm going to change it to a plus sign instead since asterisk is an option in the BagSync tag config. It should be [+] or [+XR].

Please try this version, I even added the colored LEVEL for the battle pets in the details window.
BagSync.zip

Let me know if works properly for you.

commented

Scroll up I posted before you.

Yeah, that's what i meant with cross-posted ;)

commented

Oh BTW the cross realm marker for a guild should ONLY be displaying if you have both of these options disabled.

  • Display Battle.Net Account characters. [BNet] (Not Recommended)
  • Display Cross-Realms / [Connected Realms] characters. [XR]

If both of those options are disabled then technically the guild would never show up for a user. In order to process the guild even if those options are disabled, I check for both to be off. If they are both off and a players guild matches the DB guild but don't share the SAME server, then it displays the guild with the special marker [+]. To let folks know the guild is being forcefully shown because the currently logged in character is part of that guild. Otherwise if any of the options above are enabled the guild would show up normally. Either with the BNET tag for the first option or the XR tag on the second option.

It has nothing to do with the "Display [XR] and [BNet] realm identifiers." option btw. That's just for the XR and BNET tags themselves. You can actually disable those and only show the realm names.

commented

Basically it's the same, just the double tag with "Display [XR] and [BNet] realm identifiers." is gone:

Without "Display [XR] and [BNet] realm identifiers.":

WoWScrnShot_032023_215243

With "Display [XR] and [BNet] realm identifiers.":

WoWScrnShot_032023_215256

This is, like the previous screenshots, while logged into an Alliance toon.

But, I think, you are not getting my point:

  • With all tag options disabled, I expected to see no tags at all
  • Both guilds are on the other connected sub-realm (Quel'Thalas) than all the chars (Azjol-Nerub). So, – in my understanding – both guild banks should have exactly the same tag – if tags are enabled.

In case you don't believe me, here with the literal sub-realm names:

WoWScrnShot_032023_215925


Oh and please show me a picture so I know the changes are looking nice :)

Here the color-coded pet rarity:

WoWScrnShot_032023_215451

commented

We have cross-posted now. I will post an image of the settings in a few minutes.

commented

Scroll up I posted before you.

commented

Also are you showing these results from the advanced search screen? Because of you are then those options will always force the tag identifiers. That's by design. You should use the regular search window. The Advanced Search is basically a dump all based on the selections provided. It will override and perform tag identifiers regardless of results. This is by design as the tooltip would show information other then the current users realm.

commented

These are tooltips from the regular list (not advanced). Images in a few seconds…

commented

WoWScrnShot_032023_222527

WoWScrnShot_032023_222538

WoWScrnShot_032023_222551

WoWScrnShot_032023_222601

commented

image
It should not be displaying the [+] with the option enabled. That's a bug. It should ONLY show that if both Account-Wide options are disabled. In that scenario it should have just shown Dark Souls but without the identifier.

image

This one is working properly. With both options disabled it's showing you the guild with the [+] tag because you are logged into a toon that is in that guild even if it's on a connected realm.

image

Again it should not be showing the [+] tag. I'm a bit baffled as I do a check to make sure both options are disabled. Somehow it's being turned on. It should only be showing the [XR] tag for both.

image
This one is working correctly technically. It's not showing Tremors because you don't have cross realms XR enabled. It's only showing you Dark Souls because your current character that is logged in is part of that guild. I said technically because the XR is being shown even with the option disabled. I'm pondering if I care or not lol. I mean the option IS enabled, it's just grayed out.

Let me take a quick look at the logic. It should not be displaying [+] if any of the two options are enabled. That's a bug.

commented

image It should not be displaying the [+] with the option enabled. That's a bug. It should ONLY show that if both Account-Wide options are disabled. In that scenario it should have just shown Dark Souls but without the identifier.

Yep, that's what I meant: With all tag options disabled i expect to not see any tags. (The exception that you display the + for the membership guild if XR is disabled makes sense though.)

commented

I'm going to need your BagSync.lua file. Something is going on and the logic is still assigning the XRGuild tag when it shouldn't, That should only display if both options are disabled (for obvious reasons, since the current character is part of a guild that is on an XR realm, so it needs to be shown regardless of settings.) Perhaps I can see where it's turning it on.

commented

Thanks let me see if I can replicate the issue. I'm a bit perplexed as it's simple logic. So I'm assuming it's a typo somewhere.

commented

Btw, concerning the "Display Cross-Realms / [Connected Realms] characters" setting:

I would not treat 1) true cross-realms the same way as 2) cross-realms on the same connected realm. The latter is irrelevant for the player, since linked realms are behaving as if they were the same realm. In the case of true cross-realms though (not connected, independent realms), it is important, because you cannot send items/gold there (except account-bound stuff).

commented

Both cross and connected realms are treated exactly the same in Blizzard code. It's actually returned as a cross realm. Also I've had people in the past ask me to show identifiers for it if they enable it. That's why it's done that way even if it's a connected realm.

commented

Also I've had people in the past ask me to show identifiers for it if they enable it

The identifiers are fine, if someone wants to see them.

I meant the merging of the count display itself into one option (but maybe I am misreading the setting):

If I do not want to see the item counts of toons on another (not connected) realm, than there is a good reason for it: I do not have access to those items from the other realm, they are rather clutter in the tooltip.

But if I disable the "Display Cross-Realms / [Connected Realms] characters" option, then I will also no longer see the item counts of the chars on the linked realm (on the connected server), or the other-faction guild bank (on the linked realm) in my case.

commented

But sorry, I'm going OT once again ;)

commented

I found the issue, it was being overwritten on a local player guild check. That is why it kept showing.

Also no worries. Just treat Connected Realms as Cross Realms for all intent and purposes with BagSync. In the Blizzard code that's how they are handled BTW. So I use the same code they do. https://wowpedia.fandom.com/wiki/API_GetAutoCompleteRealms

What I can do however is just reword all instances of Cross Realms to Connected Realms to make it easier to understand.

commented

Ah, damn, I was indeed misreading it. Just logged into a different-realm (Draenor, not connected) char to verify, and, indeed, items from my main realm are not shown there, no matter the checkmark on that option. (I could not see it the other way round before, because my char there is an inactive cross-realm pet trader who currently has nothing in her bags ;)

The slash in the settings text was misleading me, I read it as 'cross realm AND connected realm'.

I found out now that the real cross-realm setting is the "Display Battle.Net Account characters" one. (I was always thinking that this would refer to chars on other accounts on the same BNet account, and I was wondering how you would do that…)

commented

Yes that is how that works. I'll just rename Cross Realms to Connected Realms to make it easier to understand.

commented

I'll also change the XR tag to CR instead

commented

Thank you, tags are displayed as expected now with 19.2.