BagSync

BagSync

3M Downloads

same guild across multiple connected servers

JimGiordano2 opened this issue · 30 comments

commented
commented

Here it is from a different character on another server-
[19:26:24]: [IterateUnits]: UnitInfo-1, Yopa, Farstriders
[19:26:24]: [IterateUnits]: UnitInfo-2, MAGE, Pandaren, 3, Alliance
[19:26:24]: [IterateUnits]: UnitInfo-3, ii©, ThoriumBrotherhood
[19:26:24]: [IterateUnits]: RealmKey, Farstriders;Silver Hand;Thorium Brotherhood
[19:26:24]: [IterateUnits]: RealmKey_RWS, SilverHand;ThoriumBrotherhood;Farstriders
[19:26:24]: [IterateUnits]: player, Tug, Silver Hand, true, ii©, ThoriumBrotherhood, Farstriders;Silver Hand;Thorium Brotherhood, SilverHand;ThoriumBrotherhood;Farstriders
[19:26:24]: [IterateUnits]: player, Fip, Silver Hand, true, ii©, ThoriumBrotherhood, Farstriders;Silver Hand;Thorium Brotherhood, SilverHand;ThoriumBrotherhood;Farstriders
[19:26:24]: [IterateUnits]: guild, ii©, Thorium Brotherhood, true, false, Farstriders;Silver Hand;Thorium Brotherhood, SilverHand;ThoriumBrotherhood;Farstriders
[19:26:24]: [IterateUnits]: player, Ikî, Thorium Brotherhood, true, ii©, Thorium Brotherhood, Farstriders;Silver Hand;Thorium Brotherhood, SilverHand;ThoriumBrotherhood;Farstriders
[19:26:24]: [IterateUnits]: player, Yopa, Farstriders, true, ii©, ThoriumBrotherhood, Farstriders;Silver Hand;Thorium Brotherhood, SilverHand;ThoriumBrotherhood;Farstriders
[19:26:24]: [IterateUnits]: guild, ii©, ThoriumBrotherhood, true, false, Farstriders;Silver Hand;Thorium Brotherhood, SilverHand;ThoriumBrotherhood;Farstriders
bagsync3

commented

And from a character on the third server-
bagsync3

commented

Note that the count is different for the two lines for the guild shown. The count will be corrected when I use a character on thorium brotherhood and look at the guild bank. It's wrong now, because I withdrew one item for each for Yopa and Tug since the last time I was on thorium.

commented

No worries, you kept putting the entire description in the title line.

commented

I will look into the issue when I have a chance. If you can provide some pictures and such of your issue as well, that helps me a lot. You can copy and paste the pictures here in the commands or click the "Attach files" line at the bottom of the comment box.

commented

You wrote the entire problem as the title for the ticket. Here is your original post.

same guild across multiple connected servers- I have many alts across three connected servers, and they all belong to my private guild. Bagsync treats them as different guilds, showing the current server just by the server name, and also a line for the quild on the other server, and adds both into the total count of items found. I tried every setting under the config window, but no luck. Is there a simple fix for this?

commented

Please stop editing it.

commented

sorry, first time using this system. easy to tell a Noob.

commented

[19:07:50]: [Unit]: GetPlayerInfo, Ikî, Thorium Brotherhood, Alliance, MAGE, Worgen, ii©
[19:07:50]: [Data]: IterateUnits, nil, nil
[19:08:07]: [Unit]: GetPlayerInfo, Ikî, Thorium Brotherhood, Alliance, MAGE, Worgen, ii©
[19:08:07]: [Tooltip]: TallyUnits, CacheUsed, [Potion of Prolonged Power]
[19:08:07]: [Data]: GetPlayerObj, Ikî, Thorium Brotherhood, true
[19:08:07]: [Tooltip]: ColorizeUnit, |A:raceicon-worgen-male:13:13:0:0|a Ikî, Thorium Brotherhood, true, false, Thorium Brotherhood
[19:08:07]: [Data]: GetPlayerGuild, ii©, true
[19:08:07]: [Tooltip]: ColorizeUnit, ii, Thorium Brotherhood, true, false, Thorium Brotherhood
[19:08:07]: [Tooltip]: TallyUnits, 142117, 142117, OnTooltipSetItem, nil, 988, WL-OFF

commented

Also please do the following:

  1. Type /bgs debug
  2. Check "Enable Debug"
  3. Make sure only "DEBUG" is selected.
  4. Press "Clear"
  5. Press "Iterate Units"
  6. Press "Export"
  7. Select all the text and copy Ctrl+C and paste it here Ctrl+V, or you can take a screenshot up to you.
commented

Here's a little screen shot showing the results
bagsyncproblem

commented

Yes, the guild name is "ii"

commented

Also please do the following:

  1. Type /bgs debug
  2. Check "Enable Debug"
  3. Make sure only "DEBUG" is selected.
  4. Press "Clear"
  5. Press "Iterate Units"
  6. Press "Export"
  7. Select all the text and copy Ctrl+C and paste it here Ctrl+V, or you can take a screenshot up to you.

:) please follow these steps one at a time. You didn't "iterate units"

commented

image

commented

Thank you so much for the info! 😃 🎉 It helps me a lot to try to figure out the issue. I'll review what you posted and see if I can trace the issue and slap the bug lol. I may ask for some more information or give you test versions of BagSync to try.

commented

Okay there may be a possibility that Blizzard is returning the wrong server name for connected guilds. You'll notice that there are two listed but actually they are different. One has a space the other does not. "Thorium Brotherhood" is not the same as "ThoriumBrotherhood" that is why it's showing twice. The two actually don't match because of the extra space. It's possible that Blizzard is sending both names and that is where the problem is. I need to do checks for this.

Can you please upload here your BagSync.lua found under your WOW installation. You may need to zip it up. You can find it at the following location.
WOW INSTALL Directory\_retail_\WTF\Account\<your account name>\SavedVariables\BagSync.lua

To attach a file click on "Attach files by dragging and dropping" at the bottom of the comment box.

commented

In addition to my request above, I need you to login to some of your characters both on the same realm as your guild and those on connected realms. I need various checks to ensure this is the problem. So on each toon type the following in your chatbox exactly (I suggest you copy and paste it) and show me the results. I'm beginning to suspect this is a Blizzard/WOW issue and not a BagSync issue. They may have messed up and returned the wrong information to addon authors.

/script print("DEBUG", " || ", _G.GetRealmName(), " || ", select(4, _G.GetGuildInfo("player")))

commented

BagSync.zip

Thank you for your quick response and actions. I used to use the addon BankItems, but I couldn't figure out how to fix it with the latest changes, so BagSync is a real game saver for me :)

commented

No worries I want to make sure it's working correctly for you. If it's a bug on Blizzards end I need to work around it. Let me know the results of the /script above as well 😄

commented

And here's the results from the script-

DEBUG || Thorium Brotherhood || nil
DEBUG || Thorium Brotherhood || nil

DEBUG || Silver Hand || ThoriumBrotherhood

DEBUG || Farstriders || ThoriumBrotherhood

commented

YEP! It's what I suspected. If you notice on servers that aren't the same as the guild it's returning the wrong realm name. They are returning it without spaces. This is Blizzards fault. I'm going to have to make fixes for their mess.

commented

Thanks!

commented

Okay so lets try an edited version of BagSync to fix this issue.

BagSync.zip

Okay try that version of BagSync. If you don't know how to install addons manually, just extract that to following directory. (You may want to delete the BagSync that's already there or you can overwrite it, up to you.)
WOW INSTALL Directory\_retail_\Interace\Addons\

Once you installed PLEASE follow these steps.

  1. Login to each and every one of your characters on every realm and check the guild bank.
  2. Once the above is done, verify the guild is only showing up once now in the tooltips, no matter what character you login as.
  3. Do the following command, /bgs fixdb
  4. Verify the tooltips again and make sure it's still working.
  5. Finally upload your BagSync,lua file again here to verify everything is correct in the database.
    (WOW INSTALL Directory\_retail_\WTF\Account\<your account name>\SavedVariables\BagSync.lua)
commented

Looks good so far :)

commented
commented

sorry, just noticed I forgot to fixdb. will do that now.

commented

sorry, just noticed I forgot to fixdb. will do that now.

Okay it looks like the database is cleaned up now on your end. I also verified it on my end as well. So this issue was fixed. I had to perform some checks to make sure the server name Blizzard is returning is one we already knew or had stored. It's a mistake on their part to send back the "Normalized" realm name. Which is a realm with no spaces or hyphens. It causes a whole heap of issues for addon authors. I'll finalize the changes and push a live update. Thanks for your patience and helping me out to get this resolved.

commented

And thank you for your excellent addon and quick response and patience :)

Please delete all this stuff, many of my posts are just embarrassing.

commented

And thank you for your excellent addon and quick response and patience :)

Please delete all this stuff, many of my posts are just embarrassing.

Of course! Glad it worked out. Bug reports like yours helps me out in the end for others whom may have the same issue. Don't worry about this ticket, I will close it once I push the changes.

commented

I pushed the changes to V19.5 enjoy.