Type search for caged pets?
tflo opened this issue · 13 comments
How can I narrow down my search to show only caged pets and eliminate noise like shown in the screenshot ("Peanut" is a pet, "Skewered peanut Chicken" is noise):
I tried many things, like Peanut && t:pet, Peanut && t:battle pet, Peanut && t:battlepet, Peanut && t:pet cage, but to no avail. A negated type (like t:!=consumable) doesn't seem to work either.
The t:pet seems to match the pet install items (the ones that say "Teaches you how to summon this companion") and is the same as t:companion (which is the 'official' type of these things AFAIK), but it doesn't match caged pets (i.e. the ones you have moved from the pet journal into a bag).
Sorry if I'm missing the obvious…
If I'm not missing the obvious —and you are able to improve this— here a proposal:
t:petshould match both caged pets and Companions (the install thingies)t:companionshould match Companions (the install thingies) — as it is nowt:battle petort:pet cage(ort:battlepetort:petcage) should match caged pets
I never added any qualifiers for battle pets because of the whole issue with the guild bank and mailbox. I suppose I can have it parse the cache for the information. It may not be 100% accurate though as remember it's using itemID for the most part. Let me review the code.
OK, I see.
Maybe – just a spur-of-the-moment thought – if caged pets are the only things that do not belong to any category/type for BS, then you could define a caged pet qualifier by excluding any item that has an associated type?
I'll just see if I can have it check the Cache that is passed for the SpeciesID. If it exists then it's a battlepet. If no cache is passed and a FakeID is passed, then again it's a battlepet.
I will do t:battlepet and t:petcage
I will do t:battlepet and t:petcage
Great!
If t:pet would match both caged pets (t:petcage) and the pet install items (t:companion currently), that would be extra great :)
(This would be useful because sometimes the install items have the same name as the actual pet, so we could either distinguish in the search or go for both.)
Good to hear.
I don't have a subscription
If you ever need someone to test a bugfix or whatever, I'm there.
t:pet the use of just "pet" would be too generic and may cause complications in the future for any equip slot or type that may have the letters "pet" in the word. So to prevent this I'm sticking with petcage and battlepet.
I said t:pet just because it already was there before (apparently as synonym to t:companion).
Something like t:allpets or t:anypet would of course also be fine (to match both "types" of pet, i.e. companion and petcage). But if you don't want to add such a catch-both qualifier at all, it's also fine :-)
Okay I have it set to t:petcage or t:battlepet, it will take companions into account when processing
I have it working now. This will definitely be my last enhancement or modification. I'm really only going to do bug fixes from now on. I don't have a subscription and I'm taking a break from WOW for the time being 😄 . I do hope this addition does help you though.
Okay I have it set to t:petcage or t:battlepet, it will take companions into account when processing
That's great too :-)
This will definitely be my last enhancement or modification.
Understood, will only report bugs then from now on ;)
I don't have a subscription and I'm taking a break from WOW for the time being
I hope you're not going to abandon the addon!
I'm not going to abandon the addon. I haven't abandoned it since I created it back in Vanilla WOW. I just really need a break and I did spend a huge amount of time and resources rewriting the addon. I just want to put it in maintenance mode for the time being until I get back into WOW again.
Loaded your new version now, t:battlepet / t:petcage works great.
Thank you very much! And I wish you a relaxing WoW-free time!