BagSync

BagSync

3M Downloads

Keybinds are not obvious now after DF

mbattersby opened this issue ยท 8 comments

commented

Because header= is no longer shown in the keybindings they aren't obviously part of BagSync now.

image

I would suggest the right fix is probably to remove header= and set category="BINDING_HEADER_BAGSYNC" in Bindings.xml

commented

Unless header= being not shown is some bug in my UI.

commented

That's very odd! It should be showing BagSync as I provide a header format for the Addon. Unless they changed things (which they always freaking do) it should be working? I'd have to take a look at it honestly to see what's going on.

commented

Seems like header= is no longer working (WeakAuras authors confirmed also) and just shows a blank line. It may be a bug but Blizzard don't seem to be going to fix it. I think the right fix is to remove header= and add category= to all the bindings.

commented

Why am I not surprised when it comes to Blizzard fixing things.... lol. I'll take a look.

commented

Get used to it.

commented

Hmmm I wonder if there is a conflict from the other WOW clients vs Dragonflight in terms of the headers. That could be why it's picked up in the WOTLK and Classic but not Dragonflight. If I used categories it may break that. Would have to do some testing sometime next week.

commented

Okay I took some time to look into this. You were right, they did remove the header parameter. Apparently now all you need is to set your own category and it adds it to the list. I will be pushing an update for this. Thank you very much for filing this ticket!

commented

This was fixed in latest commit:
25cb661