Lua error opening bank after upgrade to 19.52

Question

Lua error opening bank after upgrade to 19.52

b-morgan opened this issue 2 months ago · 8 comments

b-morgan commented 2 months ago

I upgraded BagSync to 19.52 and when opening the bank on my first login, I got the following Lua error:

3x BagSync/wireframe/tooltip.lua:508: bad argument #1 to 'sort' (table expected, got nil)
[string "=[C]"]: in function `sort'
[string "@BagSync/wireframe/tooltip.lua"]:508: in function `UnitTotals'
[string "@BagSync/wireframe/tooltip.lua"]:1005: in function `TallyUnits'
[string "@BagSync/wireframe/tooltip.lua"]:1328: in function <BagSync/wireframe/tooltip.lua:1303>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `securecallfunction'
[string "@Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua"]:61: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:56>
[string "@Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua"]:81: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:77>
[string "@Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua"]:117: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:107>
[string "=[C]"]: in function `SetAttribute'
[string "@Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua"]:142: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:135>
[string "@Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua"]:288: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:238>
[string "=[C]"]: in function `securecallfunction'
[string "@Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua"]:235: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:234>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `SetBagItem'
[string "@Blizzard_UIPanels_Game/Mainline/ContainerFrame.lua"]:1553: in function `OnUpdate'
[string "@Blizzard_UIPanels_Game/Mainline/ContainerFrame.lua"]:1512: in function `OnEnter'
[string "@Blizzard_UIPanels_Game/Mainline/ContainerFrame.lua"]:1508: in function <...s/Blizzard_UIPanels_Game/Mainline/ContainerFrame.lua:1507>

Locals:
(*temporary) = nil
(*temporary) = "table expected, got nil"

b-morgan · Answer 1 · 2024-09-22T14:52:41.000Z

With further testing, it doesn't appear to have anything to do with opening the Bank (or Warband Bank) but rather mousing over items in my character's reagent bag that are also in my Warband Bank. I am using Baganator for my bag addon.

Xruptor · Answer 2 · 2024-09-22T14:53:35.000Z

Definitely a bug. I forgot that the tab data needs to be updated since it's no longer being pulled from the cache. This was a mistake on my part as I completely forgot about that portion of the code. If you disable the option to see Warband tabs, it should fix it temporarily as I work to patch it.

b-morgan · Answer 3 · 2024-09-22T15:06:02.000Z

Will 19.51 work until you get a patch out?

Xruptor · Answer 4 · 2024-09-22T15:11:23.000Z

I'm working on it right now actually. Should be out real soon.

b-morgan · Answer 5 · 2024-09-22T15:12:00.000Z

OK, I'll wait (and quit bugging you) :-)

Xruptor · Answer 6 · 2024-09-22T15:12:54.000Z

You're not bugging me at all, in fact I'm actually glad you put a bug report in.

Xruptor · Answer 7 · 2024-09-22T15:14:34.000Z

I fixed it and I'm uploading it now. :) 💚

b-morgan · Answer 8 · 2024-09-22T15:46:44.000Z

As a fellow addon developer (Skillet, Skillet-Classic), I understand the value of good issue reporting. What I meant by bugging you was continuing to ask questions in this issue while you were working on the solution!

Thank you for your prompt resolution! I was working of consolidating fish from multiple toons into the warband bank. I'll turn the option back on now.

Share to