BagSync

BagSync

3M Downloads

No portrait for eartherns

naggert opened this issue ยท 12 comments

commented

I've been waiting but nothing seems to happen and I'm starting to question whether it's an issue on my end or yours.
Version 19.58
bagsync

commented

Thank you for posting this. This is definitely a bug with the new race. They must have updated the character grid I use to pull the races from.

commented

BagSync.zip

Please try the version above and let me know if that fixes the issue for you.

commented

Hi. It does not seem to work.
I copied the folder into my plugins folder and replaced the existing files.
I've relogged a few characters and restarted the game.

Do I need to do something manually?

commented

BagSync.zip

It requires a bit of debugging that's all. We need to see what's going on.

Download and use the new BagSync I just updated above.

In the game do the following.

  1. Type /bgs debug
  2. Enable the BagSync Debug
  3. Check only INFO and SL3
  4. Press CLEAR
  5. Hover over an item that you know an earthern character has or should display.
  6. Export the details here for me to see
  7. Remember to turn off BagSync Debug
commented

Sorry about the delay, I had a meeting.
It has the right icon now.
But here is the info you requested:

[19:17:51]: [Tooltip]: CurrencyTooltip, Resonance Crystals, 2967113, 2815, OnTooltipSetCurrency, true [19:17:51]: [Data]: IterateUnits, nil, nil [19:17:51]: [Tooltip]: GetRaceIcon, Pandaren, pandaren, 2, 13, 0, 0, nil, |A:raceicon-pandaren-male:13:13:0:0|a, raceicon-pandaren-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-pandaren-male:13:13:0:0|a Quinlan, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Human, human, 3, 13, 0, 0, nil, |A:raceicon-human-female:13:13:0:0|a, raceicon-human-female [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-human-female:13:13:0:0|a Ballycraic, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Human, human, 2, 13, 0, 0, nil, |A:raceicon-human-male:13:13:0:0|a, raceicon-human-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-human-male:13:13:0:0|a Kenny, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Human, human, 2, 13, 0, 0, nil, |A:raceicon-human-male:13:13:0:0|a, raceicon-human-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-human-male:13:13:0:0|a Dougal, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Dwarf, dwarf, 2, 13, 0, 0, nil, |A:raceicon-dwarf-male:13:13:0:0|a, raceicon-dwarf-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-dwarf-male:13:13:0:0|a Fergus, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Human, human, 2, 13, 0, 0, nil, |A:raceicon-human-male:13:13:0:0|a, raceicon-human-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-human-male:13:13:0:0|a Bartholomew, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Human, human, 2, 13, 0, 0, nil, |A:raceicon-human-male:13:13:0:0|a, raceicon-human-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-human-male:13:13:0:0|a Naggert, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Human, human, 2, 13, 0, 0, nil, |A:raceicon-human-male:13:13:0:0|a, raceicon-human-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-human-male:13:13:0:0|a Rick, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, EarthenDwarf, earthen, 2, 13, 0, 0, nil, |A:raceicon-earthen-male:13:13:0:0|a, raceicon-earthen-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-earthen-male:13:13:0:0|a Glint, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, NightElf, nightelf, 2, 13, 0, 0, nil, |A:raceicon-nightelf-male:13:13:0:0|a, raceicon-nightelf-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-nightelf-male:13:13:0:0|a Randolph, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Human, human, 2, 13, 0, 0, nil, |A:raceicon-human-male:13:13:0:0|a, raceicon-human-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-human-male:13:13:0:0|a Harry, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, KulTiran, kultiran, 2, 13, 0, 0, nil, |A:raceicon-kultiran-male:13:13:0:0|a, raceicon-kultiran-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-kultiran-male:13:13:0:0|a Norrington, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, VoidElf, voidelf, 2, 13, 0, 0, nil, |A:raceicon-voidelf-male:13:13:0:0|a, raceicon-voidelf-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-voidelf-male:13:13:0:0|a Encanis, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, KulTiran, kultiran, 2, 13, 0, 0, nil, |A:raceicon-kultiran-male:13:13:0:0|a, raceicon-kultiran-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-kultiran-male:13:13:0:0|a Theodorious, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, Gnome, gnome, 2, 13, 0, 0, nil, |A:raceicon-gnome-male:13:13:0:0|a, raceicon-gnome-male [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-gnome-male:13:13:0:0|a Malenkaya, Hellfire, true, false, Hellfire [19:17:51]: [Tooltip]: GetRaceIcon, NightElf, nightelf, 3, 13, 0, 0, nil, |A:raceicon-nightelf-female:13:13:0:0|a, raceicon-nightelf-female [19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-nightelf-female:13:13:0:0|a Bernadette, Hellfire, true, false, Hellfire

commented

Wow.. it didn't keep it's formatting on separate lines. It's one giant blob of text. No worries I can still use it. That's okay I'll have to fix it a bit then.

commented

log.txt
Try this :)

commented

log.txt Try this :)

MUCH better thanks lol

commented

Yeah no problem. I saw how messed up it was, went to edit and it just aligned. I thought it would somehow be nice to you if you copied the data. But yeah. I hope the .txt helps ;)

commented

Not sure if you saw what I wrote 35 minutes ago when I posted the textclutter? It worked after pasting the second .zip file into my directory.
I'm not sure if you changed anything, but from my side it's working as I would expect :)

commented
[19:17:51]: [Tooltip]: GetRaceIcon, EarthenDwarf, earthen, 2, 13, 0, 0, nil, |A:raceicon-earthen-male:13:13:0:0|a, raceicon-earthen-male
[19:17:51]: [Tooltip]: ColorizeUnit, |A:raceicon-earthen-male:13:13:0:0|a  Glint, Hellfire, true, false, Hellfire

Okay so BagSync is doing it correctly. The UnitRace() for the Earthern is EarthenDwarf. This is valid because it matches that found on: https://warcraft.wiki.gg/wiki/API_UnitRace

According to the raceicons found in the UiTextureAtlasMember.db2 file in WOW. It should be earthen as the icon. Which is correct as it's found here: https://wago.tools/db2/UiTextureAtlasMember?filter[CommittedName]=earthen&page=1

So what BagSync is doing is correcting EarthenDwarf to earthen to get the correct icon as it's SUPPOSED to be in UiTextureAtlasMember.db2 called raceicon128-earthen-male or raceicon-earthen-male as an example. If you check the logs you gave me that is the correct format being returned.

So I'm a bit baffled as to why it's not working. The only thing I can think of is that it's not fully incorporated yet into the client and they forgot that? I'll have another look myself but it should be working according to everything I'm seeing here.

commented

Yeah I added the EarthenDwarf check. Originally it was just checking for Earthen which was the primary issue.

Oh okay so it IS working now then. I was completely baffled as from everything I was looking at, it should have been working. I'm glad it got sorted out then after the recent debugging.