Keyring button missing for classic.

Question

Keyring button missing for classic.

gelsbern opened this issue 5 years ago · 9 comments

gelsbern commented 5 years ago

They have enabled keyrings for classic, keyring button is missing.

ramboozer commented 5 years ago

+1

ProbablyHackng · Answer 1 · 2019-12-11T08:04:01.000Z

I have a local branch to fix this I can create a PR for if you enable PR permissions

SwimmingTiger · Answer 2 · 2019-12-12T05:12:55.000Z

@ProbablyHackng Where is your local branch? I am a addon collection author and I need the patch.

SwimmingTiger · Answer 3 · 2019-12-12T05:31:14.000Z

I wrote a patch myself:
SwimmingTiger/WowBigfootClassic@7eb7a59

ramboozer · Answer 4 · 2019-12-12T06:42:38.000Z

Nice work, if you have another addon such as bagnon this will NOT work unless you disable the addon

ProbablyHackng · Answer 5 · 2019-12-12T07:22:58.000Z

I was hoping that @Nevcairiel could enable PR so I could submit it from my machine, but I can fork if necessary. I added back the state this project used to be where it can be toggled from the option menu.

Nevcairiel · Answer 6 · 2019-12-12T07:59:46.000Z

You can't actually disable Pull Requests, so not sure where you got that idea that it needs enabling. Even when not logged in I see the Pull Request option at the top.

In any case, I'll likely work on this on the weekend.

ProbablyHackng · Answer 7 · 2019-12-12T08:14:42.000Z

Sorry, I just didn't understand how contribution works on GitHub....I'll submit one

ProbablyHackng · Answer 8 · 2019-12-12T08:32:17.000Z

#17 Add Back Classic Keyring: Submitted

Share to