Battle Pet Completionist

Battle Pet Completionist

115k Downloads

Feature Request: Max Rare mode

davidmc24 opened this issue ยท 5 comments

commented

Thanks for the great plugin. For the pets that allow it, I try to collect 3 rare. I've been wishing that there were two new options:

  • a map icon mode for "max rare" rather than just max collected (UPDATE: see #18)
  • the forfeit prompt to be based on lowest rarity rather than highest
  • the forfeit prompt to treat less than max collected as uncollected

I'm happy to work on a PR in that sort of direction if you think this might make sense. Also open to other suggestions.

commented

Sounds like some good ideas ๐Ÿ™‚
Pull requests are more than welcome, just remember to allow the current behaviour as well.
Thank you for helping ๐Ÿ˜ƒ

commented

Just remember to allow the current behaviour as well

Of course!

commented

Thanks for the prompt merge. I'm still planning on working on a new forfeit setting, but that may take a bit longer.

commented

Thank you again for helping out ๐Ÿ™‚
I have pushed 10.2.5-20240317_1 with your patches - it should be available within a few hours.

commented

Sure thing, take your time ๐Ÿ™‚
I'll look at it once it is ready