Battle Pet BreedID

Battle Pet BreedID

5M Downloads

[suggestion] Add Collected Breeds also to Pet Item tooltips

tflo opened this issue · 1 comments

commented

With your recent addition of Collected Breeds as selectable info, I thought at first that this would make the BattlePetCount NG addon obsolete.

Unfortunately, there is one little thing missing:

In BPBID's settings, I can select "Show Battle Pet BreedID Tooltips... On Items". But the "On Items" actually only means on "Caged Pets", not on "Pet Items". Pet items are the items that allow you to add a pet to the Journal, typically they have a tooltip text like "Teaches you how to summon this companion".

Example:

image

The list of collected breeds you see in the tooltip screenshot comes from the aforementioned BattlePetCount NG addon.


I am aware that pet items have a regular Item Tooltip, while the caged pets have a Pet Tooltip and… that you are "specializing" in pet tooltips.

Getting the associated pet species for a pet item is extremely easy, the API provides a working function for this: C_PetJournal.GetPetInfoByItemID(itemid) For more info see my comment here: GurliGebis/WoWAddon-BattlePetCountNG#5 (comment)

So probably the "only" major work would be to add lines (or an attached tip) to the regular Item Tooltips, in addition to the Pet Tooltips. I would love to do a PR, but my knowledge of the tooltip API is incredibly limited 😵

The big advantage for users would be that they wouldn't need two addons anymore. (And the maintainer of BattlePetCount (NG) could put the addon to its well-deserved rest 😴)

Of course, you could then also add the other info to the pet item tooltips, like Available Breeds, etc.


What do you think?

commented

I think this is a good idea. I'll try to find some time to implement it this month.