Breeds not showing correctly in pet journal
octavius-dev opened this issue ยท 3 comments
Addon version name: 11.0.5
Client build: Retail 110005
Breeds aren't showing correctly. I have three "Faceless Minion" that aren't showing the build correctly. So I have a P/P, P/S and a ???.
I checked the addon "Pet Tracker" and this also has the breeds wrong for these three pets, they have them as P/P, H/B and a H/B.
BPBID is correct here. Pet 1 is P/P. Pet 2 is P/S. Pet 3 is either H/B or H/S, indeterminable until level 2, hence the "???". I toyed for a while with displaying "H/B or H/S" (for example) instead of "???", but there ended up being a few cases with a 4-breed stat overlap if the pet was eligible for all or almost all of the 12 breeds. That ended up making the text way too long ("H/S or H/B or P/B or S/B").
I'm not sure why PetTracker is showing H/B for the P/S pet - my guess is that there's a rounding error that happens, even if Battle Pet Breed ID is used as the data source. Just because Battle Pet Breed ID is used as the pet breed data source does not mean it is used for the calculations (probably?).
I think they might be using math.floor instead of math.round (I actually use math.floor as well but I add 0.5 right before I do it in order to mimic rounding because math.round is a little weird). The "real" power value there is actually 11.89499999085. It should be rounded up to 12, but I believe PetTracker is flooring it down to 11, which is the power amount that H/S and H/B have as level 1 rares for that species.
I suspect if you level those 3 pets to level 2, PetTracker will suddenly identify them as P/P, P/S, and either H/B or H/S.
Pet 1: Faceless Minion
Health: 152
Power: 13
Speed: 10
Pet 2: Faceless Minion
Health: 152
Power: 12
Speed: 11
Pet 3: Faceless Minion
Health: 152
Power: 11
Speed: 11
For the above three pets I get the following from the mentioned addons:-
Battle Pet Breed ID: P/P, P/S, ???
PetTracker: P/P, H/B, H/B
So I believe from what you've said that PetTracker would correctly show P/P, H/S, H/B once levelled to level 2.
So this just leaves your addon showing ??? for the H/B pet, and P/S for the H/S pet.
All the screenshots are from when I was using Battle Pet Breed ID as the Breed Source.
What's wrong about this?
From what I can see, this information appears to be correct.
The ??? one is EITHER H/S or H/B, but the addon cannot tell because the stats at level 1 for H/S and H/B are identical. To 'fix' that one, level it up to level 2 or higher.
If I had to guess, I'd say PetTracker probably has a rounding issue that is giving you bad results for that specific addon, but that's not surprising because handling rounding stats properly for Battle Pets is extremely annoying. Even looking at Wowhead, their stats for P/P at level 1 rare are wrong (152 HP instead of 153 HP).
But PetTracker isn't my addon, so perhaps this is feedback best directed there.