Disabling BPBID item tooltip kills TSM tooltip
tflo opened this issue · 4 comments
When the user disables the tooltip in the options, the TSM hook from BreedTooltips.lua remains "active", which means TSM cannot display its tooltip (due to the now missing BPBID tooltip frame).
For a possible solution (resetting the parent frame for TSM), see: Xruptor/BagSync#231 (comment)
– Tom
This is a duplicate of https://www.curseforge.com/wow/addons/battle_pet_breedid/issues/24. Sorry, I have only seen afterwards that you have Issues on Github.
Another issue I noticed with TSM enabled is that on first pet hover after a reload or login no tooltip shows at all but if you move mouse out and in again, then it will show.. but yeah TSM tooltip is broken still if you have the BPBID tooltips disabled
2024-02-15_19-44-46.mp4
I'm sort of torn if the right answer is a simple hack to restore the original parent or if it's to move the BPBID tooltip below the TSM one.
I think I'm going to do the first option because I don't want to throw existing users for a loop too hard, but I might offer the latter solution as an option if people are interested.
You could try the suggestion I mentioned in another thread (don't know if you saw it)
#13 (comment)
That library addon should allow you to add tooltip info directly on the pet tooltip itself without having to add attachments so you won't have to deal with this TSM issue. but don't know how hard it is to add but could give it a try I guess
That library addon should allow you to add tooltip info directly on the pet tooltip itself
If you’re going to integrate the tooltip, there’s also BattlePetTooltipTemplate_AddTextLine
, as showcased by gello (Rematch author) here and there. I’m using this method for years in a private addon and it works correctly.
Not saying that it is better than plusmouse’s (more recent) library, just listing it as a possibility.
As for the other way (leaving it as separate tooltip frame), I don’t know if you remember what I linked as “possible solution” in the OP (heck it’s almost 2 years now ;) . But – as far as I remember – it worked fine, though hackish.
(I went back to the regular BPBID afterwards, simply because I removed TSM from all toons, except the 2 AH toons, so the problem became meaningless.)