BetterBags

BetterBags

1M Downloads

'Free slots' display inconsistant

steven-fuller opened this issue ยท 3 comments

commented

Sorry for putting 4 maybe separate issue into one.

'Free Slots' section with either 0 or 1 free slots loses the subscript label.
Its a little confusing to show a 'Free Slot' with a full bank/bag - perhaps either hiding the section when full or persisting the count for 0 and 1 would be better?

When removing an item from a full bank, a 'free slot' is created in the 'Free Slots' category. When the item is replaced, that free slot isn't removed. reloading the UI hides the non-existent slot.
image
(This slot isn't actually available)

This 'ghost' slot retains the tooltip of the item that was inserted.
image
(mousing over a visually blank slot in a full bank shows the tooltip for the last item added)

Perhaps unrelated, the 'Free Slots' tooltip shows 2 items - not sure what this means - I'd expect a count of free slots I think.

image
image

commented

This is really great feedback!

Sorry for putting 4 maybe separate issue into one.

It's fine, these are all relatively similar.

'Free Slots' section with either 0 or 1 free slots loses the subscript label.

This is actually a Blizzard thing. Let me see if I can work around it, I have a few ideas.

When removing an item from a full bank, a 'free slot' is created in the 'Free Slots' category. When the item is replaced, that free slot isn't removed. reloading the UI hides the non-existent slot.

This is a really good catch, I think I know why this happens.

Perhaps unrelated, the 'Free Slots' tooltip shows 2 items - not sure what this means - I'd expect a count of free slots I think.

This is somewhat intentional, as the tooltip shows "2" on top. I'll change this in a later version.

Overall, the general feedback I'm getting here is that I should test the bag full and bag empty states a bit more.

Thanks, will close this when it's fixed!

commented

When removing an item from a full bank, a 'free slot' is created in the 'Free Slots' category. When the item is replaced, that free slot isn't removed. reloading the UI hides the non-existent slot.

This has also been fixed. I'm leaving the tooltip one alone as it is for now, as I'm undecided on how I want to handle that. Thank you for this amazing bug report, I really appreciate it!

commented

Some updates:

'Free Slots' section with either 0 or 1 free slots loses the subscript label.

This is fixed in main and will be pushed either today or tomorrow.

This 'ghost' slot retains the tooltip of the item that was inserted.

The ghost icon problem has been fixed, and the slot is disabled (but still visible) if there are no slots available, with a 0 in the corner.

I haven't gotten to the other two issues yet, but they are on my list. Will close this when everything is fixed.