BetterBags

BetterBags

1M Downloads

Showing wrong ilevels

FlyingDiver opened this issue ยท 21 comments

commented

Drogbar Stones, and a couple of Sunless leather pieces (all season 2) are showing ilvl 250, when they're actually 411 and 424.

Wildercloth fishing cap showing 317 when it's 320.

Lariat showing 350 when it's 424 (shadowflame crafted).

commented

So interestingly, I can't get the item level info for those items when I manually call /run print(GetDetailedItemLevelInfo(itemID)) where itemID is an ID you passed. Let me see if I can figure out what's going on.

commented

When I try that for the lariat, I get 350 false 350

commented

Can you supply me with ItemID's for the wrong items? I think I know what this is, but I need to test.

commented

Stones is 204811
Moonless items are 204934, 204935
Lariat is 193001
Fishing cap is 193529

commented

Can you edit data\items.lua in your local install and go to line 168, and change the parameter passed into GetDetailedItemLevelInfo from itemID to itemLink and see if that makes it better?

commented

One minute

commented

No it did not. Same results.

commented

Hm, so that's right -- that's what the Blizzard API returns. How about /run print(GetItemInfo(itemID)) and the output of that?

commented

[16:44] Elemental Lariat [Elemental Lariat] 4 350 1 Armor Miscellaneous 1 INVTYPE_NECK 4548906 356629 4 0 1 9 nil false

commented

The other API is also returning 350 -- those are the only two API's for getting item level that I'm aware of. How are you getting your item level information?

commented

tooltip

commented

Screenshot?

commented

This keyboard doesn't have a print screen key, and I only use Windows for gaming. Is there a key combo that will work?

commented

Windows key + Shift + S on any modern windows, then click/drag a box to capture.

commented

Let's try this other API -- do this.

In items.lua, under GetDetailedItemLevel, add:

effectiveIlvl = C_Item.GetCurrentItemLevel(itemLocation)

Reload, and see if that does it.

commented

Screenshot 2023-12-03 165056

commented

Leave the parameter as itemLink, or revert it?

commented

doesn't matter, we're overriding the variable we care about

commented

That fixed it.

commented

Okay, excellent, fix incoming.

commented

Update pushed with .58, thanks for your help!