BetterBags

BetterBags

1M Downloads

I broke it

deathmessinger opened this issue ยท 3 comments

commented

Just got 3 lua errors from BB
I was creating the korthian gear from the tokens you can buy when the rest of the tokens disappeared

1st: 1x BetterBags/util/sort.lua:75: attempt to compare two nil values
[string "@BetterBags/util/sort.lua"]:75: in function <BetterBags/util/sort.lua:72>
[string "=[C]"]: in function sort' [string "@BetterBags/frames/grid.lua"]:126: in function Sort'
[string "@BetterBags/frames/section.lua"]:116: in function <BetterBags/frames/section.lua:115>
[string "=(tail call)"]: ?
[string "@BetterBags/views/gridview.lua"]:142: in function GridView' [string "@BetterBags/frames/bag.lua"]:184: in function Draw'
[string "@BetterBags/core/init.lua"]:111: in function cb' [string "@BetterBags/core/events.lua"]:41: in function <BetterBags/core/events.lua:36> [string "=[C]"]: ? [string "@TomTom/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...Tom/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@TomTom/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function SendMessage'
[string "@BetterBags/core/events.lua"]:94: in function SendMessage' [string "@BetterBags/data/items.lua"]:132: in function <BetterBags/data/items.lua:126> [string "=[C]"]: in function xpcall'
[string "@FrameXML/ObjectAPI/ContinuableContainer.lua"]:83: in function CheckIfSatisfied' [string "@FrameXML/ObjectAPI/ContinuableContainer.lua"]:33: in function <..FrameXML/ObjectAPI/ContinuableContainer.lua:31> [string "=[C]"]: in function xpcall'
[string "@FrameXML/ObjectAPI/AsyncCallbackSystem.lua"]:76: in function `FireCallbacks'
[string "@FrameXML/ObjectAPI/AsyncCallbackSystem.lua"]:35: in function <FrameXML/ObjectAPI/AsyncCallbackSystem.lua:31>

Locals:
a =

{
NormalTexture = BetterBagsItemButton21NormalTexture {
}
Stock = BetterBagsItemButton21Stock {
}
data =
{
}
masqueGroup = "Backpack"
kind = 0
ilvlText = FontString {
}
Count = BetterBagsItemButton21Count {
}
button = BetterBagsItemButton21 {
}
IconQuestTexture = BetterBagsItemButton21IconQuestTexture {
}
frame = Frame {
}
Cooldown = BetterBagsItemButton21Cooldown {
}
IconTexture = BetterBagsItemButton21IconTexture {
}
}
b =
{
NormalTexture = BetterBagsItemButton23NormalTexture {
}
Stock = BetterBagsItemButton23Stock {
}
data =
{
}
masqueGroup = "Backpack"
kind = 0
ilvlText = FontString {
}
Count = BetterBagsItemButton23Count {
}
button = BetterBagsItemButton23 {
}
IconQuestTexture = BetterBagsItemButton23IconQuestTexture {
}
frame = Frame {
}
Cooldown = BetterBagsItemButton23Cooldown {
}
IconTexture = BetterBagsItemButton23IconTexture {
}
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to compare two nil values"

2nd:1x BetterBags/views/gridview.lua:77: attempt to index local 'oldSection' (a nil value)
[string "@BetterBags/views/gridview.lua"]:77: in function GridView' [string "@BetterBags/frames/bag.lua"]:184: in function Draw'
[string "@BetterBags/core/init.lua"]:111: in function cb' [string "@BetterBags/core/events.lua"]:41: in function <BetterBags/core/events.lua:36> [string "=[C]"]: ? [string "@TomTom/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...Tom/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@TomTom/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function SendMessage'
[string "@BetterBags/core/events.lua"]:94: in function SendMessage' [string "@BetterBags/data/items.lua"]:132: in function <BetterBags/data/items.lua:126> [string "=[C]"]: in function xpcall'
[string "@FrameXML/ObjectAPI/ContinuableContainer.lua"]:83: in function <..FrameXML/ObjectAPI/ContinuableContainer.lua:75>
[string "=(tail call)"]: ?
[string "@BetterBags/data/items.lua"]:126: in function ProcessContainer' [string "@BetterBags/data/items.lua"]:120: in function RefreshBackpack'
[string "@BetterBags/data/items.lua"]:64: in function RefreshAll' [string "@BetterBags/data/items.lua"]:48: in function cb'
[string "@BetterBags/core/events.lua"]:81: in function <BetterBags/core/events.lua:76>

Locals:
self =

{
SetDefaultModuleLibraries = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:363
Enable = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:290
NewModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:231
EnableModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:328
modules =
{
}
GetModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:206
IterateEmbeds = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:438
IsModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:213
defaultModuleLibraries =
{
}
baseName = "BetterBags"
ListView = defined @BetterBags/views/listview.lua:43
SetEnabledState = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:420
UpdateListSize = defined @BetterBags/views/listview.lua:27
enabledState = false
OneBagView = defined @BetterBags/views/oneview.lua:23
SetDefaultModuleState = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:383
moduleName = "Views"
GetName = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:275
defaultModuleState = true
Disable = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:310
IterateModules = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:433
name = "BetterBags_Views"
SetDefaultModulePrototype = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:405
IsEnabled = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:447
orderedModules =
{
}
GridView = defined @BetterBags/views/gridview.lua:23
DisableModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:346
}
bag =
{
itemsByBagAndSlot =
{
}
sections =
{
}
isReagentBank = false
kind = 0
recentItems =
{
}
slots =
{
}
freeSlots =
{
}
freeReagentBagSlotsButton =
{
}
moneyFrame =
{
}
bottomBar = Frame {
}
freeBagSlotsButton =
{
}
frame = BetterBagsBagBackpack {
}
content =
{
}
resizeHandle = Button {
}
}
dirtyItems =
{
1 =
{
}
2 =
{
}
3 =
{
}
4 =
{
}
5 =
{
}
6 =
{
}
7 =
{
}
8 =
{
}
9 =
{
}
10 =
{
}
11 =
{
}
12 =
{
}
13 =
{
}
14 =
{
}
15 =
{
}
16 =
{
}
17 =
{
}
18 =
{
}
19 =
{
}
20 =
{
}
21 =
{
}
22 =
{
}
23 =
{
}
24 =
{
}
25 =
{
}
26 =
{
}
27 =
{
}
28 =
{
}
29 =
{
}
30 =
{
}
31 =
{
}
32 =
{
}
33 =
{
}
34 =
{
}
35 =
{
}
36 =
{
}
37 =
{
}
38 =
{
}
39 =
{
}
40 =
{
}
41 =
{
}
42 =
{
}
43 =
{
}
44 =
{
}
45 =
{
}
46 =
{
}
47 =
{
}
48 =
{
}
49 =
{
}
50 =
{
}
51 =
{
}
52 =
{
}
53 =
{
}
54 =
{
}
55 =
{
}
56 =
{
}
57 =
{
}
58 =
{
}
59 =
{
}
60 =
{
}
61 =
{
}
62 =
{
}
63 =
{
}
64 =
{
}
65 =
{
}
66 =
{
}
67 =
{
}
68 =
{
}
69 =
{
}
70 =
{
}
71 =
{
}
72 =
{
}
73 =
{
}
74 =
{
}
75 =
{
}
76 =
{
}
77 =
{
}
78 = <table

3rd:1x BetterBags/views/gridview.lua:95: attempt to index local 'oldSection' (a nil value)
[string "@BetterBags/views/gridview.lua"]:95: in function GridView' [string "@BetterBags/frames/bag.lua"]:184: in function Draw'
[string "@BetterBags/core/init.lua"]:111: in function cb' [string "@BetterBags/core/events.lua"]:41: in function <BetterBags/core/events.lua:36> [string "=[C]"]: ? [string "@TomTom/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...Tom/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@TomTom/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function SendMessage'
[string "@BetterBags/core/events.lua"]:94: in function SendMessage' [string "@BetterBags/data/items.lua"]:132: in function <BetterBags/data/items.lua:126> [string "=[C]"]: in function xpcall'
[string "@FrameXML/ObjectAPI/ContinuableContainer.lua"]:83: in function <..FrameXML/ObjectAPI/ContinuableContainer.lua:75>
[string "=(tail call)"]: ?
[string "@BetterBags/data/items.lua"]:126: in function ProcessContainer' [string "@BetterBags/data/items.lua"]:120: in function RefreshBackpack'
[string "@BetterBags/data/items.lua"]:64: in function RefreshAll' [string "@BetterBags/data/items.lua"]:48: in function cb'
[string "@BetterBags/core/events.lua"]:81: in function <BetterBags/core/events.lua:76>

Locals:
self =

{
SetDefaultModuleLibraries = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:363
Enable = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:290
NewModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:231
EnableModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:328
modules =
{
}
GetModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:206
IterateEmbeds = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:438
IsModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:213
defaultModuleLibraries =
{
}
baseName = "BetterBags"
ListView = defined @BetterBags/views/listview.lua:43
SetEnabledState = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:420
UpdateListSize = defined @BetterBags/views/listview.lua:27
enabledState = false
OneBagView = defined @BetterBags/views/oneview.lua:23
SetDefaultModuleState = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:383
moduleName = "Views"
GetName = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:275
defaultModuleState = true
Disable = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:310
IterateModules = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:433
name = "BetterBags_Views"
SetDefaultModulePrototype = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:405
IsEnabled = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:447
orderedModules =
{
}
GridView = defined @BetterBags/views/gridview.lua:23
DisableModule = defined @!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:346
}
bag =
{
itemsByBagAndSlot =
{
}
sections =
{
}
isReagentBank = false
kind = 0
recentItems =
{
}
slots =
{
}
freeSlots =
{
}
freeReagentBagSlotsButton =
{
}
moneyFrame =
{
}
bottomBar = Frame {
}
freeBagSlotsButton =
{
}
frame = BetterBagsBagBackpack {
}
content =
{
}
resizeHandle = Button {
}
}
dirtyItems =
{
1 =
{
}
2 =
{
}
3 =
{
}
4 =
{
}
5 =
{
}
6 =
{
}
7 =
{
}
8 =
{
}
9 =
{
}
10 =
{
}
11 =
{
}
12 =
{
}
13 =
{
}
14 =
{
}
15 =
{
}
16 =
{
}
17 =
{
}
18 =
{
}
19 =
{
}
20 =
{
}
21 =
{
}
22 =
{
}
23 =
{
}
24 =
{
}
25 =
{
}
26 =
{
}
27 =
{
}
28 =
{
}
29 =
{
}
30 =
{
}
31 =
{
}
32 =
{
}
33 =
{
}
34 =
{
}
35 =
{
}
36 =
{
}
37 =
{
}
38 =
{
}
39 =
{
}
40 =
{
}
41 =
{
}
42 =
{
}
43 =
{
}
44 =
{
}
45 =
{
}
46 =
{
}
47 =
{
}
48 =
{
}
49 =
{
}
50 =
{
}
51 =
{
}
52 =
{
}
53 =
{
}
54 =
{
}
55 =
{
}
56 =
{
}
57 =
{
}
58 =
{
}
59 =
{
}
60 =
{
}
61 =
{
}
62 =
{
}
63 =
{
}
64 =
{
}
65 =
{
}
66 =
{
}
67 =
{
}
68 =
{
}
69 =
{
}
70 =
{
}
71 =
{
}
72 =
{
}
73 =
{
}
74 =
{
}
75 =
{
}
76 =
{
}
77 =
{
}
78 = <table

commented

Technically, I broke everything, not you :p

Pushing a fix for the sorting now -- but did this all happen back to back?

commented

Alright they were probably related then. I'm closing this, as I did push a fix. If you see it again, please feel free to re-open this bug.

Thanks!

commented

yeah all three errors popped at the same time so I guess the second two could have been caused by the first one but figured you might want to see all three