ElvUI Issue (Similar to 251)

Question

ElvUI Issue (Similar to 251)

NZephyr opened this issue 3 years ago · 15 comments

NZephyr commented 3 years ago

The visual conflict shown in closed issue #251 is still occurring on the Appearances tab (the Dressing Room issue is resolved) when using ElvUI. This didn't occur on a previous version of BetterWardrobe, but I cannot recall what version, and I haven't been able to find it in my saved files.

The image in issue #251 is exactly like what it looks like to me, so I haven't reuploaded another image.

Please let me know if you need any information, or if there's a log somewhere I can get you (not sure what you'd need!).

Tiburan · Answer 1 · 2022-04-30T07:10:17.000Z

I can confirm this, however in my case it can be resolved by disabling Arkinventory, Rarity and Soulshape journal.
I have no idea if these are any AddOns you use as well?

NZephyr · Answer 2 · 2022-04-30T14:26:59.000Z

I do use Rarity, and disabling it does seem to improve this. The color picker seems to still be misaligned. I will get screenshots later tonight to better compare. It could also be intended to look like that (the Rarity-disabled look).

Beet4 · Answer 3 · 2022-08-21T21:01:40.000Z

@Tiburan

ElvUI + Better Wardrobe Only:

ElvUI + Better Wardrobe + ArkInventory (no other addons enabled):

Confirms the issue also effects the combination ElvUI + Better Wardrobe + ArkInventory.

Tiburan · Answer 4 · 2022-08-22T06:16:07.000Z

@Beet4

Thank you very much for taking the time / effort to test and confirm.

Beet4 · Answer 5 · 2022-08-20T21:19:09.000Z

I can confirm that there seems to be a compatibility issue between the ElvUI Skin of Better Wardrobe and Rarity.

This is how Better Wardrobe looks with no addons enabled except itself:

With ElvUI Enabled, seems pretty much OK except for misaligned dropdown menu for sorting order and select color wheel:

And this is how it looks when I enable Rarity addon, this seems to break the ElvUI skin integration completely (and even more misaligntment):

It breaks on all tabs of Better Wardobe:

Transmog window as well:

@SLOKnightfall would you mind taking a look why the ElvUI integration breaks in combination with Rarity whenever you have time? Thanks! :)

Tiburan · Answer 6 · 2022-08-21T06:14:35.000Z

@Beet4

Could you do me a favor, could you please check if you get the same outcome with Arkinventory? Just want to be sure it is not a corrupted saved_variable on my end. (even though I removed the WTF folder and tried fresh copies of everything)
I would just be nice if there was another case but mine.
To be clear, ElvUI, Better Wardrobe and Arkinventory.

Thank you in advance.

ellaerror · Answer 7 · 2022-10-09T01:03:39.000Z

Hi, I found a solution to this issue. In Plugins/ElvUI.lua of BetterWardrobe there's this code on line 505:

if not IsAddOnLoaded("Blizzard_Collections") then
	LoadAddOn("Blizzard_Collections")
	C_Timer.After(2, UpdateCollectionFrames)

end

By changing the code to this:

if not IsAddOnLoaded("Blizzard_Collections") then
	LoadAddOn("Blizzard_Collections")
		
end
		
C_Timer.After(2, UpdateCollectionFrames)

the issue no longer happens, at least for me. I believe this is because rarity gets loaded first and they also load the addon "Blizzard_Collections" (Rarity/Core/Collections.lua). By doing this, the function IsAddOnLoaded("Blizzard_Collections") returns true, which causes the UpdateCollectionFrames to never be called. I hope this helps.

commented this on the wrong issue at first, lol

Beet4 · Answer 8 · 2022-10-10T13:58:24.000Z

Great! Hope this can be implemented in a future release then. :)

NZephyr · Answer 9 · 2022-10-28T04:43:04.000Z

Thank you for the info! Sorry I didn't comment beforehand, I'd kinda forgotten I'd posted this until Monday, and basically decided that 10.0.0 would break things anyway, which it did, ha! After the current issue I recently posted is resolved to allow it, I'll check to see if this solution still works for me!

SLOKnightfall · Answer 10 · 2022-10-28T16:56:32.000Z

The fix has been added to the 4.1.1 release. Thanks for finding the solution and for taking so long to implement.

Beet4 · Answer 11 · 2022-10-28T20:27:28.000Z

So the fix in 4.1.1 worked for a bit but it randomly stopped working again? With the following LUA Error:

3x Interface/AddOns/BetterWardrobe/Plugins/ElvUI.lua:120: attempt to index local 'WardrobeCollectionFrame' (a nil value)
[string "@Interface/AddOns/BetterWardrobe/Plugins/ElvUI.lua"]:120: in function <Interface/AddOns/BetterWardrobe/Plugins/ElvUI.lua:117>

Locals:
WardrobeCollectionFrame = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = <table> {
 L_UIDropDownMenuSkinned = true
 Blizzard_Channels = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/Channels.lua:7
 TalkingHead = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/TalkingHead.lua:110
 HandleFrame = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:129
 ArrowRotation = <table> {
 }
 HandleNextPrevButton = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:1054
 modules = <table> {
 }
 CancelTimer = <function> defined @Interface/AddOns/ElvUI/Libraries/Core/Ace/AceTimer-3.0/AceTimer-3.0.lua:147
 QuestFrameProgressItems_Update = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/Quest.lua:337
 GuildInviteFrame = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/Guild.lua:217
 MirrorTimers = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/MirrorTimers.lua:6
 Ace3_ColorizeEnable = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Ace3.lua:512
 AlertSystem = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/Alerts.lua:787
 HandleIcon = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:992
 Blizzard_WeeklyRewards = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/WeeklyRewards.lua:65
 SetDisabledBackdrop = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:234
 HandleCategoriesButtons = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:76
 Blizzard_PlayerChoice = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/PlayerChoice.lua:107
 ADDON_LOADED = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:1748
 HandleSliderFrame = <function> defined =[C]:-1
 SkinTalentListButtons = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:360
 HandleEditBox = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:794
 TutorialFrame = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/TutorialFrame.lua:6
 db = <table> {
 }
 SetEnabledState = <function> defined @Interface/AddOns/!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:420
 Hook = <function> defined @Interface/AddOns/ElvUI/Libraries/Core/Ace/AceHook-3.0/AceHook-3.0.lua:273
 RegisterSkin = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:1783
 DressUpFrame = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/DressingRoom.lua:49
 Blizzard_AnimaDiversionUI = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/AnimaDiversion.lua:6
 HandleFollowerListOnUpdateDataFunc = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:1362
 SkinDoubleStateIconRow = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:1702
 HandleTrimScrollBar = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:634
 SkinWidgetContainer = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:1741
 HandleCheckBox = <function> defined =[C]:-1
 UnregisterAllEvents = <function> defined @Interface/AddOns/TomTom/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:169
 Blizzard_ItemInteractionUI = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/ItemInteraction.lua:6
 ScriptErrorsFrame = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/Debug.lua:86
 Blizzard_Calendar = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/Calendar.lua:44
 SkinCaptureZone = <function> defined @Interface/AddOns/ElvUI/Core/Modules/Skins/Skins.lua:1711
 EarlyAceWidgets = <table> {
 }
 Blizzard_DebugTools = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/Debug.lua:92
 QuestFrame_SetTitleTextColor = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/Quest.lua:342
 name = "ElvUI_Skins"
 Blizzard_CovenantSanctum = <function> defined @Interface/AddOns/ElvUI/Mainline/Modules/Skins/CovenantSanctum.lua:50
 SkinIconTextAnd

Beet4 · Answer 12 · 2022-10-28T20:33:19.000Z

Seems like it only happens on initially loading into the game after booting it up. If you do a /reload there is no LUA error and the skin works.

SLOKnightfall · Answer 13 · 2022-10-28T20:34:56.000Z

Thanks. I'll look into it

Beet4 · Answer 14 · 2022-10-29T10:23:52.000Z

So skin seems to be at least loading now even with Rarity enabled which just got an update for 10.0 so that is good. However there are some new visual bugs, I'll post them in this issue as it's probably ElvUI related.

Dropdown in the transmogrify window is sometimes very wide:

When it's not save button seems to overlap with the buttons a bit:

The last Saved sets button overlaps with the progress bar in the transmogrify window:

As well on the appearance tab:

This one is really weird in the appearance window, happens more often than not. If it happens it seems to happen every time I open the window in the same session, a reload might help:

Fullscreen screenshot of the transmogrify just for the sake of it:

Fullscreen screenshot of the appearance window just for the sake of it:

Really appreciate the hard work you are doing with the awesome addon <3

SLOKnightfall · Answer 15 · 2022-11-05T19:47:04.000Z

The next update has the elvui skin reworked and should fix this

Share to