Better Wardrobe and Transmog

Better Wardrobe and Transmog

6M Downloads

Collecting a new appearance in combat triggers an `ADDON_ACTION_BLOCKED` error

Ghostopheles opened this issue ยท 0 comments

commented

Calling CollectionsJournal_SetTab while in combat eventually triggers a call to MountJournal:SetShown() which is protected while in combat. The actual underlying cause is that the CollectionsJournal_UpdateSelectedTab function reads the tainted selectedTab value and fails when it tries to call the MountJournal:SetShown() function.

The error:

2x [ADDON_ACTION_BLOCKED] AddOn 'BetterWardrobe' tried to call the protected function 'MountJournal:SetShown()'.
[string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480>
[string "=[C]"]: in function `SetShown'
[string "@Blizzard_Collections/Blizzard_Collections.lua"]:62: in function <Blizzard_Collections/Blizzard_Collections.lua:54>
[string "=[C]"]: in function `CollectionsJournal_UpdateSelectedTab'
[string "@Blizzard_Collections/Blizzard_Collections.lua"]:6: in function `CollectionsJournal_SetTab'
[string "@BetterWardrobe/Modules/Wardrobe.lua"]:1886: in function <BetterWardrobe/Modules/Wardrobe.lua:1886>
[string "=[C]"]: in function `securecall'
[string "@BetterWardrobe/Modules/Wardrobe.lua"]:1886: in function `CheckLatestAppearance'
[string "@BetterWardrobe/Modules/Wardrobe.lua"]:1868: in function <BetterWardrobe/Modules/Wardrobe.lua:1851>

I usually encounter this when looting a boss quickly after it dies, because occasionally you can still be in combat after the boss dies for various reasons.

Recommended fix is to simply wait until the player leaves combat to change the collections journal tab, though there's definitely some room here to blame Blizzard's implementation of the entire Collections UI.

Related:
#367
#359
#347