"Attempted to add item to category %s, but the item ID is nil." at login

Question

"Attempted to add item to category %s, but the item ID is nil." at login

lorenzo-costigliola opened this issue 7 months ago · 11 comments

lorenzo-costigliola commented 7 months ago

Describe the bug
At login the following in game Lua error appears

Message: Interface/AddOns/BetterBags/data/categories.lua:52: bad argument #2 to 'format' (string expected, got nil)
Time: Mon Mar 4 08:54:47 2024
Count: 1
Stack: Interface/AddOns/BetterBags/data/categories.lua:52: bad argument #2 to 'format' (string expected, got nil)
[string "=[C]"]: in function format' [string "@Interface/AddOns/BetterBags/data/categories.lua"]:52: in function AddItemToCategory'
[string "@Interface/AddOns/BetterBags_Secrets/Core.lua"]:36: in main chunk

Locals: (*temporary) = "Attempted to add item to category %s, but the item ID is nil."
(*temporary) = nil
(*temporary) = "string expected, got nil"

To Reproduce
Just log in into the game

Retail 10.2.5.53441
0.1.14
1.03
Above

Expected behavior
No getting the login Lua error

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
The problem happens on 7 different characters always at login and/or reload (never at other times).
I'm playing on Nemesis (EU-IT). Not sure if there might be some translation issues

Myrroddin · Answer 1 · 2024-03-06T05:16:00.000Z

It might be a translation issue. I will look into it. You are playing with Italian as your language?

Myrroddin · Answer 2 · 2024-03-06T06:02:47.000Z

See if 1.04 fixes the issue. If you wish to help even more, please contribute translations.

lorenzo-costigliola · Answer 3 · 2024-03-08T10:22:46.000Z

Yes I’m playing on an Italian server. I thought category had an id independent from the language (as items, spells, zones and so on). I think most of the game is done as reference id (a number same for all) and some sort of dictionary for the different languages. I still need to look if it’s fixed because I’m playing from a different setup these days, I’ll check during the weekend. Thanks for doing this Lorenzo Costigliola, Ph.D. Roskilde University Department of Science and Environment, building 27.2 Universitetsvej 1, P.O. Box 260 DK-4000 Roskilde, Denmark http://www.ruc.dk Office Building 27, 2nd floor, (27.2-084) Direct +45 31793735 <%2B45%204074%201478> Mail ***@***.*** Il giorno mer 6 mar 2024 alle 05:16 Myrroddin ***@***.***> ha scritto:

…

It might be a translation issue. I will look into it. You are playing with Italian as your language? — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZIQEWRUY5UBWBNF7GV3Z5LYW2RBZAVCNFSM6AAAAABEEYCZNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBQGEYDGNBYGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Myrroddin · Answer 4 · 2024-03-08T09:08:35.000Z

I learned that GetFactionInfoByID() does not work if the player's base faction (Alliance or Horde) can never learn the faction I want, or Honeyback Hive, in this case. Horde characters will get an error.

Myrroddin · Answer 5 · 2024-03-08T11:12:41.000Z

I switched to an internal localization of "Honeyback Hive" rather than using WoW to translate it. I never got the error myself because I play Alliance, and the "Honeyback Hive" reputation is valid for Alliance. I had to create a Horde character to see the error.

The error should finally be fixed with 1.05. I created a Horde character to test. While I translated "Honeyback Hive" online, I did so after 1.05 was released. Whenever 1.06 goes live, you will see it localized within the addon.

lorenzo-costigliola · Answer 6 · 2024-03-11T00:37:15.000Z

Lorenzo Costigliola, Ph.D. Roskilde University Department of Science and Environment, building 27.2 Universitetsvej 1, P.O. Box 260 DK-4000 Roskilde, Denmark http://www.ruc.dk Office Building 27, 2nd floor, (27.2-084) Direct +45 31793735 <%2B45%204074%201478> Mail ***@***.*** Dear Myrroddin, I just got the same error again after installing the addon Premade group finder (which should not conflict being related to the group finder). The error disappears after removing the addon (which is widely used so it’s a quite big problem). I’m not sure if the problem is only on the Italian client but at this point I’m not sure it’s really that. Il giorno dom 10 mar 2024 alle 18:42 Myrroddin ***@***.***> ha scritto:

…

Closed #1 <#1> as completed. — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZIQEWS7AYIAGREOQB7CUVLYXSZRZAVCNFSM6AAAAABEEYCZNOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGA3DMMJQGY3TGNY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Myrroddin · Answer 7 · 2024-03-11T21:27:16.000Z

I do not think it is because you are playing on an Italian server. There must be something else going on.

Myrroddin · Answer 8 · 2024-03-12T02:22:37.000Z

I confirmed it has nothing to do with your language; it is because you are playing a Horde character, and the "Honeyback Hive" faction does not exist for Horde. I worked around that by directly localizing "Honeyback Hive" instead of having WoW localize the term, which will be nil for Horde characters if I get WoW to localize it.

That workaround was in 1.05, and when I logged into a Horde character, the error stopped. I have not been able to replicate the error since 1.05 on either Alliance or Horde.

What you may need to do is exit WoW then browse your computer to \World of Warcraft\_retail_\WTF\account\Your Account Name\SavedVariables\ and delete BetterBags.lua. Deleting that file will reset BetterBags and its settings back to default.

The only other thing I can do is check if the player is Alliance. If yes, create the virtual group in BetterBags. If no, the player is Horde, then delete the group, or at least do not create it.

Myrroddin · Answer 9 · 2024-03-12T02:26:01.000Z

The issue with not creating the "Honeyback Hive" group if the player is Horde is that should the player log into an Alliance character, the group will be created for BOTH factions. Because of how BetterBags works, I cannot stop the creation based on the player's faction permanently.

Myrroddin · Answer 10 · 2024-03-12T02:34:30.000Z

What I mean by that is that I can perform a logic check "if player == 'Alliance' then create group, elseif player == 'Horde' then delete group", but that will error because the group is created for Horde in the first place. There is no way to stop the creation.

The group needs to exist (IE: be created) to delete it, and merely creating the group will error for Horde.

What I have done as of 1.05 is the best possible solution: do not use WoW to translate "Honeyback Hive" and translate "Honeyback Hive" internally to Secrets.

But like I said above, if you are still getting the error with 1.05, 1.06, 1.07 or later, you probably need to delete the settings file for BetterBags. Something in its settings is being kept that is causing the error. Starting fresh will reset and avoid the error.

lorenzo-costigliola · Answer 11 · 2024-03-15T02:58:55.000Z

Hi! I have been playing with the Betterbags and the other addon which gave the issue before and had no problems in the last days. I think you fixed it! Thanks! Lorenzo Costigliola, Ph.D. Roskilde University Department of Science and Environment, building 27.2 Universitetsvej 1, P.O. Box 260 DK-4000 Roskilde, Denmark http://www.ruc.dk Office Building 27, 2nd floor, (27.2-084) Direct +45 31793735 <%2B45%204074%201478> Mail ***@***.*** Il giorno mar 12 mar 2024 alle 02:34 Myrroddin ***@***.***> ha scritto:

…

What I mean by that is that I can perform a logic check "if player == 'Alliance' then create group, elseif player == 'Horde' then delete group", but that will error because the group is created for Horde in the first place. There is no way to stop the creation. The group needs to exist (IE: be created) to delete it, and merely creating the group will error for Horde. What I have done as of 1.05 is the best possible solution: do not use WoW to translate "Honeyback Hive" and translate "Honeyback Hive" internally to Secrets. But like I said above, if you are still getting the error with 1.05, 1.06, 1.07 or later, you probably need to delete the settings file for BetterBags. Something in its settings is being kept that is causing the error. Starting fresh will reset and avoid the error. — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZIQEWQJSKM2TDQVF2XAYRDYXZZVXAVCNFSM6AAAAABEEYCZNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZHA3TGMJTGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Share to