BigDebuffs

BigDebuffs

18M Downloads

TidyPlates nameplates compatibility issue

jsmenzies opened this issue ยท 1 comments

commented

Hi there,

I took a look through the LUA and can see some support for various different nameplate addons but non for Tidyplates. I have tried to get it working but unfortunately know nothing about Wow addon development. Would it be possible to add the TidyPlates compatibility in addition to the other 4 addons you support.

Thanks in advance,

commented

I'm no LUA wizard but thought I'd give it a look, turns out its already updated for TidyPlates but under its old name NeatPlates i just changed the few lines of code to tidy plates and bobs your uncle it worked. IDK how far this will go in terms of bigdebuffs settings adjustments but it works okay for me so far.
Ln: 324
TidyPlates = function(frame)
if frame.carrier and frame.extended and frame.extended.bars and frame.carrier:IsShown() then
return frame.extended.bars.healthbar, frame.extended
I just changed the function name to TidyPlates I don't believe this is necessary as this "func = GetNameplateAnchor.TidyPlates," line of code just seems to use it as a type of locator to grab the code so as long as the names match it should work the next bit is the main issue I assume.
Ln: 380
the original code was:
[4] = {
used = function()
return NeatPlates ~= nil --or TidyPlates ~= nil -- Should be the same but haven't confirmed
end,
func = GetNameplateAnchor.NeatPlates,
Adjustment:
[4] = {
used = function()
return TidyPlates ~= nil -- Should be the same but haven't confirmed
end,
func = GetNameplateAnchor.TidyPlates,
I've never really wrote actual code so I unfortunately can't explain why, with 100% confidence, but it does work so don't look the gift horse in the mouth and thanks to whoever originally wrote the BigDebuffs addon they did get half way to making tidyplates work also thanks to #103 Backupiseasy who's post made me feel smarter enough to made me even take a look at the code.