Icons staying visible after PvP Combat
LewisFarrellDev opened this issue ยท 5 comments
Hello, it seems anytime i engage in PvP combat whether it be WarMode, Battlegrounds, arena etc. Icons seem to stay visible and i have to either /reloadui or disable/enable the addon. Additionally, it seems that even though i have Friendly/NPC Nameplate disables, the icons still show up on them after PvP.
See on the first screenshot that the friendly NPC has the icon, even though Friendly/NPC namesplates option is disabled
Potentially related to: #234
I've made a change in my fork (https://github.com/domzae/bigdebuffs/commit/fixstuckicons) that might fix this - if you (or anyone) can try it out and confirm this works, I'll open a pull request for it!
@domzae After spamming arena for about 2 hours, i havn't seen any icons getting stuck on nameplates. Looks like this bandaid worked
@domzae I've been using your fork for a couple of days and I haven't had any more issues with icons getting stuck. I think it would be worth it to do a PR for this.
Thanks @edumserrano (& LewisFarrellDev), glad to hear! I opened a pull request a couple days ago, just waiting for Jordon to review it :)
Anyone else still seeing this even with newer versions that have PR #248 - I'm running v10.0 and still encounter this on occasion. Seems to occur if the buff/debuff was present on the party member at the time an arena match ended. Perhaps the addon should just recheck buffs/debuffs if the zone/instance has changed?