BlizzHUDTweaks

BlizzHUDTweaks

155k Downloads

[BUG] LibDBIcon path wrong or missing

Hayato2846 opened this issue ยท 13 comments

commented

Description

2x BlizzHUDTweaks/BlizzHUDTweaks.toc:24 Couldn't open BlizzHUDTweaks/Libs/LibDBIcon/LibDBIcon-1.0-52/lib.xml

Reproduce

What steps are needed to reproduce it?
image

Expected Behaviour

Guess it's just an oversight of updating the library

Optional Context (e.g. Screenshots)

Cheers (:

commented

Do you have any other addon which includes LibDBIcon?

I checked it on my local machine and do not have this behaviour. Nor do i have set the path to BlizzHUDTweaks/Libs/LibDBIcon/LibDBIcon-1.0-52/lib.xml.

commented

With only BlizzHUDTweaks enabled (beside BugGrabber and BugSack) I still get following two errors. But BugSack is indeed using LibDBIcon.

But I checked both toc files and they're set properly for me (like the toc path does not reference to LibDBIcon-1.0-52). Updated via WowUp / CurseForge.

I added my current version as a zip.
BlizzHUDTweaks.zip

1x BlizzHUDTweaks/BlizzHUDTweaks.lua:14: Cannot find a library instance of "LibDBIcon-1.0".
[string "=[C]"]: in function `error'
[string "@BlizzHUDTweaks/Libs/LibStub/LibStub.lua"]:38: in function `LibStub'
[string "@BlizzHUDTweaks/BlizzHUDTweaks.lua"]:14: in main chunk

Locals:
(*temporary) = "Cannot find a library instance of "LibDBIcon-1.0"."

2x BlizzHUDTweaks/BlizzHUDTweaks.toc:24 Couldn't open BlizzHUDTweaks/Libs/LibDBIcon/LibDBIcon-1.0-52/lib.xml

commented

I'm getting the same issue as Hayato, only Blizzhudtweaks is enabled and I'm seeing the same error. The addon isn't working and there's nothing in the addons section of options/no minimap icon.

commented

Currently I'm a bit confused, because the package that is available on Github as a release looks okay and should be 1:1 the same as what I use locally for testing.
I'll download the package later via CurseForge and see if I have the same problem. Alternatively, I'll roll back the version of LibDBIcon for now.

commented

๐Ÿคฆ I think i found the problem... Since i updated the library i changed the path pointing to the lib.xml... In my local env it is fine and correct because the folder structure changed.

For the build package you guys download it is not since the libraries are loaded on build time and package differently to my local machine. So for the github build the paths do not match....

Sry :D

commented

local LibDBIcon = LibStub("LibDBIcon-1.0") should be the correct way to load the library. The minor version should be irrelevant when loading the library. Some errors mention the minor version when trying to load the library. This is something strange I don't really understand.

For now, I'll just roll back the change so that the addon will work for now, since the change was made because I thought some problem was coming from the library. As it turned out, the problem was just a deprecated wow ui function. So I think I can fix the problem without having to update the lib.

commented

I have 1.45.1 version (I have updated the addon with WowUp.io (CurseForge) and I get the same error as above (13x BlizzHUDTweaks/BlizzHUDTweaks.toc:24 Couldn't open BlizzHUDTweaks/Libs/LibDBIcon/LibDBIcon-1.0-52/lib.xml ) BlizzHUDTweaks seems to work fine btw.

So the addon still works fine even though you get the error? Do you still have a minimap icon?

commented

I have 1.45.1 version (I have updated the addon with WowUp.io (CurseForge) and I get the same error as above (13x BlizzHUDTweaks/BlizzHUDTweaks.toc:24 Couldn't open BlizzHUDTweaks/Libs/LibDBIcon/LibDBIcon-1.0-52/lib.xml )
BlizzHUDTweaks seems to work fine btw.

commented

@PhenomDevel One thing I noticed is that you changed the way you load LibDBIcon.

In 1.44.0

local LibDBIcon = LibStub:GetLibrary("LibDBIcon-1.0", true)

In 1.45.1

local LibDBIcon = LibStub("LibDBIcon-1.0")

52 is the minor version of LibDBIcon so I assume it tries to load it dynamically with its set minor version in mind in 1.45.1 caused by the other way to load a library via LibStub.

image

Cheers

commented

So the addon still works fine even though you get the error? Do you still have a minimap icon?

Yes, I have BlizzHudTweaks minimap icon and also I have BlizzHudTweaks icon in Titan Panel addon. The minimap icon was hidden so I used the command /bht minimap to show it again.

commented

@Arkewas @Hayato2846 @durrburger93 I created 1.45.2. Please check if this fixes the problem.

commented

With 1.45.2 I don't get the error anymore and BlizzHUDTweaks is working fine. I also have both minimap icon and Titan Panel icon. Thank you for fixing the issue.

commented

@PhenomDevel Sorry for the late answer. Yes it's fixed with 1.45.2 :) Thanks!