BonusRollPreview

BonusRollPreview

666k Downloads

MoveAnything Conflict

Uggers opened this issue ยท 9 comments

commented

What steps will reproduce the problem?

  1. When looting with Moveanything loaded
  2. MoveAnything is NOT moving this frame, i've reset it entirely it still occurs

What is the expected output? What do you see instead?
I get the below LUA error, IT worked prior when it was Habeebit

What version of the product are you using?
50400.17-Release
Latest MoveAnything - Not updated for a while though

Do you have an error log of what happened?

136x BonusRollPreview\BonusRollPreview-50400.17-Release.lua:92: attempt to perform arithmetic on a nil value
BonusRollPreview\BonusRollPreview-50400.17-Release.lua:92: in function <BonusRollPreview\BonusRollPreview.lua:91>
BonusRollPreview\BonusRollPreview-50400.17-Release.lua:128: in function <BonusRollPreview\BonusRollPreview.lua:127>
[C]: in function `SetPoint'
MoveAnything\Modules\Position.lua:53: in function <MoveAnything\Modules\Position.lua:20>
(tail call): ?
[C]: in function `xpcall'
MoveAnything\API.lua:267: in function `Apply'
MoveAnything\API.lua:247: in function <MoveAnything\API.lua:219>
(tail call): ?
[C]: ?
MoveAnything\MoveAnything-14.0.4.lua:1253: in function `SyncFrames'
MoveAnything\MoveAnything-14.0.4.lua:1224: in function `SyncAllFrames'
MoveAnything\MoveAnything-14.0.4.lua:5674: in function <MoveAnything\MoveAnything.lua:5304>

Locals:
PositionDownwards = <function> defined @BonusRollPreview\BonusRollPreview.lua:91
Container = BonusRollPreviewContainer {
 0 = <userdata>
 EJ_LOOT_DATA_RECIEVED = <function> defined @BonusRollPreview\BonusRollPreview.lua:308
 PLAYER_LOGIN = <function> defined @BonusRollPreview\BonusRollPreview.lua:343
 Update = <function> defined @BonusRollPreview\BonusRollPreview.lua:286
 Populate = <function> defined @BonusRollPreview\BonusRollPreview.lua:235
 SPELL_CONFIRMATION_TIMEOUT = <function> defined @BonusRollPreview\BonusRollPreview.lua:336
 Empty = <unnamed> {
 }
 ScrollChild = <unnamed> {
 }
 SPELL_CONFIRMATION_PROMPT = <function> defined @BonusRollPreview\BonusRollPreview.lua:321
 PLAYER_LOOT_SPEC_UPDATED = <function> defined @BonusRollPreview\BonusRollPreview.lua:316
 Slider = <unnamed> {
 }
}
Handle = BonusRollPreviewHandle {
 0 = <userdata>
 TopCenter = <unnamed> {
 }
 TopRight = <unnamed> {
 }
 Arrow = <unnamed> {
 }
 BottomLeft = <unnamed> {
 }
 BottomRight = <unnamed> {
 }
 BottomCenter = <unnamed> {
 }
 TopLeft = <unnamed> {
 }
}
HandleClick = <function> defined @BonusRollPreview\BonusRollPreview.lua:96
commented

Apologies thought I'd got back to you,
Still getting the issues it with just those 2, but it seems random, sometimes the first boss I kill no error, then it'll pop up. but its supressed by Bugsack so I only see the LDB of the error, the addon seems to function ok.

It does seem to be primarily moveanything even though its not meant to be moving that bar. thanks for looking into it for me, I appreciate it especially as its not your addon (moveanything)

commented

Try the latest version.

Although, if you do anything with the BonusRollFrame I won't guarantee it will work, and I probably won't support doing so neither.

commented

Just updated, will try tomorrow night at the raid and let you know

commented

Hey,

Seems to be working now although I do have a different lua error.

1x BonusRollPreview\BonusRollPreview-50400.18-Release.lua:97: attempt to perform arithmetic on a nil value
BonusRollPreview\BonusRollPreview-50400.18-Release.lua:97: in function <BonusRollPreview\BonusRollPreview.lua:96>
BonusRollPreview\BonusRollPreview-50400.18-Release.lua:134: in function <BonusRollPreview\BonusRollPreview.lua:132>
[C]: in function `SetPoint'
FrameXML\LootFrame.lua:351: in function `GroupLootContainer_Update'
FrameXML\LootFrame.lua:308: in function `GroupLootContainer_AddFrame'
FrameXML\LootFrame.lua:518: in function <FrameXML\LootFrame.lua:477>
[C]: ?
[C]: in function `BonusRollFrame_StartBonusRoll'
FrameXML\UIParent.lua:1053: in function <FrameXML\UIParent.lua:705>

Locals:
Container = BonusRollPreviewContainer {
 0 = <userdata>
 EJ_LOOT_DATA_RECIEVED = <function> defined @BonusRollPreview\BonusRollPreview.lua:315
 PLAYER_LOGIN = <function> defined @BonusRollPreview\BonusRollPreview.lua:350
 Update = <function> defined @BonusRollPreview\BonusRollPreview.lua:293
 Populate = <function> defined @BonusRollPreview\BonusRollPreview.lua:244
 SPELL_CONFIRMATION_TIMEOUT = <function> defined @BonusRollPreview\BonusRollPreview.lua:343
 Empty = <unnamed> {
 }
 ScrollChild = <unnamed> {
 }
 SPELL_CONFIRMATION_PROMPT = <function> defined @BonusRollPreview\BonusRollPreview.lua:328
 PLAYER_LOOT_SPEC_UPDATED = <function> defined @BonusRollPreview\BonusRollPreview.lua:323
 Slider = <unnamed> {
 }
}
PositionDownwards = <function> defined @BonusRollPreview\BonusRollPreview.lua:96
Handle = BonusRollPreviewHandle {
 0 = <userdata>
 TopCenter = <unnamed> {
 }
 TopRight = <unnamed> {
 }
 Arrow = <unnamed> {
 }
 BottomLeft = <unnamed> {
 }
 BottomRight = <unnamed> {
 }
 BottomCenter = <unnamed> {
 }
 TopLeft = <unnamed> {
 }
}
HandleClick = <function> defined @BonusRollPreview\BonusRollPreview.lua:101
commented

I'll take a look into how MoveAnything is changing the positions, but I won't promise anything.
If they do something really dodgy to force set the position there is nothing I can do to prevent that.

commented

It works well for me, both moved and not moved with MoveAnything (latest version on curse, v14.0.4).

Could you try running this macro for me after a fresh /reload?

/run local o,c,e=GetCurrencyInfo,BonusRollPreviewContainer,'SPELL_CONFIRMATION_PROMPT' GetCurrencyInfo=function(...) if ...==999999 then return nil,99,'null' else return o(...) end end UIParent_OnEvent(nil,e,148317,1,'',2000, 999999) c[e](c,nil,148317,1)

If you still get an error, give me a screenshot to show where you've placed the frame.

commented

Hiya,

I ran the macro, this is quick screenie of the error and location of hte frame, I've not actually used move anything to move it. its in its default setting.

commented

Try running only MoveAnything and BRP, I see you have more addons that attach to the BonusRollFrame that might be interfering.

If you don't get an error with only those two addons running, do the process of elimination by enabling every addon one by one until you hit the error again.

commented

@Uggers Waiting for your input