i have 2 sets that use the same 3 items yet are gemmed differently (3 items for dps 3 for tanking (frost resist gear))

looking at your code you only match items by itemID and not location.

there is a great writeup on how to use the values from GetEquipmentSetLocations here http://wowprogramming.com/docs/api_types#itemLocation

fef4570