Buffomat Classic

Buffomat Classic

331k Downloads

Event BAG_UPDATE_DELAYED is generated again

jdelvare opened this issue ยท 2 comments

commented

When Wrath 3.4.1 was released, event BAG_UPDATE_DELAYED was no longer generated, and we had to apply a workaround (tracking event BAG_UPDATE instead) to fix bug #113 and bug #114.

However, at some point, event BAG_UPDATE_DELAYED was silently added back to Wrath. Not sure in which build exactly, but at least build 49345 has it. So, not only tracking event BAG_UPDATE is no longer necessary, but it is also no longer desirable, because it causes Event_Bag() to be called twice whenever an item is added to or removed from a bag. And even 3 times when an item is moved from one bag to another. This causes a performance regression.

So we should stop listening to event BAG_UPDATE.

commented
commented

Even if i do not release or test for classic for several months now, the addon is mostly/fully compatible with classic.
I have no idea whether the same change was applied to classic so here is the fix:
77468c2