Cell

Cell

1M Downloads

This addon break LibGetFrame

mrbuds opened this issue ยท 5 comments

commented

Cell/Utils.lua

Line 2213 in 3900c74

function F:OverrideLGF(override)
replace LibGetFrame functions

If you want to improve LibGetFrame you are free to contribute, but replacing functions like this is not acceptable. This is forcing me to take steps to not let your code break mine.

commented

enderneko/LibGetFrame@6642d7b
@mrbuds how about this?
If it's okay, I'll do it in this way, then create a PR.

commented

05a26c3
removed.

commented

Okay, if you got mad with this, I can remove this.
But I don't get it, what do you mean by "break"?
If people use this addon (Cell), they want these WA showing on correct frames, right?
And this feature can be turned off in Cell options.

I understand it's free to contribute.
In my opinion this is an addon-specific feature, should not be added to that Lib which provides a generic solution.

I'll remove this, and find a way around.
Or I fork your lib and embed it into Cell. (And make my changes.)
way found

commented

Please show me the way.
I'm always prepared to listen.

commented

@mrbuds
Updated.
Will create a PR.