ChampionCommander

ChampionCommander

2M Downloads

Add on broke in 9.0.1

lovs2build opened this issue · 9 comments

commented

Can use view mission results but not quick and auto adding champions not working/loading.

commented

Hello, I also got lua errors caused by the new patch. I'm going to list the one I got for this addon but also got errors for order hall commander too. :) I hope this help. Thanks!!

2x ChampionCommander\cache.lua:716: Usage: GetCurrencyTypes(garrType)
[string "=[C]"]: in function GetCurrencyTypes' [string "@ChampionCommander\cache.lua"]:716: in function <ChampionCommander\cache.lua:714> [string "=(tail call)"]: ? [string "=[C]"]: ? [string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:65> [string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:498: in function InitializeAddon'
[string "@ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:623: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>
[string "=[C]"]: in function LoadAddOn' [string "@FrameXML\UIParent.lua"]:495: in function UIParentLoadAddOn'
[string "@FrameXML\UIParent.lua"]:685: in function Garrison_LoadUI' [string "@FrameXML\GarrisonBaseUtils.lua"]:369: in function ShowGarrisonLandingPage'
[string "@FrameXML\Minimap.lua"]:701: in function `GarrisonLandingPage_Toggle'
[string "@FrameXML\Minimap.lua"]:693: in function <FrameXML\Minimap.lua:692>

commented

I got the following error when opening the Missions from the mission table:

Message: ...ce\AddOns\ChampionCommander\libs\LibInit\factory.lua:278: attempt to call global 'MSA_DropDownMenu_Create' (a nil value)
Time: Thu Oct 15 12:48:58 2020
Count: 1
Stack: ...ce\AddOns\ChampionCommander\libs\LibInit\factory.lua:278: attempt to call global 'MSA_DropDownMenu_Create' (a nil value)
[string "=[C]"]: in function MSA_DropDownMenu_Create' [string "@Interface\AddOns\ChampionCommander\libs\LibInit\factory.lua"]:278: in function DropDown'
[string "@interface\AddOns\ChampionCommander\libs\LibInit\factory.lua"]:356: in function Option' [string "@Interface\AddOns\ChampionCommander\missionlist.lua"]:733: in function Menu'
[string "@interface\AddOns\ChampionCommander\missionlist.lua"]:796: in function <Interface\AddOns\ChampionCommander\missionlist.lua:791>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function Show' [string "@Interface\FrameXML\UIParent.lua"]:2893: in function SetUIPanel'
[string "@interface\FrameXML\UIParent.lua"]:2699: in function ShowUIPanel' [string "@Interface\FrameXML\UIParent.lua"]:2606: in function <Interface\FrameXML\UIParent.lua:2602> [string "=[C]"]: in function SetAttribute'
[string "@interface\FrameXML\UIParent.lua"]:3457: in function `ShowUIPanel'
[string "@interface\FrameXML\UIParent.lua"]:1945: in function <Interface\FrameXML\UIParent.lua:1258>

Locals:

commented

Get this error when viewing the Available Missions tab via the Missions minimap icon.

Message: ...ibInit\MSA-DropDownMenu-1.0\MSA-DropDownMenu-1.0.lua:212: attempt to call method 'SetBackdrop' (a nil value)
Time: Thu Oct 15 15:31:12 2020
Count: 1
Stack: ...ibInit\MSA-DropDownMenu-1.0\MSA-DropDownMenu-1.0.lua:212: attempt to call method 'SetBackdrop' (a nil value)
[string "=[C]"]: in function SetBackdrop' [string "@Interface\AddOns\ChampionCommander\libs\LibInit\MSA-DropDownMenu-1.0\MSA-DropDownMenu-1.0.lua"]:212: in function CreateDropDownList'
[string "@interface\AddOns\ChampionCommander\libs\LibInit\MSA-DropDownMenu-1.0\MSA-DropDownMenu-1.0.lua"]:390: in main chunk
[string "=[C]"]: ?
[string "=[C]"]: in function LoadAddOn' [string "@Interface\FrameXML\UIParent.lua"]:495: in function UIParentLoadAddOn'
[string "@interface\FrameXML\UIParent.lua"]:685: in function Garrison_LoadUI' [string "@Interface\FrameXML\GarrisonBaseUtils.lua"]:369: in function ShowGarrisonLandingPage'
[string "@interface\FrameXML\Minimap.lua"]:701: in function `GarrisonLandingPage_Toggle'
[string "@interface\FrameXML\Minimap.lua"]:693: in function <Interface\FrameXML\Minimap.lua:692>
[string "=[C]"]: ?

Locals:

commented

Same problem as OP. I get the buttons to complete all but nothing happens when I click it other than the mission table UI resets to Blizz default. Is it possible it's related to the changes listed here: https://github.com/Stanzilla/WoWUIBugs/wiki/9.0.1-Consolidated-UI-Changes#backdrop-system-changes ?

commented

The author is working on updates for ChampionCommander for sure (I'm not sure about the others.) And, I'm sure there will be a release soon.

But, for now, as a stop-gap measure, you can download the zip file at https://github.com/Amadeus-/ChampionCommander-Shadowlands/archive/master.zip and then overwrite the contents of your current ChampionCommander folder with the contents within the zip file. (Please note that you'll need to open the zip file, go to the "ChampionCommander-Shadowlands-master" folder within the zip file, then extract all the files/folders within to your current ChampionCommander folder. The files/folders should match exactly.) It's not perfect, but it removes the errors and gives you most of the functionality you need to enjoy the addon.

commented

The official release seems good now, so my stop-gap measure version is no longer required. This issue could be closed.

commented

Updated to new version but still getting errors

UPDATE: It seems you need to have Garrison Commander AND Champion Commander installed for Champion Commander to function correctly.

11x ...ceChampionCommander\libs\LibInit-56\factory.lua:278: attempt to call global 'MSA_DropDownMenu_Create' (a nil value) [string "@ChampionCommander\libs\LibInit-56\factory.lua"]:278: in function DropDown'
[string "@ChampionCommander\libs\LibInit-56\factory.lua"]:356: in function Option' [string "@ChampionCommander\missionlist.lua"]:739: in function Menu'
[string "@ChampionCommander\missionlist.lua"]:802: in function <ChampionCommander\missionlist.lua:797>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function Show' [string "@FrameXML\UIParent.lua"]:2893: in function SetUIPanel'
[string "@FrameXML\UIParent.lua"]:2699: in function ShowUIPanel' [string "@FrameXML\UIParent.lua"]:2606: in function <FrameXML\UIParent.lua:2602> [string "=[C]"]: in function SetAttribute'
[string "@FrameXML\UIParent.lua"]:3457: in function `ShowUIPanel'
[string "@FrameXML\UIParent.lua"]:1945: in function <FrameXML\UIParent.lua:1258>

Locals:
self =

{
Checkbox = defined @ChampionCommander\libs\LibInit\factory.lua:200
Dropdown = defined @ChampionCommander\libs\LibInit\factory.lua:273
nonce = 17
Button = defined @ChampionCommander\libs\LibInit\factory.lua:246
Option = defined @ChampionCommander\libs\LibInit\factory.lua:342
DropDown = defined @ChampionCommander\libs\LibInit\factory.lua:273
Slider = defined @ChampionCommander\libs\LibInit\factory.lua:126
}
father = {
0 =
OnEnter = defined @ChampionCommander\ChampionCommander.lua:661
Highlight = {
}
DefaultWidth = 220
movable = false
DragStop = defined @ChampionCommander\ChampionCommander.lua:281
ShowTT = defined @ChampionCommander\ChampionCommander.lua:289
DragStart = defined @ChampionCommander\ChampionCommander.lua:278
CounterTooltip = defined @ChampionCommander\ChampionCommander.lua:256
BorderTopLeft = {
}
OnDragStop = defined @ChampionCommander\ChampionCommander.lua:699
Dump = defined @ChampionCommander\ChampionCommander.lua:298
Bump = defined @ChampionCommander\ChampionCommander.lua:266
SetTitle = defined @ChampionCommander\ChampionCommander.lua:682
BorderBottomLeft = {
}
MakeMovable = defined @ChampionCommander\ChampionCommander.lua:685
Pulse = {
}
DebugOnLoad = defined @ChampionCommander\ChampionCommander.lua:263
Background = {
}
Tutorial = {
}
BorderTop = {
}
Title = {
}
OnLoad = defined @ChampionCommander\ChampionCommander.lua:658
BorderTopRight = {
}
BorderLeft = {
}
HideTT = defined @ChampionCommander\ChampionCommander.lua:295
Close = {
}
DumpData = defined @ChampionCommander\ChampionCommander.lua:307
BorderRight = {
}
AnchorTT = defined @ChampionCommander\ChampionCommander.lua:284
OnDragStart = defined @ChampionCommander\ChampionCommander.lua:696
Set = defined @ChampionCommander\ChampionCommander.lua:272
BorderBottom = {
}
BorderBottomRight = {
}
PinOpen = true
}
current = "Garrison_SortMissions_Original"
list =
{
Garrison_SortMissions_HourlyXp = "Global approx. xp reward per hour"
Garrison_SortMissions_Chance = "Success Chance"
Garrison_SortMissions_Class = "Reward type"
Garrison_SortMissions_Xp = "Global approx. xp reward"
Garrison_SortMissions_Original = "Original method"
Garrison_SortMissions_Level = "Level"
Garrison_SortMissions_Age = "Expiration Time"
Garrison_SortMissions_Duration = "Duration Time"
}
frame = {
message = "Sort missions by:"
maxwidth = 200
widgetType = "Dropdown"
SetOnChange = defined @ChampionCommander\libs\LibInit\factory.lua:277
tooltip = "Changes the sort order of missions in Mission panel"
0 =
SetObj = defined @ChampionCommander\libs\LibInit\factory.lua:106
}
name = "LibInitDropdown00017"
(*temporary) = nil
(*temporary) = "LibInitDropdown00017"
(*temporary) = {
message = "Sort missions by:"
maxwidth = 200
widgetType = "Dropdown"
SetOnChange = defined @ChampionCommander\libs\LibInit\factory.lua:277
tooltip = "Changes the sort order of missions in Mission panel"
0 =
SetObj = defined @ChampionCommander\libs\LibInit\factory.lua:106
}
(*temporary) = "attempt to call global 'MSA_DropDownMenu_Create' (a nil value)"
SetUp = defined @Interf`

commented

UPDATE: It seems you need to have Garrison Commander AND Champion Commander installed for Champion Commander to function correctly.

That lib should be located within /libs/libInit/MSA-DropDownMenu-1.0 ...and, it looks like it's being loaded properly via /libs/LibInit/LibInit.xml

I just tried ChampionCommander without any other addons loaded at all, and it worked just fine. So, maybe you need to delete your addons/ChampionCommander and reinstall. And, make sure it's coming with all libs.

commented

Even with the update, it's still not working for me. Tried reinstalling the addon, and I've already got Garrison Commander, but still nothing.